New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start new list item when not in a list #712

Closed
sanderboom opened this Issue Sep 8, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@sanderboom
Contributor

sanderboom commented Sep 8, 2017

Expected behaviour

Don't start new list item when not in a list

peek 2017-09-08 13-19

Actual behaviour

A new list item is created when we are not in a list.

Steps to reproduce

Enter: **bold text**, press 'enter'.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 8, 2017

Thank you, I will look at your pull request!

@pbek pbek added the enhancement label Sep 9, 2017

@pbek pbek added this to the 17.09.3 milestone Sep 9, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Sep 9, 2017

Looking good, thanks a lot! You are doing a great job!

17.09.3

There now is a new release, could you please test it and report if it works for you?

@ludenticus

This comment has been minimized.

Contributor

ludenticus commented Sep 9, 2017

17.09.3 solves this issue for me

@pbek

This comment has been minimized.

Owner

pbek commented Sep 10, 2017

Great, thank you for testing!

@pbek pbek closed this Sep 10, 2017

@sanderboom

This comment has been minimized.

Contributor

sanderboom commented Sep 11, 2017

Looking good, thanks a lot! You are doing a great job!

Thanks 😄
I hope I don't cause any regressions though 😬

@pbek

This comment has been minimized.

Owner

pbek commented Sep 11, 2017

we'll see, you changed quite some things... ;)

@ludenticus

This comment has been minimized.

Contributor

ludenticus commented Sep 12, 2017

I don't know if this is related, but now I found that whenever you type an asterisk in the middle of a sentence (i.e. not at its beginning, like when you do a list), it produces always another one. Problem? When you, for instance, type hello, and then you decide to italicize it (without the Ctrl+I shortcut), then it will produce double asterisks. Isn't it supposed to behave this way only when there is no word next to it (before or after)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment