New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on selecting multiple notes quickly [Win7/Arch Linux] #717

Closed
knobhead opened this Issue Sep 11, 2017 · 22 comments

Comments

Projects
None yet
3 participants
@knobhead

knobhead commented Sep 11, 2017

Hi there!

For quite some time I've been encountering a small glitch in QOwnNotes when selecting multiple notes in the notes list..
It's not critical, but can be annoying at times. It is reproducible on both Win7 64bit and Arch Linux 64bit.

Expected behaviour

Click a note in the notes list and hold the mouse key down.
Moving the mouse cursor up and/or down the notes list selects multiple notes.

Actual behaviour

Selecting multiple notes works only if you do it very slowly.
Selecting multiple notes quickly makes QON crash/close/disappear.

qownnots-crash-select-multiple-small

Steps to reproduce

see above

Output from the debug section in the settings dialog

see attached file QON_debug.txt

Relevant log output (you have to enable enable the log widget)

none

@pbek

This comment has been minimized.

Owner

pbek commented Sep 11, 2017

Thank you for reporting, I will try to reproduce your issue.
Is there any log-output (if you enable logging to file)?

@pbek

This comment has been minimized.

Owner

pbek commented Sep 11, 2017

Hm, it seems the crash happens in Qt's QSyntaxHighlighter::rehighlightBlock if you request highlighting very fast, like in your example. I'm yet not sure how we can get around that...

@pbek

This comment has been minimized.

Owner

pbek commented Sep 11, 2017

Are you able to reproduce the crash if you turn off markdown highlighting in the Editor-settings?

@knobhead

This comment has been minimized.

knobhead commented Sep 11, 2017

Hi Patricio,
thanks for your blazing fast reply, as always... 👍 🥇

The log file is empty.

And good guess – I can't reproduce the bug with markdown highlighting turned off (can only test win7 atm).

regards

@pbek

This comment has been minimized.

Owner

pbek commented Sep 11, 2017

thanks for your blazing fast reply, as always... 👍 🥇

:)

And good guess – I can't reproduce the bug with markdown highlighting turned off (can only test win7 atm).

I hope I'm able to find a workaround for that Qt-crash...

@ludenticus

This comment has been minimized.

Contributor

ludenticus commented Sep 12, 2017

I had noticed this bug every now and then, but I wasn't able to isolate it. I confirm that turning off the markdown highlighting prevents the crash under Arch (Qt 5.9.1)

@pbek

This comment has been minimized.

Owner

pbek commented Sep 12, 2017

Thank you for testing!

@pbek

This comment has been minimized.

Owner

pbek commented Sep 12, 2017

17.09.4

  • fixed a possible crash when selecting a lot of notes quickly in succession
    and improved speed of selecting notes in quick in succession

@pbek pbek added the bug label Sep 12, 2017

@pbek pbek added this to the 17.09.4 milestone Sep 12, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Sep 12, 2017

There now is a new release, could you please test it and report if it works for you?

@knobhead

This comment has been minimized.

knobhead commented Sep 12, 2017

Haha Patricio, you deliver faster than my pizza service! 😁 🥇

Works like a charm now (Win 7)!

@pbek

This comment has been minimized.

Owner

pbek commented Sep 12, 2017

code - 🍕
😄

Thank you for testing!

@pbek pbek closed this Sep 12, 2017

@ludenticus

This comment has been minimized.

Contributor

ludenticus commented Sep 12, 2017

Solved as well in arch...

@pbek

This comment has been minimized.

Owner

pbek commented Sep 12, 2017

Great, thank you for testing!

@knobhead

This comment has been minimized.

knobhead commented Jan 10, 2018

Hi Patricio, I'm afraid this one might have sneaked back into QOwnNotes... I'm on Win7 64bit and QON 18.01.1 here.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2018

Could you please test the previous release if that also happens: https://ci.appveyor.com/project/pbek/qownnotes/build/windows-b3415/artifacts

maybe it's related to #826

@knobhead

This comment has been minimized.

knobhead commented Jan 10, 2018

yup, that's it ... previous release works fine.

(glad you don't ask why I always select so many notes so quickly 😛)

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2018

...because you can! :)

thank you for testing and reporting!

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2018

18.01.2

  • attempted to fix drawing problems in the note edit widget and possible crashes in Windows

There now is a new release, could you please test it and report if it works for you?

@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

one more try

18.01.3

  • fixed the disabling of the markdown highlighting
  • attempted to fix drawing problems in the note edit widget and possible
    crashes in Windows
@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

@knobhead
There now is a new release, could you please test it and report if it works for you?

@knobhead

This comment has been minimized.

knobhead commented Jan 13, 2018

Works like a charm now! [can only test on Arch Linux atm] Thanks, Patrizio!

Now if you'll excuse me, I've got some donation to send... ;-)

@pbek

This comment has been minimized.

Owner

pbek commented Jan 13, 2018

Great, thank you for testing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment