New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for note name when creating new note #740

Closed
Maboroshy opened this Issue Oct 8, 2017 · 19 comments

Comments

Projects
None yet
3 participants
@Maboroshy
Contributor

Maboroshy commented Oct 8, 2017

On new tag or new note sub-folder creation app asks for a name. But it doesn't do that when creating new note. User has to rename new note in most cases. I propose to fix this inconsistency by showing same "ask for name" dialog when creating new note by button or by context menu.

@pbek pbek added the question label Oct 8, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Oct 8, 2017

Nah, the whole reason I created QOwnNotes was to create a note very quickly without asking for a name! 😆 That was the main feature of the very first release.

If you want a name just enter it in the note search line-edit and press enter...

@pbek pbek closed this Oct 8, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Oct 8, 2017

And you always can open a dialog in a script with the hook that set the note name...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 8, 2017

handleNewNoteHeadlineHook works only for headline. It doesn't change new note name if headline = name option is off.
Using handleNoteTextFileNameHook will require some very hacky solutions I'd rather not implement.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 8, 2017

Can't you live with the shortcut to get to the search line-edit and enter the name there?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 8, 2017

I can, but it looks kind of anachronism in the current UI. There are options to disable search lines for all panes, and I do enable all of them. I like to use as minimalistic UI as possible. And, as I've stated earlier, all other nameable items ask for name when created by context menu. But main item - note doesn't.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 8, 2017

Asking for a note name would defy the main reason I wrote QOwnNotes.

@pbek pbek added enhancement and removed question labels Oct 9, 2017

@pbek pbek reopened this Oct 9, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Oct 9, 2017

17.10.3

  • you now can enable in the General settings that the shortcut to create new
    notes asks for a headline of the note instead of generating the headline
    automatically

@pbek pbek added this to the 17.10.3 milestone Oct 9, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Oct 9, 2017

in addition just for you:

17.10.3

@pbek

This comment has been minimized.

Owner

pbek commented Oct 9, 2017

There now is a new release, could you please test it and report if it works for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 9, 2017

It asks for a note name and creates note with that name ... but it creates Note 2017-10-09... and jumps to it at the same time.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 9, 2017

creates note with that name ... but it creates Note 2017-10-09.

which of the two is it then?
It didn't do that for me, do you have any script enabled that might interfere?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 9, 2017

It creates two notes: one that with the given name and headline, other with default name and headline.
I disabled all the scripts and restarted the app. Same result.
I created notes by note list context menu.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 9, 2017

That's strange, I will take a look at the code tomorrow.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 10, 2017

17.10.4

  • fixed that a 2nd note is created if the non-automatic headlines for new
    notes are enabled
@pbek

This comment has been minimized.

Owner

pbek commented Oct 10, 2017

There now is a new release, could you please test it and report if it works for you?

@ludenticus

This comment has been minimized.

Contributor

ludenticus commented Oct 10, 2017

17.10.3 was producing two notes, but it is now fixed in 17.10.4

@pbek

This comment has been minimized.

Owner

pbek commented Oct 10, 2017

Great, thank you for testing!

@pbek pbek closed this Oct 10, 2017

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 10, 2017

I confirm. Everything works properly now. Thanks for this feature. I think it makes the app more consistent.

I posted into wrong issue at first. 😵

@pbek

This comment has been minimized.

Owner

pbek commented Oct 10, 2017

As always, your wish is my command. 😸

(me too) 😨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment