New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Header H2 with '-' #763

Closed
m-wim opened this Issue Nov 5, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@m-wim

m-wim commented Nov 5, 2017

Expected behaviour

single line after H2 text containing only '-' (minus) should remain an mark the previous line as H2 (the markdown documentation does not specify a certain amount of - )

Actual behaviour

A line with the single '-' gets deleted when [Enter] is pressed
whilst sometimes the display of the H2 text changes to H2 format

Steps to reproduce

write some text [Enter]
[-] [Enter]
[[every line with a single - gets deleted when enter is pressed]]

Output from the debug section in the settings dialog

QOwnNotes Debug Information

General Info

Current Date: So Nov 5 13:16:36 2017
Version: 17.10.10
Build date: Oct 30 2017
Build number: 3329
Platform: windows
Operating System: Windows 10
Build architecture: i386
Current architecture: x86_64
Release: AppVeyor
Qt Version (build): 5.7.1
Qt Version (runtime): 5.7.1
Portable mode: no
Settings path / key: \HKEY_CURRENT_USER\Software\PBE\QOwnNotes
Application database path: C:\Users\wim\AppData\Roaming\PBE\QOwnNotes\QOwnNotes.sqlite
Application arguments: C:\wim\Tools\QOwnNotes\QOwnNotes.exe
Qt Debug: 0
Locale (system): de_DE
Locale (interface): de
Icon theme: breeze-qownnotes
Notes in current note folder: 10
Enabled scripts: 1

Server Info

serverUrl: empty
appIsValid: no
notesPathExists: empty
connectionErrorMessage: empty

Note folders

currentNoteFolderId: 2

Note folder New Folder

id: 2
isCurrent: yes
activeTagId: -1
localPath: C:\wim\Data\QOwnNotes
remotePath: empty
isShowSubfolders: yes
isUseGit: no
activeNoteSubFolder name: empty
database file: C:\wim\Data\QOwnNotes\notes.sqlite

Enabled scripts

Script WikiImport

id: 1
path: C:\wim\Data\QOwnNotes\WikiImport.qml
variablesJson: empty

Settings

AboutDialog/geometry: <binary data>
ActionDialog/geometry: <binary data>
ActiveNoteHistoryItem: empty
Debug/fakeOldVersionNumber: false
Debug/fileLogging: false
Editor/CurrentSchemaKey: EditorColorSchema-6033d61b-cb96-46d5-a3a8-20d5172017eb
Editor/autoBracketClosing: true
Editor/autoBracketRemoval: true
Editor/highlightCurrentLine: true
LastUpdateCheck: 2017-11-05T13:05:02
LinkDialog/geometry: <binary data>
MainWindow/geometry: <binary data>
MainWindow/mainToolBar.iconSize: 24
MainWindow/menuBarGeometry: <binary data>
MainWindow/noteSubFolderTreeWidgetExpandState-2: Unterordner
MainWindow/noteTextEdit.code.font: Lucida Console,11,-1,5,50,0,0,0,0,0
MainWindow/noteTextEdit.font: MS Shell Dlg 2,11,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.code.font: Courier New,14,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.font: MS Shell Dlg 2,12,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.rtl: false
MainWindow/showNotesFromAllNoteSubFolders: false
MainWindow/tagTreeWidgetExpandState-2: 6, 8, 2
PiwikClientId: <hidden>
SettingsDialog/geometry: <binary data>
SettingsDialog/mainSplitterState: <binary data>
ShowSystemTray: false
TableDialog/geometry: <binary data>
TagAddDialog/geometry: <binary data>
UpdateDialog/geometry: <binary data>
acceptAllExternalModifications: false
allowDifferentNoteFileName: false
allowOnlyOneAppInstance: true
appMetrics/disableAppHeartbeat: false
appMetrics/disableTracking: true
appMetrics/notificationShown: true
cryptoKey: <hidden>
currentNoteFolderId: 2
currentWorkspace: 1d0e068f-a588-4525-bca5-49736cb0119f
cursorWidth: 1
customNoteFileExtensionList: wiki
darkMode: false
darkModeColors: false
darkModeTrayIcon: false
defaultNoteFileExtension: wiki
demoNotesCreated: true
disableAutomaticUpdateDialog: false
dockWasInitializedOnce: true
externalEditorPath: empty
gitCommitInterval: 30
gitExecutablePath: empty
gitLogCommand: empty
ignoreAllExternalModifications: false
ignoreAllExternalNoteFolderChanges: false
imageScaleDown: false
imageScaleDownMaximumHeight: 1024
imageScaleDownMaximumWidth: 1024
insertTimeFormat: empty
interfaceLanguage: de
internalIconTheme: false
itemHeight: 15
markdownHighlightingEnabled: true
networking/ignoreSSLErrors: true
networking/proxyType: 0
noteSaveIntervalTime: 10
noteSubfoldersPanelDisplayAsFullTree: true
noteSubfoldersPanelHideSearch: false
noteSubfoldersPanelOrder: 0
noteSubfoldersPanelShowFullPath: false
noteSubfoldersPanelShowRootFolderName: true
noteSubfoldersPanelSort: 0
notesPanelOrder: 0
notesPanelSort: 1
notesPath: C:/wim/Data/QOwnNotes
notifyAllExternalModifications: true
ownCloud/ignoreNonTodoCalendars: true
ownCloud/password: <hidden>
ownCloud/serverUrl: empty
ownCloud/supportEnabled: false
ownCloud/todoCalendarBackend: 0
ownCloud/todoCalendarCalDAVPassword: <hidden>
ownCloud/todoCalendarCalDAVServerUrl: empty
ownCloud/todoCalendarCalDAVUsername: empty
ownCloud/todoCalendarEnabledList: empty
ownCloud/todoCalendarEnabledUrlList: empty
ownCloud/todoCalendarUrlList: empty
ownCloud/userName: empty
previousWorkspace: 96925885-7adb-495c-98b2-5d7a4e24b100
recentNoteFolders: C:/wim/Data/Wiki/Programming/data
restoreCursorPosition: true
savedSearches/noteFolder-2: Note 2017-11-05T13.06.21, Note 2017-11-04T09.53.44, Note 2017-05-07T11.46.30
showMenuBar: true
showStatusBar: true
showTagPaneUnderNavigationPane: false
tagWasAddedToNote: true
tagsPanelHideSearch: false
tagsPanelOrder: 0
tagsPanelSort: 0
toolbar/1/items: action_New_note, action_Find_note, action_Remove_note, action_Open_note_in_external_editor, , action_Back_in_note_history, action_Forward_in_note_history, , action_Find_text_in_note, actionReplace_in_current_note, , actionShow_versions, actionShow_trash, actionShare_note, , actionOpen_List
toolbar/1/name: mainToolBar
toolbar/1/title: Hauptsymbolleiste
toolbar/2/items: actionFormat_text_bold, actionFormat_text_italic, actionStrike_out_text, actionInsert_code_block, actionInsert_block_quote
toolbar/2/name: formattingToolbar
toolbar/2/title: Formatierungs-Werkzeugleiste
toolbar/3/items: actionInsert_Link_to_note, actionInsert_image, actionInsert_current_time
toolbar/3/name: insertingToolbar
toolbar/3/title: Einfügen-Werkzeugleiste
toolbar/4/items: action_Encrypt_note, actionEdit_encrypted_note, actionDecrypt_note
toolbar/4/name: encryptionToolbar
toolbar/4/title: Werkzeugleiste Verschlüsselung
toolbar/5/items: actionWorkspaceComboBox, actionStore_as_new_workspace, actionRemove_current_workspace, actionRename_current_workspace, actionSwitch_to_previous_workspace, actionUnlock_panels, , actionToggle_distraction_free_mode, action_Increase_note_text_size, action_Decrease_note_text_size, action_Reset_note_text_size
toolbar/5/name: windowToolbar
toolbar/5/title: Fenster-Werkzeugleiste
toolbar/6/items: action_Quit
toolbar/6/name: quitToolbar
toolbar/6/title: Beenden - Symbolleiste
toolbar/size: 6
useUNIXNewline: false
workspace-1d0e068f-a588-4525-bca5-49736cb0119f/name: Minimal
workspace-1d0e068f-a588-4525-bca5-49736cb0119f/noteSubFolderDockWidgetVisible: true
workspace-1d0e068f-a588-4525-bca5-49736cb0119f/windowState: <binary data>
workspace-96925885-7adb-495c-98b2-5d7a4e24b100/name: Vollständig
workspace-96925885-7adb-495c-98b2-5d7a4e24b100/noteSubFolderDockWidgetVisible: true
workspace-96925885-7adb-495c-98b2-5d7a4e24b100/windowState: <binary data>
workspaces: 96925885-7adb-495c-98b2-5d7a4e24b100, 1d0e068f-a588-4525-bca5-49736cb0119f

System environment

ALLUSERSPROFILE: C:\ProgramData
APPDATA: C:\Users\wim\AppData\Roaming
CommonProgramFiles: C:\Program Files (x86)\Common Files
CommonProgramFiles(x86): C:\Program Files (x86)\Common Files
CommonProgramW6432: C:\Program Files\Common Files
COMPUTERNAME: WIM2013
ComSpec: C:\WINDOWS\system32\cmd.exe
FPS_BROWSER_APP_PROFILE_STRING: Internet Explorer
FPS_BROWSER_USER_PROFILE_STRING: Default
FP_NO_HOST_CHECK: NO
HOMEDRIVE: C:
HOMEPATH: \Users\wim
JAVA_HOME: c:\Program Files\Java\jdk1.8.0_91
LOCALAPPDATA: C:\Users\wim\AppData\Local
LOGONSERVER: \\WIM2013
NUMBER_OF_PROCESSORS: 4
OneDrive: C:\Users\wim\OneDrive
OS: Windows_NT
Path: C:\ProgramData\Oracle\Java\javapath;C:\Python35\Lib\site-packages\PyQt5;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Ecere SDK\bin;C:\Program Files (x86)\Ecere SDK\bin;C:\Program Files\Ecere SDK\tdm\bin;C:\Program Files\Ecere SDK\upx\bin;C:\Program Files (x86)\Ecere SDK\tdm\bin;C:\wim\Tools\OpenVPN\bin;C:\Python35\Scripts\;C:\Python35\;C:\Users\wim\.dnx\bin;C:\Users\wim\AppData\Local\.meteor\;C:\Users\wim\AppData\Roaming\npm;C:\Program Files (x86)\CVSNT\;C:\Users\wim\AppData\Local\Microsoft\WindowsApps
PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PROCESSOR_ARCHITECTURE: x86
PROCESSOR_ARCHITEW6432: AMD64
PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 60 Stepping 3, GenuineIntel
PROCESSOR_LEVEL: 6
PROCESSOR_REVISION: 3c03
ProgramData: C:\ProgramData
ProgramFiles: C:\Program Files (x86)
ProgramFiles(x86): C:\Program Files (x86)
ProgramW6432: C:\Program Files
PSModulePath: C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\
PUBLIC: C:\Users\Public
SESSIONNAME: Console
SystemDrive: C:
SystemRoot: C:\WINDOWS
TBBROOT: C:\work\space\Intel_CnC-1.0.100\\tbb42_20140122oss
TEMP: C:\Users\wim\AppData\Local\Temp
TMP: C:\Users\wim\AppData\Local\Temp
USERDOMAIN: wim2013
USERDOMAIN_ROAMINGPROFILE: wim2013
USERNAME: wim
USERPROFILE: C:\Users\wim
windir: C:\WINDOWS
windows_tracing_flags: 3
windows_tracing_logfile: C:\BVTBin\Tests\installpackage\csilogfile.log

Relevant log output (you have to enable enable the log widget)

none

@pbek

This comment has been minimized.

Owner

pbek commented Nov 5, 2017

That behavior is to end the entering of lists. I guess I could change the triggering to - (with a space at the end) without doing much harm...

@pbek pbek added the enhancement label Nov 5, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 6, 2017

17.11.0

  • list symbols like * and - will now only be removed in an empty line when
    pressing Return if there was a space-character after them

@pbek pbek added this to the 17.11.0 milestone Nov 6, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 6, 2017

There now is a new release, could you please test it and report if it works for you?

@m-wim

This comment has been minimized.

m-wim commented Nov 8, 2017

works fine! Thank you.

@m-wim m-wim closed this Nov 8, 2017

@m-wim m-wim reopened this Nov 8, 2017

@m-wim m-wim closed this Nov 8, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 8, 2017

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment