New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Note subfolders Panel] > [Show with full path] is always enabled (even when unchecked) #777

Closed
S-ed opened this Issue Nov 17, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@S-ed

S-ed commented Nov 17, 2017

Expected behavior

Should show only folder name and not the full path.

Actual behaviour

Showing full path even while unchecked

Steps to reproduce

[Settings] > [Panels] >[Note subfolders panel] > [Show root folder name] (Enabled)
[Settings] > [Panels] > [Note subfolders panel] > [Show with full path] (Disabled)

QOwnNotes Debug Information

General Info

Current Date: Fri Nov 17 18:17:33 2017
Version: 17.11.2
Build date: Nov 16 2017
Build number: 3347
Platform: windows
Operating System: Windows 10
Build architecture: i386
Current architecture: x86_64
Release: AppVeyor
Qt Version (build): 5.7.1
Qt Version (runtime): 5.7.1
Portable mode: no

screenshot 1510931813

*please tell me if more debug info required (I have certain level of security paranoia)

@S-ed S-ed changed the title from [Subfolders Panel] > [Show with full path] is always enabled (even when unchecked) to [Note subfolders Panel] > [Show with full path] is always enabled (even when unchecked) Nov 17, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2017

Thank you for reporting, I will try to reproduce your issue.

@pbek

This comment has been minimized.

Owner

pbek commented Nov 19, 2017

@derboblan, I think that might be your code from #588. ;) Is that something you can reproduce?

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

@S-ed, I cannot reproduce your issue. The indicated setting toggles the behavior as it should. Also in the source-code everything is looking good.

settings.value("noteSubfoldersPanelShowFullPath").toBool()));

Are you sure the note-subfolder tree was reloaded after you turned off the setting?

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

Ah, the way your screenshot looks you were using it on Windows, where I can reproduce your issue. I tested it under Linux.
It is now fixed.

@S-ed

This comment has been minimized.

S-ed commented Nov 20, 2017

Yeah. I though it may be a OS related issue, that's why I've added part of the Debug info.
Thank You!

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

I only recognized it after looking at the source code from the pull-request. ;)

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

17.11.3

  • the disabling of the setting Show with full in the Panel settings now
    also works under Windows

@pbek pbek added this to the 17.11.3 milestone Nov 20, 2017

@pbek pbek added the bug label Nov 20, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

There now is a new release, could you please test it and report if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment