New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor colors "Text preset" only sets BG color under the text in custom windows #778

Closed
S-ed opened this Issue Nov 17, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@S-ed

S-ed commented Nov 17, 2017

Expected behavior

Overall window BG color respect the settings for "Text preset"

Actual behaviour

BG of the window is not affected

Steps to reproduce

Set custom BG color for "Text preset" under [Settings] > [Interface] > [Editor] > [Editor fonts & Colors]
Open a Debug view, or open Note in new window.

QOwnNotes Debug Information

General Info

Current Date: Fri Nov 17 18:31:12 2017
Version: 17.11.2
Build date: Nov 16 2017
Build number: 3347
Platform: windows
Operating System: Windows 10
Build architecture: i386
Current architecture: x86_64
Release: AppVeyor
Qt Version (build): 5.7.1
Qt Version (runtime): 5.7.1
Portable mode: no
Settings path / key: \HKEY_CURRENT_USER\Software\PBE\QOwnNotes
Application database path: C:\Users\S-ed\AppData\Roaming\PBE\QOwnNotes\QOwnNotes.sqlite
Application arguments: C:\Dev\TextEditors\QOwnNotes\QOwnNotes.exe
Qt Debug: 0
Locale (system): en_US
Locale (interface): empty
Icon theme: breeze-dark-qownnotes

screenshot 1510933007

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2017

Thank you for reporting, I will try to reproduce your issue.

@pbek pbek added the enhancement label Nov 20, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

17.11.3

  • the default foreground and background colors for the note text-edit, that was
    set in the in the Editor settings now also work for other Markdown
    text-edits, like the Debug panel, the separate note-views and the Debug
    settings

@pbek pbek added this to the 17.11.3 milestone Nov 20, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

There now is a new release, could you please test it and report if it works for you?

@S-ed

This comment has been minimized.

S-ed commented Nov 20, 2017

I've tried but...

screenshot 1511197028

On website:
screenshot 1511197137
And then:
screenshot 1511197154

On github as well:
screenshot 1511197322

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

Give GitHub und all the caches after it some time. ;)

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

And of course the build processes...

@S-ed

This comment has been minimized.

S-ed commented Nov 20, 2017

#778 and #777 seems fixed.
Thank you!

@pbek

This comment has been minimized.

Owner

pbek commented Nov 20, 2017

Great, thank you for testing!

@pbek pbek closed this Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment