Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in preview #800

Closed
accountgit opened this issue Dec 1, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@accountgit
Copy link

commented Dec 1, 2017

Expected behaviour

When you right click on a link in preview appears the correct options (copy/copy link location) but are greyed and can't be selected.

@pbek

This comment has been minimized.

Copy link
Owner

commented Dec 1, 2017

I'm sorry, those two menu items are controlled by Qt. Copy will be selectable if you select a text. I haven't found a way to make Copy link location work, yet.

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

@santiyounger, @accountgit, I now implemented it myself

19.6.4

  • if you right-click on a link in the preview you now can select Copy link location
    to copy the location of the link

@pbek pbek added the enhancement label Jun 22, 2019

@pbek pbek added this to the 19.6.4 milestone Jun 22, 2019

pbek added a commit that referenced this issue Jun 22, 2019

pbek added a commit that referenced this issue Jun 22, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

@santiyounger, @accountgit, there now is a new release, could you please test it and report if it works for you?

@santiyounger

This comment has been minimized.

Copy link

commented Jun 24, 2019

Hey, thanks so much for working on that feature, unfortunaly "copy link location" it's still not clickable for me. It might be something on my side with the update not installing properly. I'll get back to this thread as soon as it works!
Thanks
-Santi

@bendem

This comment has been minimized.

Copy link

commented Jun 24, 2019

On macOS, the copy link location is listed twice now, one greyed out, one clickable:

Screenshot 2019-06-24 at 16 27 23

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 24, 2019

@bendem, that's true. I can't get rid of the default one without getting rid of all other default menu items...

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 24, 2019

@santiyounger don't you get a new context menu entry?

@pbek pbek closed this Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.