New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove Current Workspace #802

Closed
BlackCanopus opened this Issue Dec 2, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@BlackCanopus

BlackCanopus commented Dec 2, 2017

Expected behaviour

When we click 'Remove Current Workspace' a dialog box opens, asking whether we are sure or not. Yes should remove it, NO should cancel it.

Actual behaviour

It works the other way! If we click Yes, it will cancel. If we click no, it will act as Yes and remove it. This is a simple bug.

Steps to reproduce

Try to remove the current workspace. Then click Yes.

Output from the debug section in the settings dialog

Relevant log output (you have to enable enable the log widget)

@BlackCanopus

This comment has been minimized.

BlackCanopus commented Dec 2, 2017

P.S. It reminds me of my ex. She meant Yes when she said No, she meant No when she said Yes.

@pbek

This comment has been minimized.

Owner

pbek commented Dec 2, 2017

:)

Thank you for reporting, yesterday I re-implemented 40 dialogs, I guess I got this one wrong.

@pbek pbek added the bug label Dec 2, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Dec 3, 2017

17.12.1

  • fixed the confirmation for removing the current workspace

@pbek pbek added this to the 17.12.1 milestone Dec 3, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Dec 3, 2017

There now is a new release, could you please test it and report if it works for you?

@BlackCanopus

This comment has been minimized.

BlackCanopus commented Dec 3, 2017

Wow, that was an incredibly quick update. And yes, it works.

@pbek

This comment has been minimized.

Owner

pbek commented Dec 3, 2017

Great, thank you for testing!

@pbek pbek closed this Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment