New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add width attribute to images #808

Closed
sanderboom opened this Issue Dec 10, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@sanderboom
Contributor

sanderboom commented Dec 10, 2017

Expected behaviour

An image in the preview panel will always have a width attribute.

Actual behaviour

An image in the preview panel only has a width attribute when the original width was larger than the width of the note preview panel.

I'll add a PR.

sanderboom added a commit to sanderboom/QOwnNotes that referenced this issue Dec 10, 2017

@pbek pbek added the enhancement label Dec 10, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Dec 10, 2017

I will test that.

@pbek

This comment has been minimized.

Owner

pbek commented Dec 10, 2017

Doesn't seem to break anything...

pbek added a commit that referenced this issue Dec 10, 2017

@pbek pbek added this to the 17.12.3 milestone Dec 10, 2017

@sanderboom

This comment has been minimized.

Contributor

sanderboom commented Dec 10, 2017

Doesn't seem to break anything...

For a change 😜

@pbek

This comment has been minimized.

Owner

pbek commented Dec 10, 2017

I'll keep my mouth shut and my lips sealed. 😀

@pbek

This comment has been minimized.

Owner

pbek commented Dec 11, 2017

17.12.3

  • a width attribute is now always added to images in the preview to make the
    life of script developers easier
@pbek

This comment has been minimized.

Owner

pbek commented Dec 11, 2017

There now is a new release, could you please test it and report if it works for you?

@sanderboom

This comment has been minimized.

Contributor

sanderboom commented Dec 12, 2017

Works! Thanks.

@pbek

This comment has been minimized.

Owner

pbek commented Dec 12, 2017

Great, thank you for testing!

@pbek pbek closed this Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment