New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog Dialog popping up #813

Closed
dragotin opened this Issue Dec 22, 2017 · 12 comments

Comments

Projects
None yet
2 participants
@dragotin

dragotin commented Dec 22, 2017

Expected behaviour

No interruption from QOwnNotes

Actual behaviour

The "There is a new version" dialog keeps popping up.

Steps to reproduce

I am using the packages for openSUSE and have the repository regiestered and activated. That gives me access to the latest versions as they appear in the build service repo.

As a result, I am not so interested in learning about the new versions in a dialog that is popping up quite often, which is basically only interrupting me.

I realize that this dialog might be an interesting feature for people who built from source or tarball.

Could we consider to:

  • Have a switch [ ] Don't show again that prevents the dialog from coming again
  • Have a way to disable the dialog completely during build time, which could be used in the package build instruction.

@pbek pbek added the question label Dec 22, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

There is a setting for the update dialog in the General settings.
Does that answer your question?

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

But if you are using the openSUSE OBS repository that already should be turned off for you...

@dragotin

This comment has been minimized.

dragotin commented Dec 22, 2017

Ok, that makes sense, I found it. That is fine. Sorry for the noise.

IIRC I use the OBS packages from home:pbek:QOwnNotes since I started with QON but the dialog was showing up. There might be a bug.

Thanks!

@dragotin dragotin closed this Dec 22, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

Could you please start QOwnNotes --session test to use a different session (with new settings) and tell me if the update dialog is still allowed in the settings?

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

Because if you always have used OBS this shouldn't happen.

according to:

/**
* Disables the automatic update dialog per default for repositories and
* self-builds if nothing is already set
*/
void Utils::Misc::presetDisableAutomaticUpdateDialog() {
QSettings settings;
// disable the automatic update dialog per default for repositories and
// self-builds
if (settings.value("disableAutomaticUpdateDialog").toString().isEmpty()) {
QString release = qApp->property("release").toString();
bool enabled = release.contains("Travis") ||
release.contains("AppVeyor") || release.contains("AppImage");
settings.setValue("disableAutomaticUpdateDialog", !enabled);
}

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

And could you please post the General Info block of the Debug settings to see which release you are using now...

@dragotin

This comment has been minimized.

dragotin commented Dec 22, 2017

Ok, I started in a new session, and the switch "Do not show Update dialog automatically" is switched on. Which is what you say. At startup, the dialog was not appearing.

I guess all is good.

The debug info:

General Info

Current Date: Fr. Dez. 22 13:53:31 2017
Version: 17.12.5
Build date: Dec 14 2017
Build number: 407
Platform: linux
Operating System: openSUSE Leap 42.2
Build architecture: x86_64
Current architecture: x86_64
Release: OBS
Qt Version (build): 5.6.1
Qt Version (runtime): 5.6.1
Portable mode: no
Settings path / key: /home/kf/.config/PBE/QOwnNotes-test.conf
Application database path: /home/kf/.local/share/PBE/QOwnNotes-test/QOwnNotes.sqlite
Application arguments: QOwnNotes, --session, test
Qt Debug: 0
Locale (system): de_DE
Locale (interface): empty
Icon theme: breeze
Notes in current note folder: 3
Enabled scripts: 0

...which is interesting: The debuginfo shows release: OBS, which would not be matched by the code above if I see that correctly.

BTW, are you sure that instantiating QSettings() without any arguments defaults to the right settings on disk? Otherwise the code above would operate on an empty settings object.

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

The question is you installed QOwnNotes before from an other source... (and when did you first install QOwnNotes)

BTW, are you sure that instantiating QSettings() without any arguments defaults to the right settings on disk?

QSettings uses the application information to determine where to store the settings, I overwrite those at the beginning...

@dragotin

This comment has been minimized.

dragotin commented Dec 22, 2017

I just don't know if I installed it before from source. I guess we can leave it here. Thanks for your help!

@pbek

This comment has been minimized.

Owner

pbek commented Dec 22, 2017

pbek added a commit that referenced this issue Sep 6, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2018

18.09.0

  • there now is a new button in the Update dialog to don't show the dialog
    automatically any more
    • this button does the same as the checkbox to disable the update dialog in
      the General settings
@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2018

Finally there. :) There now is a new release, could you please test it and report if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment