New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many strings including "NextCloud/ownCloud" are not shown correctly in german UI #850

Closed
rakekniven opened this Issue Feb 15, 2018 · 15 comments

Comments

Projects
None yet
2 participants
@rakekniven
Contributor

rakekniven commented Feb 15, 2018

Expected behaviour

Strings should be displayed as translated at crowdin

Actual behaviour

Strings containing "NextCloud/ownCloud" are showing to "Nextcloud" words.

Steps to reproduce

Example translation:
2018-02-15_16h14_24

See translation of settings dialog:
2018-02-15_16h05_17

Is there any magic?

Output from the debug section in the settings dialog

Relevant log output (you have to enable enable the log widget)

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 15, 2018

FYI: These days I changed many strings in german translation

"ownCloud / Nextcloud" > "Nextcloud/ownCloud" (Removed spaces and alphabetical sorting).

btw. There are way to many times showing Cloudnames in settings dialog

@pbek

This comment has been minimized.

Owner

pbek commented Feb 15, 2018

I see you translated ownCloud to ownCloud / Nextcloud... That causes the problem because there is a method Utils::Misc::replaceOwnCloudText that also replaces that text...

@pbek

This comment has been minimized.

Owner

pbek commented Feb 15, 2018

I will add a workaround for too enthusiastic translations. ;)

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 15, 2018

No need for an workaround: What should be in source?
If source is ok then you just can replace to "Nextcloud/ownCloud" instead of "ownCloud / Nextcloud"?

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 15, 2018

In german I will remove such magic strings to tidy up settings dialog.
If you like it you can adapt source strings :-)

Will append screenshot here after work and next release.

@pbek

This comment has been minimized.

Owner

pbek commented Feb 15, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Feb 15, 2018

18.02.3

  • added a workaround for certain translations of the word ownCloud

@pbek pbek added this to the 18.02.3 milestone Feb 15, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Feb 15, 2018

There now is a new release, could you please test it and report if it works for you?

rakekniven referenced this issue Feb 15, 2018

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 16, 2018

Looks better:
grafik

Will do some tidy up on the weekend. Should I report my result here or open another issue?

@pbek

This comment has been minimized.

Owner

pbek commented Feb 16, 2018

You can report here. Thank you for testing.

@pbek pbek closed this Feb 16, 2018

@rakekniven rakekniven changed the title from Many strings including "NextCloud/ownCloud" shown not correct in german interface to Many strings including "NextCloud/ownCloud" are not shown correctly in german UI Feb 16, 2018

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 23, 2018

grafik

Removed around 10 occurences of string"Nextcloud / ownCloud". UI looks more sober IMHO.
Please compare with screenshot above.

@pbek What are your thoughts?

@pbek

This comment has been minimized.

Owner

pbek commented Feb 23, 2018

Removed around 10 occurences of string"Nextcloud / ownCloud".

...in the German translation, right?

UI looks more sober IMHO.

Looks great, good job!

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 23, 2018

Yes, done via changing german strings.

Should I try to change this items in source code as well by providing a PR?

@pbek

This comment has been minimized.

Owner

pbek commented Feb 23, 2018

Should I try to change this items in source code as well by providing a PR?

No, please don't. I didn't want to invalidate all those texts just because oC was forked.

@rakekniven

This comment has been minimized.

Contributor

rakekniven commented Feb 24, 2018

It is not about the fork.
The setup form shows many many occurrences of “OwnCloud / Nextcloud“.
The changes would tidy up form as shown above.
And it make it product independant. Whatever gets forked or renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment