New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script actions make QON try to save note which have no write persmission #916

Closed
Maboroshy opened this Issue May 21, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@Maboroshy
Contributor

Maboroshy commented May 21, 2018

Expected behaviour

QON generally knows how to handle notes that it cannot write to. It uses read-only mode for them.

Actual behaviour

Looks like script actions that write to note file don't know about read-only mode. If I add some text to a note that has no write permission by noteTaggingHook QON will continuously try to save it.

Relevant log output in the Log panel

[20:23:53] [critical] "Could not store note file: /path/to/note.md - Error message: Permission denied"
Every second

@pbek

This comment has been minimized.

Owner

pbek commented May 21, 2018

Ill take a look at that.

@pbek

This comment has been minimized.

Owner

pbek commented May 24, 2018

18.05.7

  • it now will not be attempted to store a new note text if the note file is read-only
    • this was especially a problem for the noteTaggingHook scripting
      method, because the note text is modified there most of the time
      • but the user interface still might think that a tag was added to or
        removed from a note, because the noteTaggingHook scripting method
        might not necessarily modify the note text, but use for example an
        external database

@pbek pbek added this to the 18.05.7 milestone May 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented May 24, 2018

There now is a new release, could you please test it and report if it works for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented May 24, 2018

Looks like everything works as intended and with described side-effects.

@Maboroshy Maboroshy closed this May 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented May 24, 2018

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment