New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note tags panel can't handle multiple notes #946

Closed
Maboroshy opened this Issue Jun 21, 2018 · 55 comments

Comments

Projects
None yet
3 participants
@Maboroshy
Contributor

Maboroshy commented Jun 21, 2018

Expected behaviour

  1. Select multiple notes
  2. Add new tag at note tags panel
  3. All the notes are tagged

Actual behaviour

  1. Select multiple notes
  2. Add new tag at note tags panel
  3. Only the last selected note is tagged
@bepolymathe

This comment has been minimized.

bepolymathe commented Jun 21, 2018

I can't reproduce that.

I have a dialog box that opens offering to apply it to everyone or not. Maybe you clicked "no "+"remember my choice" the first time?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 21, 2018

I've just used "Reset message boxes", restarted the app and got no such dialog. I'm on 18.06.4 from AUR.

@bepolymathe

This comment has been minimized.

bepolymathe commented Jun 21, 2018

Strange... no error message in journal panel ?
I'am on 18.06.4 from Fedora

@pbek pbek added enhancement question and removed enhancement labels Jun 21, 2018

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 21, 2018

I'll make some checks on my Win7 VM to be sure.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 21, 2018

Are we talking about tagging notes with the context menu in the note list? Because that works for me.
Or are we really talking about the Note tags panel, that only is supposed to show the tags of the current note and add/remove tags to/from the current note?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 21, 2018

I'm talking about Note tags panel. Context menu can't create tags.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 21, 2018

You can add tags in the Tags panel.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 21, 2018

There even is a search line edit there (that you can hide in the settings) to add tags.

@bepolymathe

This comment has been minimized.

bepolymathe commented Jun 21, 2018

Okay, I actually didn't get that. In that case, I can reproduce the same behavior. It is the creation of a subtag common to several tags that only works on the first selected one.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 22, 2018

You can add tags in the Tags panel.

I'm reorganizing my 300 notes from sub-folder structure to YAML tags. I assign 2-4 tags to each note. So I have some massive tagging going on here.

If I'd use Tags panel to add tags I'd have to:

  1. Input new tag to search bar;
  2. Select notes and find this tag in a tag list, that has already 3 columns and growing.

With Note tags panel:

  1. Input new tag on Note tags panel.
  2. PROFIT

Even putting aside #947 - the absence of sorting in context menu, the second is at least twice faster. Assigning existing tags is faster too.

Note tags panel does work with multiple notes selected, but it does not do what user expects.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 22, 2018

Note tags panel does work with multiple notes selected

what do you mean by "it works"? it is visible if you select multiple notes? :)

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 22, 2018

It is visible and shows tags. I was sure it adds tags to all the notes selected.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 22, 2018

And which tags does it show?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 22, 2018

It show tags of the last selected note, it's also the note on preview/edit pane. When there are no tags assigned it shows nothing, so there are less clues.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 22, 2018

It show the tags of the current note. :) Would it be consistent if it would show the tags of the current note and tag all selected note? And what should happen if you click on one tag of the current note to remove it?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 22, 2018

Would it be consistent if it would show the tags of the current note and tag all selected note?

Not at all. In my dream world of happy UIs it would show something like the common tags of all selected notes and some ... icon, which pop-up would say N individual note tags. Maybe it would also show a number of selected notes with a small note icon on the left, just to be sure. New tag would be assigned to all the notes.

And what should happen if you click on one tag of the current note to remove it?

Since that dream UI of mine would show only common tags, removing would not be the issue. Not common tags would not be available for control and their existence would be hinted by ... icon.

That way Note tap panel would be as powerful as context menu, but much more ergonomic due to typing with auto-completion.

And I'm still loudly silent about drag-n-drop. Yes, I'm the fan.

Maybe I'm too original in my in insights, but posting them is what I do here. 😅

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 22, 2018

That's how a green monster does it. Not a guideline but still an example.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 23, 2018

common tags

sounds like a plan

That's how a green monster does it. Not a guideline but still an example.

I like that, but I guess that would be a completely different panel.

@pbek pbek added enhancement and removed question labels Jun 23, 2018

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 23, 2018

I like that, but I guess that would be a completely different panel.

Translating the example to QON UI the preview pane should show something "previewing" the notes selected. Maybe a grid of "cards" with the note name on each (sounds like a mode for a note list 😉). The editor pane could show N notes selected, to make it usable even without preview pane, and a buttons for a multi-note actions. There can be a scripting function to add custom actions there, as with toolbar.

The behaviour of the Note tag panel described above would fit nicely.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 23, 2018

Hm, not everyone has the preview panel enabled... It's not even enabled by default.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 23, 2018

True. That's why, as I've mentioned, editor pane has N notes selected text and all the buttons and preview pane is mostly the decoration to ensure the user he's now dealing with multiple notes.

If you're interested I could try making some UI mock ups.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 23, 2018

editor pane has N notes selected text

but not everyone even has the note edit pane active...

If you're interested I could try making some UI mock ups.

yes, please

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 23, 2018

but not everyone even has the note edit pane active...

I see QON UI structure like this:
Preview pane = to view content, not change it, safe for read-only mode;
Editor pane = to change content, unsafe for read-only mode.

So in multi-note mode:
Preview pane = grid of notes without interactive elements, tells user he selected multiple notes, but keeps him sure he can't alter them, he is a relaxed reader;
Editor pane = N notes selected to tell user he selected multiple notes, and buttons which alter notes, if user uses editor pane, he's ready to change something.

And both panes would fit nicely to vertical or horizontal layouts.

Also selecting 2 notes could make preview pane to divide and show both of them. Editor pane would simply go to multi-note mode.

I'll do some mock ups.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 23, 2018

Something like that. Can't come up with the best representation for the preview pane.

screenshot_20180623_223632

@pbek

This comment has been minimized.

Owner

pbek commented Jun 23, 2018

Thank you for your illustrations! I now see what you mean (and also see how much work this would be).

@pbek

This comment has been minimized.

Owner

pbek commented Jun 27, 2018

@Maboroshy, might it not better to show all tags that at least one selected note has (and don't show the +2 tags label)? Then those tags can be removed from the notes too.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 27, 2018

User should clearly see, without any explanation, which tags are common and which are not. It's not easy to archive showing all the tags.
I'm under impression that deleting non-common tags while working with multiple notes is a rare scenario. I may be wrong though.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 27, 2018

If I just want to delete all tags from a bunch of notes. There's no way to delete uncommon tags otherwise...

@pbek

This comment has been minimized.

Owner

pbek commented Jun 27, 2018

Plus I don't see any advantage in seeing the common tags only... Why would I want to know them?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 27, 2018

Deleting all the tags can be a single button. Uncommon tags can easily be more than 10 buttons. Anything more than 5-7 scares a user.
I can hardly see how working with individual uncommon tags can be done without implementing some modal structures to note tag panel. Maybe that's the target for #949. There's much more screen space to play with.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 27, 2018

Uncommon tags can easily be more than 10 buttons.

That's why I have a scroll area for the tags.
I still can't see the point to only show common tags and not being able to remove one un-common tag.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 27, 2018

I've started adding tags to a note to see how that can look like. After 8th button the panel starts to scare me. Clearly separating common and uncommon tags may up this number, but no more than twice.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 28, 2018

Clearly separating common and uncommon tags

separating in what way?

pbek added a commit that referenced this issue Jun 28, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 28, 2018

meanwhile I did that (it was more work than expected):

18.06.7

  • the Note tags panel now shows the tags of all selected notes and also
    will remove or add tags from/to all those notes
    • if notes are selected there will be a symbol in front of the tags to
      show you how many notes are selected

@pbek pbek added this to the 18.06.7 milestone Jun 28, 2018

pbek added a commit that referenced this issue Jun 28, 2018

pbek added a commit that referenced this issue Jun 28, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 28, 2018

There now is a new release, could you please test it and report if it works for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 28, 2018

It works. But the first time I select a single note after multiple notes selected note tag panel doesn't update.

separating in what way?

Maybe something like that, not very intuitive though:

screenshot_20180628_193955

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 28, 2018

Also the tag buttons don't go to the second and more lines, even if panel is large enough. With that many tags that would be handy.

@bepolymathe

This comment has been minimized.

bepolymathe commented Jun 28, 2018

It works. But the first time I select a single note after multiple notes selected note tag panel doesn't update.

Same result for me

@pbek

This comment has been minimized.

Owner

pbek commented Jun 28, 2018

It works. But the first time I select a single note after multiple notes selected note tag panel doesn't update.

I'll take a look at that

Maybe something like that, not very intuitive though:

Looks nice, but takes up even more space.

Also the tag buttons don't go to the second and more lines, even if panel is large enough. With that many tags that would be handy.

The layout-manager can't do that, at least I don't know a way...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 28, 2018

Looks nice, but takes up even more space.

You can skip note count for uncommon tags, that would make save space but will be even less intuitive.

The layout-manager can't do that, at least I don't know a way...

Check flow layout

@pbek

This comment has been minimized.

Owner

pbek commented Jun 28, 2018

You can skip note count for uncommon tags, that would make save space but will be even less intuitive.

the problem is it would still take too much space if you have the note tags panel in a space with restricted width. I currently hardly can see two tags and the add button...

Check flow layout

Thank you, it does look complex to implement. I wonder if you can combine it with a scroll area. And I wonder where to put the note indicator, the add button and the new tag line edit...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 28, 2018

the problem is it would still take too much space if you have the note tags panel in a space with restricted width. I currently hardly can see two tags and the add button...

My proposal differs from the implemented one only by a small spacing between common and uncommon sections and the position of "add tag".

Thank you, it does look complex to implement. I wonder if you can combine it with a scroll area. And I wonder where to put the note indicator, the add button and the new tag line edit...

Can't tell. Never implemented something like that. I can mock up something, but you won't know what you can do until you try.

I currently hardly can see two tags and the add button...

Flow layout can lead to ability to use vertical note tag panel.

@pbek

This comment has been minimized.

Owner

pbek commented Jun 29, 2018

My proposal differs from the implemented one only by a small spacing between common and uncommon sections and the position of "add tag".

currently the tags are in a scroll area, the add button (and the line edit are not), that wouldn't work any more with your latest mockup (that uses far more space)

Flow layout can lead to ability to use vertical note tag panel.

but there are two containers in your last mockup

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 29, 2018

It's all about layout management. But it's true that the amount of work can be an overkill and not worth it.

pbek added a commit that referenced this issue Jul 1, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jul 1, 2018

18.07.0

  • fixed updating the note tags panel after multiple notes were selected
@pbek

This comment has been minimized.

Owner

pbek commented Jul 1, 2018

There now is a new release, could you please test it and report if it works for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jul 1, 2018

Fixed.

@Maboroshy Maboroshy closed this Jul 1, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jul 1, 2018

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment