New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search or create note panel - cancel searching #948

Closed
wiktor2200 opened this Issue Jun 21, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@wiktor2200

wiktor2200 commented Jun 21, 2018

Expected behaviour

I've Search or create note panel enabled in main view. I'm using it when I want to search through all notes, but it would be nice if there will be any option to cancel searching and blank search text field. (for example, when esc pressed - or any other key/key combination). Is it possible to enable erase function both under ⌫ erase button and esc key?

Actual behaviour

When there is a need to blank search panel:

  • backspace key have to be pressed/hold
  • ⌫ erase button has to be clicked by mouse.

@pbek pbek added the enhancement label Jun 22, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 22, 2018

Thank you for your suggestion.

pbek added a commit that referenced this issue Jun 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 24, 2018

18.06.6

  • the search line edits in the note-, tag- and subfolder-lists can now be
    cleared with the Escape key (for #948)

@pbek pbek added this to the 18.06.6 milestone Jun 24, 2018

pbek added a commit that referenced this issue Jun 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 24, 2018

There now is a new release, could you please test it and report if it works for you?

@wiktor2200

This comment has been minimized.

wiktor2200 commented Jun 24, 2018

I've tested and it works great. Thanks for very fast response for my suggestion.

@wiktor2200 wiktor2200 closed this Jun 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Jun 24, 2018

It made a lot of sense, so thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment