New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a quote (") automatically enters a closing quote (") automatically but if I also enter a close quotation, I end up with 2 quotation close #982
Comments
I'm sorry, "Automatic closing" only works at the end of the line (otherwise there will be too many side-effects). So your 2nd |
May be it would be a good idea to skip the insertion of the closing By the way.... Marking a text and pressing |
@pbek : While typing something, as soon as I enter |
I'll take a look into it, thank you for your feedback. |
Hm, what is if someone wants to add a "missing" |
I'll ignore that rare case... It wasn't very easy to implement without causing any regressions, but it's done now: 18.08.1
|
There now is a new release, could you please test it and report if it works for you? |
It is working perfectly now. You did it in a day 🥇 |
It works. Thanks! By the way... I have had a look at the changes in |
I wrote
In what way? |
It does not insert nested sequences.
If you enter some text after the "special character", the behaviour differ too. IMO both way leads to "unpleasant result" or illegal Markdown. I don't know if nested level of brackets are usefull.
|
and rightfully so to create the bold formatting
see above you can never satisfy all "character magic" user-wishes without making other users with other use-cases angry and possibly create a lot of regressions in the process... |
No. The current way leads to incorrect Markdown. Press I must say, that I'm currently can't recognize all the side effects, but wouldn't it be a solution to handle a In the case of brackets, nesting makes sense. So why not insert a closing bracket with every "opening" press? |
I don't think QOwnNotes will ever be able to detect every possible way that can be entered... those automation process should just be "helpers"
|
Expected behaviour
If close quotation is entered by QOwnNotes, then if I enter the same myself, it should just replace the entered one with the on I have entered or simply place the cursor after the close quote. Now instead of closing the quote myself("some text"), I have to move the cursor to the right of the close quote with the arrow key which beats the purpose of having the quotation close entered automatically
Actual behaviour
Opening a quote (") automatically enters a closing quote (") automatically but if I also enter a close quotation, I end up with 2 close quotation and having to place the quotation to the right of the automatically entered quotation with the arrow key.
Steps to reproduce
pres "
Enter some text
press"
You now have 2 ".
Example:
"some text""
Output from the debug section in the settings dialog
Relevant log output in the Log panel
The text was updated successfully, but these errors were encountered: