Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Dark color scheme #1554

Merged
merged 2 commits into from Jan 7, 2020
Merged

Add Two Dark color scheme #1554

merged 2 commits into from Jan 7, 2020

Conversation

@ScottKillen
Copy link
Contributor

ScottKillen commented Jan 7, 2020

This is the two dark color scheme, based on the VS Code's One Dark theme.

2020-01-07 08_44_42-Welcome to QOwnNotes - QOwnNotes 20 1 3

This is the two dark color scheme, based on the VS Code's One Dark theme.
src/configurations/schemes.conf Outdated Show resolved Hide resolved
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2020

Coverage Status

Coverage remained the same at 12.512% when pulling e638c93 on ScottKillen:patch-1 into bf52c26 on pbek:develop.

Copy link
Contributor Author

ScottKillen left a comment

I have updated to a unique UUID

@pbek

This comment has been minimized.

Copy link
Owner

pbek commented Jan 7, 2020

Great. 😁 FallbackSchema is also missing, I'll add that.

@pbek pbek merged commit 394eeac into pbek:develop Jan 7, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 12.512%
Details
@pbek

This comment has been minimized.

Copy link
Owner

pbek commented Jan 7, 2020

I cannot see any difference to the Dark theme (even the new headline color variations are the same). Are you sure you added the right schema?

@pbek

This comment has been minimized.

Copy link
Owner

pbek commented Jan 7, 2020

I'll revert for the next release.

pbek added a commit that referenced this pull request Jan 7, 2020
This reverts commit 394eeac.
pbek added a commit that referenced this pull request Jan 7, 2020
This reverts commit 394eeac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.