New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOwnNotes can't get note versions #11

Closed
benqrn opened this Issue Mar 13, 2017 · 10 comments

Comments

Projects
None yet
2 participants
@benqrn

benqrn commented Mar 13, 2017

When running edit -> 'Show note versions', this appears in NC error log;

OCP\Files\NotFoundException: /test.md not found while trying to get owner

running QOwnNotes 17.03.4, NC 11.0.2 and QOwnNotesAPI 17.3.0. NextCloud account is configured in the QOwnNotes settings and connects successfully, files are being synchronized with the official NC client. QOwnNotes and the sync client are running on windows 7.

@pbek

This comment has been minimized.

Owner

pbek commented Mar 13, 2017

@benqrn

This comment has been minimized.

benqrn commented Mar 14, 2017

No, choosing a folder fixed it :) Thanks.

'Notes' is already populated in the 'path on your server' box (though it is grey), so I assumed it was trying that folder as a default. The UI should be changed to reflect that it does not try any folder by default, or at least display an error that no folder was selected.

@benqrn benqrn closed this Mar 14, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Mar 15, 2017

17.03.6

  • when configuring a new note folder path in the settings the server-path
    will now be suggested
    • the placeholder text was changed to be more informative
@pbek

This comment has been minimized.

Owner

pbek commented Mar 15, 2017

There now is a new release of QOwnNotes, could you please test it and report if it works for you?

@benqrn

This comment has been minimized.

benqrn commented Mar 15, 2017

The hint in the Note folder settings is much better, though if that field has to be set to view versions, there should be an error when clicking 'show note versions' instead of it saying 'There are no other versions on the server for this note.'

@pbek

This comment has been minimized.

Owner

pbek commented Mar 15, 2017

QOwnNotes doesn't really know that because it doesn't get that information.

@benqrn

This comment has been minimized.

benqrn commented Mar 15, 2017

The path has to be set to something for show note versions to work; so I'm saying if the path is unset in the folder settings, an error should be shown instead of a misleading info box.

@pbek

This comment has been minimized.

Owner

pbek commented Mar 15, 2017

"nothing" is the oC / NC root path

@benqrn

This comment has been minimized.

benqrn commented Mar 16, 2017

No one is going to store their notes in the user root folder. The info box doesn't even say the actual error which is 'file not found', just says 'no previous versions.' It's not telling the user what is actually happening.

@pbek

This comment has been minimized.

Owner

pbek commented Mar 16, 2017

17.03.7

  • improved error messages for the version and trash dialog

There now is a new release, could you please test it and report if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment