Fix TypeScript module resolution error in serialize.ts #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the import statement from 'from "types"' to 'from "./types"' to fix TypeScript compilation errors when using moduleResolution: "node". The absolute import "types" causes TS2307 error: "Cannot find module 'types' or its corresponding type declarations" in projects that consume this library. This change maintains backward compatibility while fixing the module resolution issue for TypeScript projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a TypeScript compilation error in
serialize-query-paramspackage that occurs when projects usemoduleResolution: "node".Problem
The file
packages/serialize-query-params/src/serialize.tsuses an absolute import:This causes the following TypeScript error in consuming projects:
Solution
Changed the import to use a relative path:
Testing
npm test- 83 tests passed)npm run build)Impact
serialize-query-params@2.0.3