Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the explain function in the dplyr package #16

Closed
pbiecek opened this issue Apr 24, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@pbiecek
Copy link
Owner

commented Apr 24, 2018

The explain() method exists also in the dplyr package as the generic function.
DALEX will behave differently depending on which package is loaded first (DALEX / dplyr)
not clear how to solve this

@mstaniak

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2018

write DALEX::explain in documentation and print a warning while loading package (similarly to how tidyverse packages print their conflicts)?

@pbiecek

This comment has been minimized.

Copy link
Owner Author

commented Apr 28, 2018

I do not worry about the documentation that much, since I control the order of loaded libraries.
More about the every day usage in which some people might be surprised that the explain function is not working, only because dplyr is loaded after DALEX. The explain.default() is a temporary fix.

@mstaniak

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2018

My point was that maybe people would get used to writing "DALEX::explain" after seeing it multiple times (:

@pbiecek pbiecek closed this May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.