Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prediction_breakdown() plot result may be confusing with default `baseline` choice #39

Closed
kevinykuo opened this issue Aug 11, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@kevinykuo
Copy link
Contributor

commented Aug 11, 2018

New to this so please let me know if I'm misinterpreting the functionality!

Currently, the baseline argument to broken() is hardcoded to be "Intercept" and there is no way to modify it. This parameter should be exposed, and the default may lead to confusion because one would expect "final_prognosis" to be equal to the prediction, at least for models with an identity link function. Also, the plot method doesn't tell you what the baseline is, so it's difficult to tell the story of how we got to the prediction (since we don't see the prediction on the plot.)

pbiecek added a commit that referenced this issue Aug 14, 2018

@pbiecek

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2018

Right.

Dirty fix: In the latest version d0f5961 you can now specify baseline directly (see last example in https://pbiecek.github.io/DALEX/reference/prediction_breakdown.html#examples).

Plans: prediction_breakdown() needs larger flexibility. It will work on this as soon as ceterisParibus will be finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.