Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 0.1.1 is going to CRAN #7

Closed
pbiecek opened this issue Feb 27, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@pbiecek
Copy link
Owner

commented Feb 27, 2018

Do we need to fix/add anything before this will be submitted?
Shapley values will get to DALEX in the next version
Support for mlr as well

@pbiecek pbiecek added the question label Feb 27, 2018

pbiecek added a commit that referenced this issue Feb 27, 2018

pbiecek added a commit that referenced this issue Feb 27, 2018

@agosiewska

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2018

If the package has not yet been sent to CRAN, it may be worth to unify the functions parameter names.
All parameters have _ in the name, except for predict.function from explain().

@pbiecek

This comment has been minimized.

Copy link
Owner Author

commented Mar 2, 2018

Good point, I will change this in 0.2
(got to cran yesterday https://cran.r-project.org/package=DALEX)

pbiecek added a commit that referenced this issue Mar 2, 2018

pbiecek added a commit that referenced this issue Mar 2, 2018

@pbiecek pbiecek closed this Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.