Skip to content

/ archivist

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain parameter in saveToRepo function #101

Closed
MarcinKosinski opened this issue Oct 26, 2015 · 2 comments
Closed

chain parameter in saveToRepo function #101

MarcinKosinski opened this issue Oct 26, 2015 · 2 comments
Assignees
@MarcinKosinski

Comments

@MarcinKosinski
Copy link
Collaborator

@MarcinKosinski MarcinKosinski commented Oct 26, 2015

Since we have %a% function in archivist package it looks like chain parameter is no longer needed in our package. Maybe we should change it's name to value, because it forces saveToRepo() to return archived artifact as a value of this function. We can add chain to the deprecated information. What do you think about that?
@MarcinKosinski MarcinKosinski mentioned this issue Oct 26, 2015
Closed
@pbiecek
Copy link
Owner

@pbiecek pbiecek commented Oct 26, 2015

Good idea
@MarcinKosinski MarcinKosinski added To do! and removed question labels Oct 26, 2015
@MarcinKosinski MarcinKosinski self-assigned this Dec 1, 2015
@MarcinKosinski MarcinKosinski removed the To do! label Jan 10, 2016
@MarcinKosinski
Copy link
Collaborator Author

@MarcinKosinski MarcinKosinski commented Jan 10, 2016

done with b6f1c77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcinKosinski MarcinKosinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@pbiecek @MarcinKosinski
You can’t perform that action at this time.