Skip to content

Paul Bouzakis
pbouzakis

Organizations

@YuzuJS
@pbouzakis

Too much indent.

@pbouzakis

Nested is weird. I'll come over with on this one.

@pbouzakis

Why are we not using map?

@pbouzakis

Extra space, place function on new line to line up the error handler. Also it's recommend to not nest promises, in fact they were designed to elimi…

pbouzakis commented on pull request YuzuJS/storeit#16
@pbouzakis

Looks good to me. I'd like to @donavon to take a look when he can.

@pbouzakis

:8ball: See comments. Is this going to be open source?

@pbouzakis

Might want to make 500 a constant.

@pbouzakis

Are missing a return here?

@pbouzakis

Space after curly.

@pbouzakis

Any reason for the anon. fn wrapper?

@pbouzakis

Any reason why you are wrapping this function in anonymous fns?

@pbouzakis

Any reason why we return undefined?

@pbouzakis

Why do we have a then.

@pbouzakis

Not standard indentation.

@pbouzakis

Why are we not using map here?

@pbouzakis

Spelling error

@pbouzakis

Why do we have a then here if we dont do anything?

@pbouzakis

Extra indent.

@pbouzakis

Extra indent?

@pbouzakis

The function should move to the next line to match up with the error handler.

pbouzakis commented on pull request YuzuJS/storeit#16
@pbouzakis

:8ball: See comments.

pbouzakis commented on commit YuzuJS/storeit@cefbf88ccc
@pbouzakis

These methods are way too long for my taste. Smaller methods will help with self documentation IMO. Up to you.

pbouzakis commented on commit YuzuJS/storeit@cefbf88ccc
@pbouzakis

Should this be done ? You are not returning the promise. Otherwise we will eat errors.

pbouzakis commented on commit YuzuJS/storeit@cefbf88ccc
@pbouzakis

We should comment here why this is happening.

pbouzakis commented on pull request YuzuJS/storeit#15
@pbouzakis

:statue_of_liberty: Looks good to me. @donavon You should probably give official thumbs up. It looks like according to travis the builds are failing?

pbouzakis commented on pull request YuzuJS/storeit#15
@pbouzakis

:8ball: See comments.

pbouzakis commented on commit YuzuJS/storeit@f7142abdbf
@pbouzakis

Why is .done commented out?

pbouzakis commented on commit YuzuJS/storeit@f7142abdbf
@pbouzakis

I have feeling this might have some consequences in other components, as we now publish async.

pbouzakis commented on commit YuzuJS/storeit@f7142abdbf
@pbouzakis

Why is there a comment here?

Something went wrong with that request. Please try again.