Skip to content

Commit 4eb87ce

Browse files
pboydpboyd
committed
Instrument backendA
1 parent f0c2c22 commit 4eb87ce

File tree

6 files changed

+197
-74
lines changed

6 files changed

+197
-74
lines changed

‎backendA/airport.go

Lines changed: 40 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,15 @@ var airportType = graphql.NewObject(
3333
)
3434

3535
func resolveAirportQuery(db *sql.DB) graphql.FieldResolveFn {
36-
return func(p graphql.ResolveParams) (interface{}, error) {
37-
code, _ := p.Args["code"].(string)
38-
code = strings.ToUpper(code)
39-
if !isAirportCode(code) {
40-
return nil, nil
41-
}
36+
return graphQLMetrics("airport",
37+
func(p graphql.ResolveParams) (interface{}, error) {
38+
code, _ := p.Args["code"].(string)
39+
code = strings.ToUpper(code)
40+
if !isAirportCode(code) {
41+
return nil, nil
42+
}
4243

43-
row := db.QueryRow(`
44+
row := db.QueryRow(`
4445
SELECT
4546
code, name, city, state, lat, lng
4647
FROM
@@ -50,17 +51,18 @@ func resolveAirportQuery(db *sql.DB) graphql.FieldResolveFn {
5051
code=?
5152
`, code)
5253

53-
var a airport
54-
err := row.Scan(&a.Code, &a.Name, &a.City, &a.State, &a.Latitude, &a.Longitude)
55-
if err != nil {
56-
if err == sql.ErrNoRows {
57-
return nil, nil
54+
var a airport
55+
err := row.Scan(&a.Code, &a.Name, &a.City, &a.State, &a.Latitude, &a.Longitude)
56+
if err != nil {
57+
if err == sql.ErrNoRows {
58+
return nil, nil
59+
}
60+
return nil, err
5861
}
59-
return nil, err
60-
}
6162

62-
return &a, nil
63-
}
63+
return &a, nil
64+
},
65+
)
6466
}
6567

6668
func isAirportCode(code string) bool {
@@ -78,15 +80,16 @@ func isAirportCode(code string) bool {
7880
}
7981

8082
func resolveAirportList(db *sql.DB) graphql.FieldResolveFn {
81-
return func(p graphql.ResolveParams) (interface{}, error) {
82-
term, _ := p.Args["term"].(string)
83-
if !checkAirportSearchTerm(term) {
84-
return nil, nil
85-
}
83+
return graphQLMetrics("airport_list",
84+
func(p graphql.ResolveParams) (interface{}, error) {
85+
term, _ := p.Args["term"].(string)
86+
if !checkAirportSearchTerm(term) {
87+
return nil, nil
88+
}
8689

87-
termLike := fmt.Sprintf("%%%s%%", term)
90+
termLike := fmt.Sprintf("%%%s%%", term)
8891

89-
rows, err := db.Query(`
92+
rows, err := db.Query(`
9093
SELECT
9194
code, name, city, state, lat, lng
9295
FROM
@@ -98,24 +101,25 @@ func resolveAirportList(db *sql.DB) graphql.FieldResolveFn {
98101
code LIKE ?
99102
)
100103
`, termLike, termLike, termLike)
101-
if err != nil {
102-
return nil, err
103-
}
104-
defer rows.Close()
105-
106-
results := []*airport{}
107-
for rows.Next() {
108-
var a airport
109-
err := rows.Scan(&a.Code, &a.Name, &a.City, &a.State, &a.Latitude, &a.Longitude)
110104
if err != nil {
111105
return nil, err
112106
}
107+
defer rows.Close()
113108

114-
results = append(results, &a)
115-
}
109+
results := []*airport{}
110+
for rows.Next() {
111+
var a airport
112+
err := rows.Scan(&a.Code, &a.Name, &a.City, &a.State, &a.Latitude, &a.Longitude)
113+
if err != nil {
114+
return nil, err
115+
}
116116

117-
return results, nil
118-
}
117+
results = append(results, &a)
118+
}
119+
120+
return results, nil
121+
},
122+
)
119123
}
120124

121125
func checkAirportSearchTerm(term string) bool {

‎backendA/go.mod

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ module github.com/pboyd/flightranker-backend/backendA
33
require (
44
github.com/go-sql-driver/mysql v1.4.1
55
github.com/graphql-go/graphql v0.7.8
6+
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
7+
github.com/modern-go/reflect2 v1.0.1 // indirect
68
github.com/pboyd/flightranker-backend/backendtest v0.0.0
9+
github.com/prometheus/client_golang v1.1.0
710
google.golang.org/appengine v1.6.1 // indirect
811
)
912

‎backendA/go.sum

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,85 @@
1+
github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
2+
github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
3+
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=
4+
github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
5+
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
6+
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
7+
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
8+
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
9+
github.com/go-kit/kit v0.8.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as=
10+
github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9GBnD5lWE=
11+
github.com/go-logfmt/logfmt v0.4.0/go.mod h1:3RMwSq7FuexP4Kalkev3ejPJsZTpXXBr9+V4qmtdjCk=
112
github.com/go-sql-driver/mysql v1.4.1 h1:g24URVg0OFbNUTx9qqY1IRZ9D9z3iPyi5zKhQZpNwpA=
213
github.com/go-sql-driver/mysql v1.4.1/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
14+
github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
15+
github.com/gogo/protobuf v1.1.1/go.mod h1:r8qH/GZQm5c6nD/R0oafs1akxWv10x8SbQlK7atdtwQ=
16+
github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
317
github.com/golang/protobuf v1.3.1 h1:YF8+flBXS5eO826T4nzqPrxfhQThhXl0YzfuUPu4SBg=
418
github.com/golang/protobuf v1.3.1/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
19+
github.com/golang/protobuf v1.3.2 h1:6nsPYzhq5kReh6QImI3k5qWzO4PEbvbIW2cwSfR/6xs=
20+
github.com/golang/protobuf v1.3.2/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
21+
github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
22+
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
523
github.com/graphql-go/graphql v0.7.8 h1:769CR/2JNAhLG9+aa8pfLkKdR0H+r5lsQqling5WwpU=
624
github.com/graphql-go/graphql v0.7.8/go.mod h1:k6yrAYQaSP59DC5UVxbgxESlmVyojThKdORUqGDGmrI=
25+
github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCVDaaPEHmU=
26+
github.com/json-iterator/go v1.1.7/go.mod h1:KdQUCv79m/52Kvf8AW2vK1V8akMuk1QjK/uOdHXbAo4=
27+
github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7VTCxuUUipMqKk8s4w=
28+
github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
29+
github.com/kr/logfmt v0.0.0-20140226030751-b84e30acd515/go.mod h1:+0opPa2QZZtGFBFZlji/RkVcI2GknAs/DXo4wKdlNEc=
30+
github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
31+
github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
32+
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
33+
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
34+
github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0=
35+
github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0=
36+
github.com/mwitkow/go-conntrack v0.0.0-20161129095857-cc309e4a2223/go.mod h1:qRWi+5nqEBWmkhHvq77mSJWrCKwh8bxhgT7d/eI7P4U=
37+
github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
738
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
839
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
40+
github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=
41+
github.com/prometheus/client_golang v1.0.0/go.mod h1:db9x61etRT2tGnBNRi70OPL5FsnadC4Ky3P0J6CfImo=
42+
github.com/prometheus/client_golang v1.1.0 h1:BQ53HtBmfOitExawJ6LokA4x8ov/z0SYYb0+HxJfRI8=
43+
github.com/prometheus/client_golang v1.1.0/go.mod h1:I1FGZT9+L76gKKOs5djB6ezCbFQP1xR9D75/vuwEF3g=
44+
github.com/prometheus/client_model v0.0.0-20180712105110-5c3871d89910/go.mod h1:MbSGuTsp3dbXC40dX6PRTWyKYBIrTGTE9sqQNg2J8bo=
45+
github.com/prometheus/client_model v0.0.0-20190129233127-fd36f4220a90 h1:S/YWwWx/RA8rT8tKFRuGUZhuA90OyIBpPCXkcbwU8DE=
46+
github.com/prometheus/client_model v0.0.0-20190129233127-fd36f4220a90/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
47+
github.com/prometheus/common v0.4.1/go.mod h1:TNfzLD0ON7rHzMJeJkieUDPYmFC7Snx/y86RQel1bk4=
48+
github.com/prometheus/common v0.6.0 h1:kRhiuYSXR3+uv2IbVbZhUxK5zVD/2pp3Gd2PpvPkpEo=
49+
github.com/prometheus/common v0.6.0/go.mod h1:eBmuwkDJBwy6iBfxCBob6t6dR6ENT/y+J+Zk0j9GMYc=
50+
github.com/prometheus/procfs v0.0.0-20181005140218-185b4288413d/go.mod h1:c3At6R/oaqEKCNdg8wHV1ftS6bRYblBhIjjI8uT2IGk=
51+
github.com/prometheus/procfs v0.0.2/go.mod h1:TjEm7ze935MbeOT/UhFTIMYKhuLP4wbCsTZCD3I8kEA=
52+
github.com/prometheus/procfs v0.0.3 h1:CTwfnzjQ+8dS6MhHHu4YswVAD99sL2wjPqP+VkURmKE=
53+
github.com/prometheus/procfs v0.0.3/go.mod h1:4A/X28fw3Fc593LaREMrKMqOKvUAntwMDaekg4FpcdQ=
54+
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
55+
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
56+
github.com/stretchr/objx v0.1.1/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
57+
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
58+
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
59+
golang.org/x/crypto v0.0.0-20180904163835-0709b304e793/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
960
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
1061
golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
62+
golang.org/x/net v0.0.0-20181114220301-adae6a3d119a/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
1163
golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
1264
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
1365
golang.org/x/net v0.0.0-20190603091049-60506f45cf65 h1:+rhAzEzT3f4JtomfC371qB+0Ola2caSKcY69NUBZrRQ=
1466
golang.org/x/net v0.0.0-20190603091049-60506f45cf65/go.mod h1:HSz+uSET+XFnRR8LxR5pz3Of3rY3CfYBVs4xY44aLks=
67+
golang.org/x/net v0.0.0-20190613194153-d28f0bde5980/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
68+
golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
69+
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
1570
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
71+
golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
72+
golang.org/x/sys v0.0.0-20181116152217-5ac8a444bdc5/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
1673
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
1774
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1875
golang.org/x/sys v0.0.0-20190606165138-5da285871e9c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
76+
golang.org/x/sys v0.0.0-20190801041406-cbf593c0f2f3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1977
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
2078
golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
2179
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
2280
golang.org/x/tools v0.0.0-20190606124116-d0a3d012864b/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc=
2381
google.golang.org/appengine v1.6.1 h1:QzqyMA1tlu6CgqCDUtU9V+ZKhLFT2dkJuANu5QaxI3I=
2482
google.golang.org/appengine v1.6.1/go.mod h1:i06prIuMbXzDqacNJfV5OdTW448YApPu5ww/cMBSeb0=
83+
gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw=
84+
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
85+
gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=

‎backendA/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99

1010
"github.com/go-sql-driver/mysql"
1111
"github.com/graphql-go/graphql"
12+
"github.com/prometheus/client_golang/prometheus/promhttp"
1213
)
1314

1415
func main() {
@@ -18,6 +19,7 @@ func main() {
1819
}
1920

2021
http.Handle("/", graphqlHandler(db))
22+
http.Handle("/metrics", promhttp.Handler())
2123

2224
log.Fatal(http.ListenAndServe(":8080", nil))
2325
}

‎backendA/metrics.go

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
package main
2+
3+
import (
4+
"github.com/graphql-go/graphql"
5+
"github.com/prometheus/client_golang/prometheus"
6+
)
7+
8+
func graphQLMetrics(name string, fn graphql.FieldResolveFn) graphql.FieldResolveFn {
9+
requests := prometheus.NewCounter(prometheus.CounterOpts{
10+
Namespace: "graphql",
11+
Subsystem: name,
12+
Name: "requests",
13+
})
14+
prometheus.MustRegister(requests)
15+
16+
errors := prometheus.NewCounter(prometheus.CounterOpts{
17+
Namespace: "graphql",
18+
Subsystem: name,
19+
Name: "errors",
20+
})
21+
prometheus.MustRegister(errors)
22+
23+
inflight := prometheus.NewGauge(prometheus.GaugeOpts{
24+
Namespace: "graphql",
25+
Subsystem: name,
26+
Name: "inflight",
27+
})
28+
prometheus.MustRegister(inflight)
29+
30+
responseTime := prometheus.NewHistogram(prometheus.HistogramOpts{
31+
Namespace: "graphql",
32+
Subsystem: name,
33+
Name: "response_time",
34+
})
35+
prometheus.MustRegister(responseTime)
36+
37+
return func(p graphql.ResolveParams) (r interface{}, err error) {
38+
timer := prometheus.NewTimer(responseTime)
39+
requests.Inc()
40+
inflight.Inc()
41+
defer func() {
42+
timer.ObserveDuration()
43+
inflight.Dec()
44+
45+
if err != nil {
46+
errors.Inc()
47+
}
48+
}()
49+
return fn(p)
50+
}
51+
}

‎backendA/stats.go

Lines changed: 40 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -30,44 +30,46 @@ var airlineStatsType = graphql.NewObject(
3030
)
3131

3232
func resolveFlightStatsByAirline(db *sql.DB) graphql.FieldResolveFn {
33-
return func(p graphql.ResolveParams) (interface{}, error) {
34-
origin, _ := p.Args["origin"].(string)
35-
origin = strings.ToUpper(origin)
36-
37-
dest, _ := p.Args["destination"].(string)
38-
dest = strings.ToUpper(dest)
39-
40-
if !isAirportCode(origin) || !isAirportCode(dest) {
41-
return nil, nil
42-
}
43-
44-
stats, err := airlineFlightInfo(p.Context, db, origin, dest)
45-
if err != nil {
46-
return nil, err
47-
}
48-
49-
delays, err := delaysByAirline(p.Context, db, origin, dest)
50-
if err != nil {
51-
return nil, err
52-
}
53-
54-
for code := range stats {
55-
stats[code].OnTimePercentage = (1.0 - float64(delays[code])/float64(stats[code].TotalFlights)) * 100
56-
}
57-
58-
statsRows := make([]*airlineStats, len(stats))
59-
i := 0
60-
for code := range stats {
61-
statsRows[i] = stats[code]
62-
i++
63-
}
64-
65-
sort.Slice(statsRows, func(i, j int) bool {
66-
return statsRows[j].OnTimePercentage < statsRows[i].OnTimePercentage
67-
})
68-
69-
return statsRows, nil
70-
}
33+
return graphQLMetrics("flightstats_by_airline",
34+
func(p graphql.ResolveParams) (interface{}, error) {
35+
origin, _ := p.Args["origin"].(string)
36+
origin = strings.ToUpper(origin)
37+
38+
dest, _ := p.Args["destination"].(string)
39+
dest = strings.ToUpper(dest)
40+
41+
if !isAirportCode(origin) || !isAirportCode(dest) {
42+
return nil, nil
43+
}
44+
45+
stats, err := airlineFlightInfo(p.Context, db, origin, dest)
46+
if err != nil {
47+
return nil, err
48+
}
49+
50+
delays, err := delaysByAirline(p.Context, db, origin, dest)
51+
if err != nil {
52+
return nil, err
53+
}
54+
55+
for code := range stats {
56+
stats[code].OnTimePercentage = (1.0 - float64(delays[code])/float64(stats[code].TotalFlights)) * 100
57+
}
58+
59+
statsRows := make([]*airlineStats, len(stats))
60+
i := 0
61+
for code := range stats {
62+
statsRows[i] = stats[code]
63+
i++
64+
}
65+
66+
sort.Slice(statsRows, func(i, j int) bool {
67+
return statsRows[j].OnTimePercentage < statsRows[i].OnTimePercentage
68+
})
69+
70+
return statsRows, nil
71+
},
72+
)
7173
}
7274

7375
func airlineFlightInfo(ctx context.Context, db *sql.DB, origin, dest string) (map[string]*airlineStats, error) {

0 commit comments

Comments
 (0)