Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make verb-nurbs work as a node module #22

Merged
merged 3 commits into from Feb 1, 2016
Merged

Make verb-nurbs work as a node module #22

merged 3 commits into from Feb 1, 2016

Conversation

kokarn
Copy link
Contributor

@kokarn kokarn commented Jan 29, 2016

Hello!

Great library you have here. I'm using it in a project as a node module and it works great.

The only two minor things I found that was off was that webworker-threads didn't get installed and that the main property is missing from package.json.

My suggestions are in this pull request. If you don't think that's the way to go then adding documentation that using it as a node module is possible by using

var verb = require( './node_modules/verb-nurbs/build/js/verb.js' );

would be the second best thing.

Thanks!

@pboyer
Copy link
Owner

pboyer commented Feb 1, 2016

Hey @kokarn!

Thanks! This is great!

pboyer added a commit that referenced this pull request Feb 1, 2016
Make verb-nurbs work as a node module
@pboyer pboyer merged commit a43a89c into pboyer:master Feb 1, 2016
@kokarn
Copy link
Contributor Author

kokarn commented Feb 2, 2016

Thanks!
Would you like me to add a bit of documentation about using it as a node module as well?

@pboyer
Copy link
Owner

pboyer commented Feb 3, 2016

Yeah! That would be awesome!

On Tue, Feb 2, 2016, 2:42 AM Oskar Risberg notifications@github.com wrote:

Thanks!
Would you like me to add a bit of documentation about using it as a node
module as well?


Reply to this email directly or view it on GitHub
#22 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants