Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial sample size returns 1 #34

Closed
pbstark opened this issue May 30, 2022 · 1 comment
Closed

initial sample size returns 1 #34

pbstark opened this issue May 30, 2022 · 1 comment

Comments

@pbstark
Copy link
Owner

pbstark commented May 30, 2022

Somehow the calculation of the initial sample size broke when ballot polling was introduced. Presumably, calculating the incremental sample size is also wrong. And the sample size calculations should terminate if the size reaches the appropriate population size (max_cards or contest['cards']).

@pbstark
Copy link
Owner Author

pbstark commented May 30, 2022

Resolved. issue was using np.argmax(p_history <= alpha) when the risk limit was not attained, which erroneously produced a sample size of 1 instead of N. Now test whether risk limit is attained.

@pbstark pbstark closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant