New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this the same as acdlite/redux-promise? #27

Closed
Kronuz opened this Issue Nov 19, 2015 · 4 comments

Comments

4 participants
@Kronuz
Copy link

Kronuz commented Nov 19, 2015

What is the difference between the two projects? it should be explained somewhere in the documentation, it's confusing... are both the same?

@marcelbuesing

This comment has been minimized.

Copy link

marcelbuesing commented Nov 25, 2015

From what I can tell so far the major difference is, that
acdlite/redux-promise does not fire a "pending". You must manually handle that. E.g. when retrieving data you are only "notified" once the action is successful or fails.
Besides that mostly naming differences.

Good point though, it probably makes sense to document it. I actually switched from acdlite/redux-promise due to the missing pending.

@Kronuz

This comment has been minimized.

Copy link

Kronuz commented Nov 25, 2015

I understand. Maybe the README should mention this in a sentence. For some time I thought I needed redux-promise to use redux-promise-middleware

@pburtchaell

This comment has been minimized.

Copy link
Owner

pburtchaell commented Nov 25, 2015

I have never used acdlite/redux-promise, but, yes, I would say the major difference is that this middleware dispatches a PENDING action. This PENDING action allows for optimistic updates, which is something acdlite/redux-promise has not yet implemented. I would also argue the API for this middleware is more transparent and easier to integrate, e.g., you do not need to use redux-actions.

I'll update the README with the differences. Thanks for bringing this up.

@icflorescu

This comment has been minimized.

Copy link

icflorescu commented Mar 17, 2017

A year later, another difference became apparent, and for the benefit of community, someone should mention it. This project is actively maintained, while acdlite/redux-promise is not, judging by the number and age of unaddressed issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment