Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge from project branch via main. Uninteresting commits are trimmed.

Refactor of /dev/random device. Main points include:

* Userland seeding is no longer used. This auto-seeds at boot time
on PC/Desktop setups; this may need some tweeking and intelligence
from those folks setting up embedded boxes, but the work is believed
to be minimal.

* An entropy cache is written to /entropy (even during installation)
and the kernel uses this at next boot.

* An entropy file written to /boot/entropy can be loaded by loader(8)

* Hardware sources such as rdrand are fed into Yarrow, and are no
longer available raw.

------------------------------------------------------------------------
r256240 | des | 2013-10-09 21:14:16 +0100 (Wed, 09 Oct 2013) | 4 lines

Add a RANDOM_RWFILE option and hide the entropy cache code behind it.
Rename YARROW_RNG and FORTUNA_RNG to RANDOM_YARROW and RANDOM_FORTUNA.
Add the RANDOM_* options to LINT.

------------------------------------------------------------------------
r256239 | des | 2013-10-09 21:12:59 +0100 (Wed, 09 Oct 2013) | 2 lines

Define RANDOM_PURE_RNDTEST for rndtest(4).

------------------------------------------------------------------------
r256204 | des | 2013-10-09 18:51:38 +0100 (Wed, 09 Oct 2013) | 2 lines

staticize struct random_hardware_source

------------------------------------------------------------------------
r256203 | markm | 2013-10-09 18:50:36 +0100 (Wed, 09 Oct 2013) | 2 lines

Wrap some policy-rich code in 'if NOTYET' until we can thresh out
what it really needs to do.

------------------------------------------------------------------------
r256184 | des | 2013-10-09 10:13:12 +0100 (Wed, 09 Oct 2013) | 2 lines

Re-add /dev/urandom for compatibility purposes.

------------------------------------------------------------------------
r256182 | des | 2013-10-09 10:11:14 +0100 (Wed, 09 Oct 2013) | 3 lines

Add missing include guards and move the existing ones out of the
implementation namespace.

------------------------------------------------------------------------
r256168 | markm | 2013-10-08 23:14:07 +0100 (Tue, 08 Oct 2013) | 10 lines

Fix some just-noticed problems:

o Allow this to work with "nodevice random" by fixing where the
MALLOC pool is defined.

o Fix the explicit reseed code. This was correct as submitted, but
in the project branch doesn't need to set the "seeded" bit as this
is done correctly in the "unblock" function.

o Remove some debug ifdeffing.

o Adjust comments.

------------------------------------------------------------------------
r256159 | markm | 2013-10-08 19:48:11 +0100 (Tue, 08 Oct 2013) | 6 lines

Time to eat crow for me.

I replaced the sx_* locks that Arthur used with regular mutexes;
this turned out the be the wrong thing to do as the locks need to
be sleepable. Revert this folly.

# Submitted by:	Arthur Mesh <arthurmesh@gmail.com> (In original diff)

------------------------------------------------------------------------
r256138 | des | 2013-10-08 12:05:26 +0100 (Tue, 08 Oct 2013) | 10 lines

Add YARROW_RNG and FORTUNA_RNG to sys/conf/options.

Add a SYSINIT that forces a reseed during proc0 setup, which happens
fairly late in the boot process.

Add a RANDOM_DEBUG option which enables some debugging printf()s.

Add a new RANDOM_ATTACH entropy source which harvests entropy from the
get_cyclecount() delta across each call to a device attach method.

------------------------------------------------------------------------
r256135 | markm | 2013-10-08 07:54:52 +0100 (Tue, 08 Oct 2013) | 8 lines

Debugging. My attempt at EVENTHANDLER(multiuser) was a failure; use
EVENTHANDLER(mountroot) instead.

This means we can't count on /var being present, so something will
need to be done about harvesting /var/db/entropy/... .

Some policy now needs to be sorted out, and a pre-sync cache needs
to be written, but apart from that we are now ready to go.

Over to review.

------------------------------------------------------------------------
r256094 | markm | 2013-10-06 23:45:02 +0100 (Sun, 06 Oct 2013) | 8 lines

Snapshot.

Looking pretty good; this mostly works now. New code includes:

* Read cached entropy at startup, both from files and from loader(8)
preloaded entropy. Failures are soft, but announced. Untested.

* Use EVENTHANDLER to do above just before we go multiuser. Untested.

------------------------------------------------------------------------
r256088 | markm | 2013-10-06 14:01:42 +0100 (Sun, 06 Oct 2013) | 2 lines

Fix up the man page for random(4). This mainly removes no-longer-relevant
details about HW RNGs, reseeding explicitly and user-supplied
entropy.

------------------------------------------------------------------------
r256087 | markm | 2013-10-06 13:43:42 +0100 (Sun, 06 Oct 2013) | 6 lines

As userland writing to /dev/random is no more, remove the "better
than nothing" bootstrap mode.

Add SWI harvesting to the mix.

My box seeds Yarrow by itself in a few seconds! YMMV; more to follow.

------------------------------------------------------------------------
r256086 | markm | 2013-10-06 13:40:32 +0100 (Sun, 06 Oct 2013) | 11 lines

Debug run. This now works, except that the "live" sources haven't
been tested. With all sources turned on, this unlocks itself in
a couple of seconds! That is no my box, and there is no guarantee
that this will be the case everywhere.

* Cut debug prints.

* Use the same locks/mutexes all the way through.

* Be a tad more conservative about entropy estimates.

------------------------------------------------------------------------
r256084 | markm | 2013-10-06 13:35:29 +0100 (Sun, 06 Oct 2013) | 5 lines

Don't use the "real" assembler mnemonics; older compilers may not
understand them (like when building CURRENT on 9.x).

# Submitted by:	Konstantin Belousov <kostikbel@gmail.com>

------------------------------------------------------------------------
r256081 | markm | 2013-10-06 10:55:28 +0100 (Sun, 06 Oct 2013) | 12 lines

SNAPSHOT.

Simplify the malloc pools; We only need one for this device.

Simplify the harvest queue.

Marginally improve the entropy pool hashing, making it a bit faster
in the process.

Connect up the hardware "live" source harvesting. This is simplistic
for now, and will need to be made rate-adaptive.

All of the above passes a compile test but needs to be debugged.

------------------------------------------------------------------------
r256042 | markm | 2013-10-04 07:55:06 +0100 (Fri, 04 Oct 2013) | 25 lines

Snapshot. This passes the build test, but has not yet been finished or debugged.

Contains:

* Refactor the hardware RNG CPU instruction sources to feed into
the software mixer. This is unfinished. The actual harvesting needs
to be sorted out. Modified by me (see below).

* Remove 'frac' parameter from random_harvest(). This was never
used and adds extra code for no good reason.

* Remove device write entropy harvesting. This provided a weak
attack vector, was not very good at bootstrapping the device. To
follow will be a replacement explicit reseed knob.

* Separate out all the RANDOM_PURE sources into separate harvest
entities. This adds some secuity in the case where more than one
is present.

* Review all the code and fix anything obviously messy or inconsistent.
Address som review concerns while I'm here, like rename the pseudo-rng
to 'dummy'.

# Submitted by:	Arthur Mesh <arthurmesh@gmail.com> (the first item)

------------------------------------------------------------------------
r255319 | markm | 2013-09-06 18:51:52 +0100 (Fri, 06 Sep 2013) | 4 lines

Yarrow wants entropy estimations to be conservative; the usual idea
is that if you are certain you have N bits of entropy, you declare
N/2.

------------------------------------------------------------------------
r255075 | markm | 2013-08-30 18:47:53 +0100 (Fri, 30 Aug 2013) | 4 lines

Remove short-lived idea; thread to harvest (eg) RDRAND enropy into the
usual harvest queues. It was a nifty idea, but too heavyweight.

# Submitted by:	Arthur Mesh <arthurmesh@gmail.com>

------------------------------------------------------------------------
r255071 | markm | 2013-08-30 12:42:57 +0100 (Fri, 30 Aug 2013) | 4 lines

Separate out the Software RNG entropy harvesting queue and thread
into its own files.

# Submitted by:	 Arthur Mesh <arthurmesh@gmail.com>

------------------------------------------------------------------------
r254934 | markm | 2013-08-26 20:07:03 +0100 (Mon, 26 Aug 2013) | 2 lines

Remove the short-lived namei experiment.

------------------------------------------------------------------------
r254928 | markm | 2013-08-26 19:35:21 +0100 (Mon, 26 Aug 2013) | 2 lines

Snapshot; Do some running repairs on entropy harvesting. More needs
to follow.

------------------------------------------------------------------------
r254927 | markm | 2013-08-26 19:29:51 +0100 (Mon, 26 Aug 2013) | 15 lines

Snapshot of current work;

1) Clean up namespace; only use "Yarrow" where it is Yarrow-specific
or close enough to the Yarrow algorithm. For the rest use a neutral
name.

2) Tidy up headers; put private stuff in private places. More could
be done here.

3) Streamline the hashing/encryption; no need for a 256-bit counter;
128 bits will last for long enough.

There are bits of debug code lying around; these will be removed
at a later stage.

------------------------------------------------------------------------
r254784 | markm | 2013-08-24 14:54:56 +0100 (Sat, 24 Aug 2013) | 39 lines

1) example (partially humorous random_adaptor, that I call "EXAMPLE")
 * It's not meant to be used in a real system, it's there to show how
   the basics of how to create interfaces for random_adaptors. Perhaps
   it should belong in a manual page

2) Move probe.c's functionality in to random_adaptors.c
 * rename random_ident_hardware() to random_adaptor_choose()

3) Introduce a new way to choose (or select) random_adaptors via tunable
"rngs_want" It's a list of comma separated names of adaptors, ordered
by preferences. I.e.:
rngs_want="yarrow,rdrand"

Such setting would cause yarrow to be preferred to rdrand. If neither of
them are available (or registered), then system will default to
something reasonable (currently yarrow). If yarrow is not present, then
we fall back to the adaptor that's first on the list of registered
adaptors.

4) Introduce a way where RNGs can play a role of entropy source. This is
mostly useful for HW rngs.

The way I envision this is that every HW RNG will use this
functionality by default. Functionality to disable this is also present.
I have an example of how to use this in random_adaptor_example.c (see
modload event, and init function)

5) fix kern.random.adaptors from
kern.random.adaptors: yarrowpanicblock
to
kern.random.adaptors: yarrow,panic,block

6) add kern.random.active_adaptor to indicate currently selected
adaptor:
root@freebsd04:~ # sysctl kern.random.active_adaptor
kern.random.active_adaptor: yarrow

# Submitted by:	Arthur Mesh <arthurmesh@gmail.com>

Submitted by:	Dag-Erling Smørgrav <des@FreeBSD.org>, Arthur Mesh <arthurmesh@gmail.com>
Reviewed by:	des@FreeBSD.org
Approved by:	re (delphij)
Approved by:	secteam (des,delphij)
  • Loading branch information...
commit 70d85b1cf39bf4f4d66a66b27b197046221e67f9 1 parent 4971018
markm authored
Showing with 1,025 additions and 648 deletions.
  1. +1 −0  etc/defaults/rc.conf
  2. +6 −34 etc/rc.d/initrandom
  3. +24 −17 share/examples/kld/random_adaptor/random_adaptor_example.c
  4. +55 −66 share/man/man4/random.4
  5. +11 −0 sys/boot/forth/loader.conf
  6. +5 −0 sys/conf/NOTES
  7. +5 −3 sys/conf/files
  8. +2 −2 sys/conf/files.amd64
  9. +2 −2 sys/conf/files.i386
  10. +6 −0 sys/conf/options
  11. +1 −1  sys/dev/glxsb/glxsb.c
  12. +1 −1  sys/dev/hifn/hifn7751.c
  13. +44 −46 sys/dev/random/{pseudo_rng.c → dummy_rng.c}
  14. +5 −7 sys/dev/random/harvest.c
  15. +5 −0 sys/dev/random/hash.h
  16. +43 −44 sys/dev/random/ivy.c
  17. +195 −0 sys/dev/random/live_entropy_sources.c
  18. +60 −0 sys/dev/random/live_entropy_sources.h
  19. +57 −134 sys/dev/random/nehemiah.c
  20. +35 −71 sys/dev/random/random_adaptors.c
  21. +5 −3 sys/dev/random/random_adaptors.h
  22. +138 −67 sys/dev/random/random_harvestq.c
  23. +5 −4 sys/dev/random/random_harvestq.h
  24. +30 −46 sys/dev/random/randomdev.c
  25. +11 −5 sys/dev/random/randomdev.h
  26. +39 −49 sys/dev/random/randomdev_soft.c
  27. +10 −9 sys/dev/random/randomdev_soft.h
  28. +96 −0 sys/dev/random/rwfile.c
  29. +39 −0 sys/dev/random/rwfile.h
  30. +44 −16 sys/dev/random/yarrow.c
  31. +5 −0 sys/dev/random/yarrow.h
  32. +1 −1  sys/dev/rndtest/rndtest.c
  33. +1 −1  sys/dev/safe/safe.c
  34. +1 −1  sys/dev/syscons/scmouse.c
  35. +1 −1  sys/dev/syscons/syscons.c
  36. +1 −1  sys/dev/ubsec/ubsec.c
  37. +3 −3 sys/kern/kern_intr.c
  38. +16 −0 sys/kern/subr_bus.c
  39. +1 −6 sys/mips/cavium/octeon_rnd.c
  40. +1 −1  sys/modules/random/Makefile
  41. +1 −1  sys/net/if_ethersubr.c
  42. +1 −1  sys/net/if_tun.c
  43. +1 −1  sys/netgraph/ng_iface.c
  44. +11 −3 sys/sys/random.h
View
1  etc/defaults/rc.conf
@@ -651,6 +651,7 @@ entropy_save_num="8" # Number of entropy cache files to save.
harvest_interrupt="YES" # Entropy device harvests interrupt randomness
harvest_ethernet="YES" # Entropy device harvests ethernet randomness
harvest_p_to_p="YES" # Entropy device harvests point-to-point randomness
+harvest_swi="YES" # Entropy device harvests internal SWI randomness
dmesg_enable="YES" # Save dmesg(8) to /var/run/dmesg.boot
watchdogd_enable="NO" # Start the software watchdog daemon
watchdogd_flags="" # Flags to watchdogd (if enabled)
View
40 etc/rc.d/initrandom
@@ -14,26 +14,6 @@ name="initrandom"
start_cmd="initrandom_start"
stop_cmd=":"
-feed_dev_random()
-{
- if [ -f "${1}" -a -r "${1}" -a -s "${1}" ]; then
- cat "${1}" | dd of=/dev/random bs=8k 2>/dev/null
- fi
-}
-
-better_than_nothing()
-{
- # XXX temporary until we can improve the entropy
- # harvesting rate.
- # Entropy below is not great, but better than nothing.
- # This unblocks the generator at startup
- # Note: commands are ordered to cause the most variance across reboots.
- ( kenv; dmesg; df -ib; ps -fauxww; date; sysctl -a ) \
- | dd of=/dev/random bs=8k 2>/dev/null
- /sbin/sha256 -q `sysctl -n kern.bootfile` \
- | dd of=/dev/random bs=8k 2>/dev/null
-}
-
initrandom_start()
{
soft_random_generator=`sysctl kern.random 2>/dev/null`
@@ -63,23 +43,15 @@ initrandom_start()
else
${SYSCTL} kern.random.sys.harvest.point_to_point=0 >/dev/null
fi
- fi
- # First pass at reseeding /dev/random.
- #
- case ${entropy_file} in
- [Nn][Oo] | '')
- ;;
- *)
- if [ -w /dev/random ]; then
- feed_dev_random "${entropy_file}"
+ if checkyesno harvest_swi; then
+ ${SYSCTL} kern.random.sys.harvest.swi=1 >/dev/null
+ echo -n ' swi'
+ else
+ ${SYSCTL} kern.random.sys.harvest.swi=0 >/dev/null
fi
- ;;
- esac
-
- better_than_nothing
+ fi
- echo -n ' kickstart'
fi
echo '.'
View
41 share/examples/kld/random_adaptor/random_adaptor_example.c
@@ -30,32 +30,29 @@ __FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/kernel.h>
+#include <sys/lock.h>
#include <sys/module.h>
-#include <sys/selinfo.h>
+#include <sys/random.h>
#include <sys/systm.h>
+#include <dev/random/live_entropy_sources.h>
#include <dev/random/random_adaptors.h>
#include <dev/random/randomdev.h>
-#define RNG_NAME "example"
-
static int random_example_read(void *, int);
struct random_adaptor random_example = {
.ident = "Example RNG",
- .init = (random_init_func_t *)random_null_func,
- .deinit = (random_deinit_func_t *)random_null_func,
+ .source = RANDOM_PURE_BOGUS, /* Make sure this is in
+ * sys/random.h and is unique */
.read = random_example_read,
- .write = (random_write_func_t *)random_null_func,
- .reseed = (random_reseed_func_t *)random_null_func,
- .seeded = 1,
};
/*
* Used under the license provided @ http://xkcd.com/221/
* http://creativecommons.org/licenses/by-nc/2.5/
*/
-static u_char
+static uint8_t
getRandomNumber(void)
{
return 4; /* chosen by fair dice roll, guaranteed to be random */
@@ -64,14 +61,13 @@ getRandomNumber(void)
static int
random_example_read(void *buf, int c)
{
- u_char *b;
+ uint8_t *b;
int count;
b = buf;
- for (count = 0; count < c; count++) {
+ for (count = 0; count < c; count++)
b[count] = getRandomNumber();
- }
printf("returning %d bytes of pure randomness\n", c);
return (c);
@@ -80,15 +76,26 @@ random_example_read(void *buf, int c)
static int
random_example_modevent(module_t mod, int type, void *unused)
{
+ int error = 0;
switch (type) {
case MOD_LOAD:
- random_adaptor_register(RNG_NAME, &random_example);
- EVENTHANDLER_INVOKE(random_adaptor_attach, &random_example);
- return (0);
+ live_entropy_source_register(&random_example);
+ break;
+
+ case MOD_UNLOAD:
+ live_entropy_source_deregister(&random_example);
+ break;
+
+ case MOD_SHUTDOWN:
+ break;
+
+ default:
+ error = EOPNOTSUPP;
+ break;
}
- return (EINVAL);
+ return (error);
}
-RANDOM_ADAPTOR_MODULE(random_example, random_example_modevent, 1);
+LIVE_ENTROPY_SRC_MODULE(live_entropy_source_example, random_example_modevent, 1);
View
121 share/man/man4/random.4
@@ -1,4 +1,4 @@
-.\" Copyright (c) 2001 Mark R V Murray. All rights reserved.
+.\" Copyright (c) 2001-2013 Mark R V Murray. All rights reserved.
.\"
.\" Redistribution and use in source and binary forms, with or without
.\" modification, are permitted provided that the following conditions
@@ -23,7 +23,7 @@
.\"
.\" $FreeBSD$
.\"
-.Dd August 7, 2013
+.Dd October 12, 2013
.Dt RANDOM 4
.Os
.Sh NAME
@@ -43,35 +43,48 @@ The device will probe for
certain hardware entropy sources,
and use these in preference to the fallback,
which is a generator implemented in software.
-If the kernel environment MIB's
-.Va hw.nehemiah_rng_enable
-or
-.Va hw.ivy_rng_enable
-are set to
-.Dq Li 0 ,
-the associated hardware entropy source will be ignored.
.Pp
-If the device is using
-the software generator,
-writing data to
-.Nm
-would perturb the internal state.
-This perturbation of the internal state
-is the only userland method of introducing
-extra entropy into the device.
-If the writer has superuser privilege,
-then closing the device after writing
-will make the software generator reseed itself.
-This can be used for extra security,
-as it immediately introduces any/all new entropy
-into the PRNG.
-The hardware generators will generate
-sufficient quantities of entropy,
-and will therefore ignore user-supplied input.
-The software
+The software generator will start in an
+.Em unseeded
+state, and will block reads until
+it is (re)seeded.
+This may cause trouble at system boot
+when keys and the like
+are generated from
+/dev/random
+so steps should be taken to ensure a
+reseed as soon as possible.
+The
+.Xr sysctl 8
+controlling the
+.Em seeded
+status (see below) may be used
+if security is not an issue
+or for convenience
+during setup or development.
+.Pp
+This initial seeding
+of random number generators
+is a bootstrapping problem
+that needs very careful attention.
+In some cases,
+it may be difficult
+to find enough randomness
+to seed a random number generator
+until a system is fully operational,
+but the system requires random numbers
+to become fully operational.
+It is (or more accurately should be)
+critically important that the
.Nm
-device may be controlled with
-.Xr sysctl 8 .
+device is seeded
+before the first time it is used.
+In the case where a dummy or "blocking-only"
+device is used,
+it is the responsibility
+of the system architect
+to ensure that no blocking reads
+hold up critical processes.
.Pp
To see the current settings of the software
.Nm
@@ -81,22 +94,20 @@ device, use the command line:
.Pp
which results in something like:
.Bd -literal -offset indent
-kern.random.adaptors: yarrow
+kern.random.adaptors: yarrow,dummy
+kern.random.active_adaptor: yarrow
+kern.random.yarrow.gengateinterval: 10
+kern.random.yarrow.bins: 10
+kern.random.yarrow.fastthresh: 96
+kern.random.yarrow.slowthresh: 128
+kern.random.yarrow.slowoverthresh: 2
kern.random.sys.seeded: 1
kern.random.sys.harvest.ethernet: 1
kern.random.sys.harvest.point_to_point: 1
kern.random.sys.harvest.interrupt: 1
-kern.random.sys.harvest.swi: 0
-kern.random.yarrow.gengateinterval: 10
-kern.random.yarrow.bins: 10
-kern.random.yarrow.fastthresh: 192
-kern.random.yarrow.slowthresh: 256
-kern.random.yarrow.slowoverthresh: 2
+kern.random.sys.harvest.swi: 1
.Ed
.Pp
-(These would not be seen if a
-hardware generator is present.)
-.Pp
Other than
.Dl kern.random.adaptors
all settings are read/write.
@@ -107,9 +118,10 @@ variable indicates whether or not the
.Nm
device is in an acceptably secure state
as a result of reseeding.
-If set to 0, the device will block (on read) until the next reseed
-(which can be from an explicit write,
-or as a result of entropy harvesting).
+If set to 0,
+the device will block (on read)
+until the next reseed
+as a result of entropy harvesting.
A reseed will set the value to 1 (non-blocking).
.Pp
The
@@ -276,19 +288,6 @@ the generator produce independent sequences.
However, the guessability or reproducibility of the sequence is unimportant,
unlike the previous cases.
.Pp
-One final consideration for the seeding of random number generators
-is a bootstrapping problem.
-In some cases, it may be difficult to find enough randomness to
-seed a random number generator until a system is fully operational,
-but the system requires random numbers to become fully operational.
-There is no substitute for careful thought here,
-but the
-.Fx
-.Nm
-device,
-which is based on the Yarrow system,
-should be of some help in this area.
-.Pp
.Fx
does also provide the traditional
.Xr rand 3
@@ -325,17 +324,7 @@ and is an implementation of the
.Em Yarrow
algorithm by Bruce Schneier,
.Em et al .
-The only hardware implementations
-currently are for the
-.Tn VIA C3 Nehemiah
-(stepping 3 or greater)
-CPU
-and the
-.Tn Intel
-.Dq Bull Mountain
-.Em RdRand
-instruction and underlying random number generator (RNG).
-More will be added in the future.
+Significant infrastructure work was done by Arthur Mesh.
.Pp
The author gratefully acknowledges
significant assistance from VIA Technologies, Inc.
View
11 sys/boot/forth/loader.conf
@@ -39,6 +39,17 @@ bitmap_type="splash_image_data" # and place it on the module_path
##############################################################
+### Random number generator configuration ###################
+##############################################################
+
+entropy_cache_load="NO" # Set this to YES to load entropy at boot time
+entropy_cache_name="/boot/entropy" # Set this to the name of the file
+entropy_cache_type="/boot/entropy"
+#kern.random.sys.seeded="0" # Set this to 1 to start /dev/random
+ # without waiting for a (re)seed.
+
+
+##############################################################
### Loader settings ########################################
##############################################################
View
5 sys/conf/NOTES
@@ -2962,3 +2962,8 @@ options RCTL
options BROOKTREE_ALLOC_PAGES=(217*4+1)
options MAXFILES=999
+# Random number generator
+options RANDOM_YARROW # Yarrow RNG
+##options RANDOM_FORTUNA # Fortuna RNG - not yet implemented
+options RANDOM_DEBUG # Debugging messages
+options RANDOM_RWFILE # Read and write entropy cache
View
8 sys/conf/files
@@ -2043,13 +2043,15 @@ rt2860.fw optional rt2860fw | ralfw \
no-obj no-implicit-rule \
clean "rt2860.fw"
dev/random/harvest.c standard
-dev/random/hash.c optional random
-dev/random/pseudo_rng.c standard
+dev/random/dummy_rng.c standard
dev/random/random_adaptors.c standard
-dev/random/random_harvestq.c standard
+dev/random/live_entropy_sources.c optional random
+dev/random/random_harvestq.c optional random
dev/random/randomdev.c optional random
dev/random/randomdev_soft.c optional random
dev/random/yarrow.c optional random
+dev/random/hash.c optional random
+dev/random/rwfile.c optional random
dev/rc/rc.c optional rc
dev/re/if_re.c optional re
dev/rndtest/rndtest.c optional rndtest
View
4 sys/conf/files.amd64
@@ -259,8 +259,8 @@ dev/nvme/nvme_sysctl.c optional nvme
dev/nvme/nvme_test.c optional nvme
dev/nvme/nvme_util.c optional nvme
dev/nvram/nvram.c optional nvram isa
-dev/random/ivy.c optional random rdrand_rng
-dev/random/nehemiah.c optional random padlock_rng
+dev/random/ivy.c optional rdrand_rng
+dev/random/nehemiah.c optional padlock_rng
dev/qlxge/qls_dbg.c optional qlxge pci
dev/qlxge/qls_dump.c optional qlxge pci
dev/qlxge/qls_hw.c optional qlxge pci
View
4 sys/conf/files.i386
@@ -257,8 +257,8 @@ dev/nvme/nvme_test.c optional nvme
dev/nvme/nvme_util.c optional nvme
dev/nvram/nvram.c optional nvram isa
dev/pcf/pcf_isa.c optional pcf
-dev/random/ivy.c optional random rdrand_rng
-dev/random/nehemiah.c optional random padlock_rng
+dev/random/ivy.c optional rdrand_rng
+dev/random/nehemiah.c optional padlock_rng
dev/sbni/if_sbni.c optional sbni
dev/sbni/if_sbni_isa.c optional sbni isa
dev/sbni/if_sbni_pci.c optional sbni pci
View
6 sys/conf/options
@@ -904,3 +904,9 @@ RACCT opt_global.h
# Resource Limits
RCTL opt_global.h
+
+# Random number generator(s)
+RANDOM_YARROW opt_random.h
+RANDOM_FORTUNA opt_random.h
+RANDOM_DEBUG opt_random.h
+RANDOM_RWFILE opt_random.h
View
2  sys/dev/glxsb/glxsb.c
@@ -476,7 +476,7 @@ glxsb_rnd(void *v)
if (status & SB_RNS_TRNG_VALID) {
value = bus_read_4(sc->sc_sr, SB_RANDOM_NUM);
/* feed with one uint32 */
- random_harvest(&value, 4, 32/2, 0, RANDOM_PURE);
+ random_harvest(&value, 4, 32/2, RANDOM_PURE_GLXSB);
}
callout_reset(&sc->sc_rngco, sc->sc_rnghz, glxsb_rnd, sc);
View
2  sys/dev/hifn/hifn7751.c
@@ -258,7 +258,7 @@ hifn_partname(struct hifn_softc *sc)
static void
default_harvest(struct rndtest_state *rsp, void *buf, u_int count)
{
- random_harvest(buf, count, count*NBBY/2, 0, RANDOM_PURE);
+ random_harvest(buf, count, count*NBBY/2, RANDOM_PURE_HIFN);
}
static u_int
View
90 sys/dev/random/pseudo_rng.c → sys/dev/random/dummy_rng.c
@@ -28,93 +28,91 @@
__FBSDID("$FreeBSD$");
#include <sys/param.h>
-#include <sys/time.h>
+#include <sys/fcntl.h>
#include <sys/kernel.h>
+#include <sys/malloc.h>
#include <sys/module.h>
+#include <sys/random.h>
#include <sys/selinfo.h>
#include <sys/systm.h>
+#include <sys/time.h>
#include <dev/random/random_adaptors.h>
#include <dev/random/randomdev.h>
-static struct mtx pseudo_random_block_mtx;
+static struct mtx dummy_random_mtx;
/* Used to fake out unused random calls in random_adaptor */
-void
+static void
random_null_func(void)
{
}
static int
-pseudo_random_block_read(void *buf __unused, int c __unused)
+dummy_random_poll(int events __unused, struct thread *td __unused)
{
- mtx_lock(&pseudo_random_block_mtx);
-
- printf("random(4) device is blocking.\n");
- msleep(pseudo_random_block_read, &pseudo_random_block_mtx, 0,
- "block", 0);
-
- mtx_unlock(&pseudo_random_block_mtx);
-
return (0);
}
-static void
-pseudo_random_block_init(void)
+static int
+dummy_random_block(int flag)
{
+ int error = 0;
+
+ mtx_lock(&dummy_random_mtx);
+
+ /* Blocking logic */
+ while (!error) {
+ if (flag & O_NONBLOCK)
+ error = EWOULDBLOCK;
+ else {
+ printf("random: dummy device blocking on read.\n");
+ error = msleep(&dummy_random_block,
+ &dummy_random_mtx,
+ PUSER | PCATCH, "block", 0);
+ }
+ }
+ mtx_unlock(&dummy_random_mtx);
- mtx_init(&pseudo_random_block_mtx, "sleep mtx for random_block",
- NULL, MTX_DEF);
+ return (error);
}
static void
-pseudo_random_block_deinit(void)
+dummy_random_init(void)
{
- mtx_destroy(&pseudo_random_block_mtx);
+ mtx_init(&dummy_random_mtx, "sleep mtx for dummy_random",
+ NULL, MTX_DEF);
}
-struct random_adaptor pseudo_random_block = {
- .ident = "pseudo-RNG that always blocks",
- .init = pseudo_random_block_init,
- .deinit = pseudo_random_block_deinit,
- .read = pseudo_random_block_read,
- .write = (random_write_func_t *)random_null_func,
- .reseed = (random_reseed_func_t *)random_null_func,
- .seeded = 1,
-};
-
-static int
-pseudo_random_panic_read(void *buf, int c)
+static void
+dummy_random_deinit(void)
{
- panic("Insert a witty panic msg in here.");
-
- return (0);
+ mtx_destroy(&dummy_random_mtx);
}
-struct random_adaptor pseudo_random_panic = {
- .ident = "pseudo-RNG that always panics on first read(2)",
- .init = (random_init_func_t *)random_null_func,
- .deinit = (random_deinit_func_t *)random_null_func,
- .read = pseudo_random_panic_read,
- .write = (random_write_func_t *)random_null_func,
+struct random_adaptor dummy_random = {
+ .ident = "Dummy entropy device that always blocks",
+ .init = dummy_random_init,
+ .deinit = dummy_random_deinit,
+ .block = dummy_random_block,
+ .poll = dummy_random_poll,
+ .read = (random_read_func_t *)random_null_func,
.reseed = (random_reseed_func_t *)random_null_func,
- .seeded = 1,
+ .seeded = 0, /* This device can never be seeded */
};
static int
-pseudo_random_modevent(module_t mod, int type, void *unused)
+dummy_random_modevent(module_t mod __unused, int type, void *unused __unused)
{
switch (type) {
case MOD_LOAD:
- random_adaptor_register("block", &pseudo_random_block);
+ random_adaptor_register("dummy", &dummy_random);
EVENTHANDLER_INVOKE(random_adaptor_attach,
- &pseudo_random_block);
-
- random_adaptor_register("panic", &pseudo_random_panic);
+ &dummy_random);
return (0);
}
@@ -122,4 +120,4 @@ pseudo_random_modevent(module_t mod, int type, void *unused)
return (EINVAL);
}
-RANDOM_ADAPTOR_MODULE(pseudo, pseudo_random_modevent, 1);
+RANDOM_ADAPTOR_MODULE(dummy, dummy_random_modevent, 1);
View
12 sys/dev/random/harvest.c
@@ -48,20 +48,20 @@ __FBSDID("$FreeBSD$");
static int read_random_phony(void *, int);
/* Structure holding the desired entropy sources */
-struct harvest_select harvest = { 1, 1, 1, 0 };
+struct harvest_select harvest = { 1, 1, 1, 1 };
static int warned = 0;
/* hold the address of the routine which is actually called if
* the randomdev is loaded
*/
-static void (*reap_func)(u_int64_t, const void *, u_int, u_int, u_int,
+static void (*reap_func)(u_int64_t, const void *, u_int, u_int,
enum esource) = NULL;
static int (*read_func)(void *, int) = read_random_phony;
/* Initialise the harvester at load time */
void
randomdev_init_harvester(void (*reaper)(u_int64_t, const void *, u_int,
- u_int, u_int, enum esource), int (*reader)(void *, int))
+ u_int, enum esource), int (*reader)(void *, int))
{
reap_func = reaper;
read_func = reader;
@@ -86,12 +86,10 @@ randomdev_deinit_harvester(void)
* read which can be quite expensive.
*/
void
-random_harvest(void *entropy, u_int count, u_int bits, u_int frac,
- enum esource origin)
+random_harvest(void *entropy, u_int count, u_int bits, enum esource origin)
{
if (reap_func)
- (*reap_func)(get_cyclecount(), entropy, count, bits, frac,
- origin);
+ (*reap_func)(get_cyclecount(), entropy, count, bits, origin);
}
/* Userland-visible version of read_random */
View
5 sys/dev/random/hash.h
@@ -26,6 +26,9 @@
* $FreeBSD$
*/
+#ifndef SYS_DEV_RANDOM_HASH_H_INCLUDED
+#define SYS_DEV_RANDOM_HASH_H_INCLUDED
+
#define KEYSIZE 32 /* (in bytes) == 256 bits */
#define BLOCKSIZE 16 /* (in bytes) == 128 bits */
@@ -43,3 +46,5 @@ void randomdev_hash_iterate(struct randomdev_hash *, void *, size_t);
void randomdev_hash_finish(struct randomdev_hash *, void *);
void randomdev_encrypt_init(struct randomdev_key *, void *);
void randomdev_encrypt(struct randomdev_key *context, void *, void *, unsigned);
+
+#endif
View
87 sys/dev/random/ivy.c
@@ -30,38 +30,35 @@
__FBSDID("$FreeBSD$");
#include <sys/param.h>
-#include <sys/time.h>
#include <sys/kernel.h>
#include <sys/lock.h>
+#include <sys/malloc.h>
#include <sys/module.h>
-#include <sys/mutex.h>
+#include <sys/random.h>
#include <sys/selinfo.h>
#include <sys/systm.h>
#include <machine/md_var.h>
#include <machine/specialreg.h>
-#include <dev/random/random_adaptors.h>
#include <dev/random/randomdev.h>
+#include <dev/random/randomdev_soft.h>
+#include <dev/random/random_harvestq.h>
+#include <dev/random/live_entropy_sources.h>
+#include <dev/random/random_adaptors.h>
#define RETRY_COUNT 10
-static void random_ivy_init(void);
-static void random_ivy_deinit(void);
static int random_ivy_read(void *, int);
-struct random_adaptor random_ivy = {
+static struct random_hardware_source random_ivy = {
.ident = "Hardware, Intel IvyBridge+ RNG",
- .init = random_ivy_init,
- .deinit = random_ivy_deinit,
- .read = random_ivy_read,
- .write = (random_write_func_t *)random_null_func,
- .reseed = (random_reseed_func_t *)random_null_func,
- .seeded = 1,
+ .source = RANDOM_PURE_RDRAND,
+ .read = random_ivy_read
};
static inline int
-ivy_rng_store(long *tmp)
+ivy_rng_store(uint64_t *tmp)
{
#ifdef __GNUCLIKE_ASM
uint32_t count;
@@ -86,34 +83,26 @@ ivy_rng_store(long *tmp)
#endif
}
-static void
-random_ivy_init(void)
-{
-}
-
-void
-random_ivy_deinit(void)
-{
-}
-
static int
random_ivy_read(void *buf, int c)
{
- char *b;
- long tmp;
- int count, res, retry;
+ uint8_t *b;
+ int count, ret, retry;
+ uint64_t tmp;
- for (count = c, b = buf; count > 0; count -= res, b += res) {
+ b = buf;
+ for (count = c; count > 0; count -= ret) {
for (retry = 0; retry < RETRY_COUNT; retry++) {
- res = ivy_rng_store(&tmp);
- if (res != 0)
+ ret = ivy_rng_store(&tmp);
+ if (ret != 0)
break;
}
- if (res == 0)
+ if (ret == 0)
break;
- if (res > count)
- res = count;
- memcpy(b, &tmp, res);
+ if (ret > count)
+ ret = count;
+ memcpy(b, &tmp, ret);
+ b += ret;
}
return (c - count);
}
@@ -121,25 +110,35 @@ random_ivy_read(void *buf, int c)
static int
rdrand_modevent(module_t mod, int type, void *unused)
{
+ int error = 0;
switch (type) {
case MOD_LOAD:
- if (cpu_feature2 & CPUID2_RDRAND) {
- random_adaptor_register("rdrand", &random_ivy);
- EVENTHANDLER_INVOKE(random_adaptor_attach, &random_ivy);
- return (0);
- } else {
+ if (cpu_feature2 & CPUID2_RDRAND)
+ live_entropy_source_register(&random_ivy);
+ else
#ifndef KLD_MODULE
if (bootverbose)
#endif
- printf(
- "%s: RDRAND feature is not present on this CPU\n",
+ printf("%s: RDRAND is not present\n",
random_ivy.ident);
- return (0);
- }
+ break;
+
+ case MOD_UNLOAD:
+ if (cpu_feature2 & CPUID2_RDRAND)
+ live_entropy_source_deregister(&random_ivy);
+ break;
+
+ case MOD_SHUTDOWN:
+ break;
+
+ default:
+ error = EOPNOTSUPP;
+ break;
+
}
- return (EINVAL);
+ return (error);
}
-RANDOM_ADAPTOR_MODULE(random_rdrand, rdrand_modevent, 1);
+LIVE_ENTROPY_SRC_MODULE(random_rdrand, rdrand_modevent, 1);
View
195 sys/dev/random/live_entropy_sources.c
@@ -0,0 +1,195 @@
+/*-
+ * Copyright (c) 2013 Arthur Mesh <arthurmesh@gmail.com>
+ * Copyright (c) 2013 Mark R V Murray
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer
+ * in this position and unchanged.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <sys/param.h>
+__FBSDID("$FreeBSD$");
+
+#include <sys/kernel.h>
+#include <sys/libkern.h>
+#include <sys/lock.h>
+#include <sys/malloc.h>
+#include <sys/queue.h>
+#include <sys/random.h>
+#include <sys/selinfo.h>
+#include <sys/sx.h>
+#include <sys/sysctl.h>
+#include <sys/systm.h>
+#include <sys/unistd.h>
+
+#include <machine/cpu.h>
+
+#include <dev/random/randomdev.h>
+#include <dev/random/randomdev_soft.h>
+#include <dev/random/random_adaptors.h>
+#include <dev/random/random_harvestq.h>
+
+#include "live_entropy_sources.h"
+
+LIST_HEAD(les_head, live_entropy_sources);
+static struct les_head sources = LIST_HEAD_INITIALIZER(sources);
+
+/*
+ * The live_lock protects the consistency of the "struct les_head sources"
+ */
+static struct sx les_lock; /* need a sleepable lock */
+
+void
+live_entropy_source_register(struct random_hardware_source *rsource)
+{
+ struct live_entropy_sources *les;
+
+ KASSERT(rsource != NULL, ("invalid input to %s", __func__));
+
+ les = malloc(sizeof(struct live_entropy_sources), M_ENTROPY, M_WAITOK);
+ les->rsource = rsource;
+
+ sx_xlock(&les_lock);
+ LIST_INSERT_HEAD(&sources, les, entries);
+ sx_xunlock(&les_lock);
+}
+
+void
+live_entropy_source_deregister(struct random_hardware_source *rsource)
+{
+ struct live_entropy_sources *les = NULL;
+
+ KASSERT(rsource != NULL, ("invalid input to %s", __func__));
+
+ sx_xlock(&les_lock);
+ LIST_FOREACH(les, &sources, entries)
+ if (les->rsource == rsource) {
+ LIST_REMOVE(les, entries);
+ break;
+ }
+ sx_xunlock(&les_lock);
+ if (les != NULL)
+ free(les, M_ENTROPY);
+}
+
+static int
+live_entropy_source_handler(SYSCTL_HANDLER_ARGS)
+{
+ struct live_entropy_sources *les;
+ int error, count;
+
+ count = error = 0;
+
+ sx_slock(&les_lock);
+
+ if (LIST_EMPTY(&sources))
+ error = SYSCTL_OUT(req, "", 0);
+ else {
+ LIST_FOREACH(les, &sources, entries) {
+
+ error = SYSCTL_OUT(req, ",", count++ ? 1 : 0);
+ if (error)
+ break;
+
+ error = SYSCTL_OUT(req, les->rsource->ident, strlen(les->rsource->ident));
+ if (error)
+ break;
+ }
+ }
+
+ sx_sunlock(&les_lock);
+
+ return (error);
+}
+
+static void
+live_entropy_sources_init(void *unused)
+{
+
+ SYSCTL_PROC(_kern_random, OID_AUTO, live_entropy_sources,
+ CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE,
+ NULL, 0, live_entropy_source_handler, "",
+ "List of Active Live Entropy Sources");
+
+ sx_init(&les_lock, "live_entropy_sources");
+}
+
+/*
+ * Run through all "live" sources reading entropy for the given
+ * number of rounds, which should be a multiple of the number
+ * of entropy accumulation pools in use; 2 for Yarrow and 32
+ * for Fortuna.
+ *
+ * BEWARE!!!
+ * This function runs inside the RNG thread! Don't do anything silly!
+ * Remember that we are NOT holding harvest_mtx on entry!
+ */
+void
+live_entropy_sources_feed(int rounds, event_proc_f entropy_processor)
+{
+ static struct harvest event;
+ static uint8_t buf[HARVESTSIZE];
+ struct live_entropy_sources *les;
+ int i, n;
+
+ sx_slock(&les_lock);
+
+ /*
+ * Walk over all of live entropy sources, and feed their output
+ * to the system-wide RNG.
+ */
+ LIST_FOREACH(les, &sources, entries) {
+
+ for (i = 0; i < rounds; i++) {
+ /*
+ * This should be quick, since it's a live entropy
+ * source.
+ */
+ /* FIXME: Whine loudly if this didn't work. */
+ n = les->rsource->read(buf, sizeof(buf));
+ n = MIN(n, HARVESTSIZE);
+
+ event.somecounter = get_cyclecount();
+ event.size = n;
+ event.bits = (n*8)/2;
+ event.source = les->rsource->source;
+ memcpy(event.entropy, buf, n);
+
+ /* Do the actual entropy insertion */
+ entropy_processor(&event);
+ }
+
+ }
+
+ sx_sunlock(&les_lock);
+}
+
+static void
+live_entropy_sources_deinit(void *unused)
+{
+
+ sx_destroy(&les_lock);
+}
+
+SYSINIT(random_adaptors, SI_SUB_DRIVERS, SI_ORDER_FIRST,
+ live_entropy_sources_init, NULL);
+SYSUNINIT(random_adaptors, SI_SUB_DRIVERS, SI_ORDER_FIRST,
+ live_entropy_sources_deinit, NULL);
View
60 sys/dev/random/live_entropy_sources.h
@@ -0,0 +1,60 @@
+/*-
+ * Copyright (c) 2013 Arthur Mesh <arthurmesh@gmail.com>
+ * Copyright (c) 2013 Mark R V Murray
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer
+ * in this position and unchanged.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef SYS_DEV_RANDOM_LIVE_ENTROPY_SOURCES_H_INCLUDED
+#define SYS_DEV_RANDOM_LIVE_ENTROPY_SOURCES_H_INCLUDED
+
+/*
+ * Live entropy source is a source of entropy that can provide
+ * specified or approximate amount of entropy immediately upon request or within
+ * an acceptable amount of time.
+ */
+struct live_entropy_sources {
+ LIST_ENTRY(live_entropy_sources) entries; /* list of providers */
+ struct random_hardware_source *rsource; /* associated random adaptor */
+};
+
+extern struct mtx live_mtx;
+
+void live_entropy_source_register(struct random_hardware_source *);
+void live_entropy_source_deregister(struct random_hardware_source *);
+void live_entropy_sources_feed(int, event_proc_f);
+
+#define LIVE_ENTROPY_SRC_MODULE(name, modevent, ver) \
+ static moduledata_t name##_mod = { \
+ #name, \
+ modevent, \
+ 0 \
+ }; \
+ DECLARE_MODULE(name, name##_mod, SI_SUB_DRIVERS, \
+ SI_ORDER_SECOND); \
+ MODULE_VERSION(name, ver); \
+ MODULE_DEPEND(name, random, 1, 1, 1);
+
+#endif /* SYS_DEV_RANDOM_LIVE_ENTROPY_SOURCES_H_INCLUDED */
View
191 sys/dev/random/nehemiah.c
@@ -1,6 +1,5 @@
/*-
- * Copyright (c) 2013 David E. O'Brien <obrien@NUXI.org>
- * Copyright (c) 2004 Mark R V Murray
+ * Copyright (c) 2013 Mark R V Murray
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -30,209 +29,133 @@
__FBSDID("$FreeBSD$");
#include <sys/param.h>
-#include <sys/time.h>
+#include <sys/kernel.h>
#include <sys/lock.h>
-#include <sys/mutex.h>
+#include <sys/malloc.h>
#include <sys/module.h>
+#include <sys/random.h>
#include <sys/selinfo.h>
#include <sys/systm.h>
-#include <sys/kernel.h>
+#include <machine/segments.h>
#include <machine/pcb.h>
#include <machine/md_var.h>
#include <machine/specialreg.h>
-#include <dev/random/random_adaptors.h>
#include <dev/random/randomdev.h>
-
-#define RANDOM_BLOCK_SIZE 256
-#define CIPHER_BLOCK_SIZE 16
+#include <dev/random/randomdev_soft.h>
+#include <dev/random/random_harvestq.h>
+#include <dev/random/live_entropy_sources.h>
+#include <dev/random/random_adaptors.h>
static void random_nehemiah_init(void);
static void random_nehemiah_deinit(void);
static int random_nehemiah_read(void *, int);
-struct random_adaptor random_nehemiah = {
- .ident = "Hardware, VIA Nehemiah",
- .init = random_nehemiah_init,
- .deinit = random_nehemiah_deinit,
- .read = random_nehemiah_read,
- .write = (random_write_func_t *)random_null_func,
- .reseed = (random_reseed_func_t *)random_null_func,
- .seeded = 1,
-};
-
-union VIA_ACE_CW {
- uint64_t raw;
- struct {
- u_int round_count : 4;
- u_int algorithm_type : 3;
- u_int key_generation_type : 1;
- u_int intermediate : 1;
- u_int decrypt : 1;
- u_int key_size : 2;
- u_int filler0 : 20;
- u_int filler1 : 32;
- u_int filler2 : 32;
- u_int filler3 : 32;
- } field;
+static struct random_hardware_source random_nehemiah = {
+ .ident = "Hardware, VIA Nehemiah Padlock RNG",
+ .source = RANDOM_PURE_NEHEMIAH,
+ .read = random_nehemiah_read
};
-/* The extra 7 is to allow an 8-byte write on the last byte of the
- * arrays. The ACE wants the AES data 16-byte/128-bit aligned, and
- * it _always_ writes n*64 bits. The RNG does not care about alignment,
- * and it always writes n*32 bits or n*64 bits.
+/* TODO: now that the Davies-Meyer hash is gone and we only use
+ * the 'xstore' instruction, do we still need to preserve the
+ * FPU state with fpu_kern_(enter|leave)() ?
*/
-static uint8_t key[CIPHER_BLOCK_SIZE+7] __aligned(16);
-static uint8_t iv[CIPHER_BLOCK_SIZE+7] __aligned(16);
-static uint8_t in[RANDOM_BLOCK_SIZE+7] __aligned(16);
-static uint8_t out[RANDOM_BLOCK_SIZE+7] __aligned(16);
-
-static union VIA_ACE_CW acw __aligned(16);
-
static struct fpu_kern_ctx *fpu_ctx_save;
-static struct mtx random_nehemiah_mtx;
-
+/* This H/W source never stores more than 8 bytes in one go */
/* ARGSUSED */
static __inline size_t
VIA_RNG_store(void *buf)
{
-#ifdef __GNUCLIKE_ASM
uint32_t retval = 0;
uint32_t rate = 0;
- /* The .byte line is really VIA C3 "xstore" instruction */
+#ifdef __GNUCLIKE_ASM
__asm __volatile(
- "movl $0,%%edx \n\t"
- ".byte 0x0f, 0xa7, 0xc0"
+ "movl $0,%%edx\n\t"
+ ".byte 0x0f, 0xa7, 0xc0" /* xstore */
: "=a" (retval), "+d" (rate), "+D" (buf)
:
: "memory"
);
+#endif
if (rate == 0)
return (retval&0x1f);
-#endif
return (0);
}
-/* ARGSUSED */
-static __inline void
-VIA_ACE_cbc(void *in, void *out, size_t count, void *key, union VIA_ACE_CW *cw, void *iv)
-{
-#ifdef __GNUCLIKE_ASM
- /* The .byte line is really VIA C3 "xcrypt-cbc" instruction */
- __asm __volatile(
- "pushf \n\t"
- "popf \n\t"
- "rep \n\t"
- ".byte 0x0f, 0xa7, 0xc8"
- : "+a" (iv), "+c" (count), "+D" (out), "+S" (in)
- : "b" (key), "d" (cw)
- : "cc", "memory"
- );
-#endif
-}
-
static void
random_nehemiah_init(void)
{
- acw.raw = 0ULL;
- acw.field.round_count = 12;
- mtx_init(&random_nehemiah_mtx, "random nehemiah", NULL, MTX_DEF);
fpu_ctx_save = fpu_kern_alloc_ctx(FPU_KERN_NORMAL);
}
-void
+static void
random_nehemiah_deinit(void)
{
fpu_kern_free_ctx(fpu_ctx_save);
- mtx_destroy(&random_nehemiah_mtx);
}
static int
random_nehemiah_read(void *buf, int c)
{
- int i, error;
+ uint8_t *b;
size_t count, ret;
- uint8_t *p;
-
- mtx_lock(&random_nehemiah_mtx);
- error = fpu_kern_enter(curthread, fpu_ctx_save, FPU_KERN_NORMAL);
- if (error != 0) {
- mtx_unlock(&random_nehemiah_mtx);
- return (0);
+ uint64_t tmp;
+
+ if ((fpu_kern_enter(curthread, fpu_ctx_save, FPU_KERN_NORMAL) == 0)) {
+ b = buf;
+ for (count = c; count > 0; count -= ret) {
+ ret = MIN(VIA_RNG_store(&tmp), count);
+ memcpy(b, &tmp, ret);
+ b += ret;
+ }
+ fpu_kern_leave(curthread, fpu_ctx_save);
}
+ else
+ c = 0;
- /* Get a random AES key */
- count = 0;
- p = key;
- do {
- ret = VIA_RNG_store(p);
- p += ret;
- count += ret;
- } while (count < CIPHER_BLOCK_SIZE);
-
- /* Get a random AES IV */
- count = 0;
- p = iv;
- do {
- ret = VIA_RNG_store(p);
- p += ret;
- count += ret;
- } while (count < CIPHER_BLOCK_SIZE);
-
- /* Get a block of random bytes */
- count = 0;
- p = in;
- do {
- ret = VIA_RNG_store(p);
- p += ret;
- count += ret;
- } while (count < RANDOM_BLOCK_SIZE);
-
- /* This is a Davies-Meyer hash of the most paranoid variety; the
- * key, IV and the data are all read directly from the hardware RNG.
- * All of these are used precisely once.
- */
- VIA_ACE_cbc(in, out, RANDOM_BLOCK_SIZE/CIPHER_BLOCK_SIZE,
- key, &acw, iv);
- for (i = 0; i < RANDOM_BLOCK_SIZE; i++)
- out[i] ^= in[i];
-
- c = MIN(RANDOM_BLOCK_SIZE, c);
- memcpy(buf, out, (size_t)c);
-
- fpu_kern_leave(curthread, fpu_ctx_save);
- mtx_unlock(&random_nehemiah_mtx);
return (c);
}
static int
nehemiah_modevent(module_t mod, int type, void *unused)
{
+ int error = 0;
switch (type) {
case MOD_LOAD:
if (via_feature_rng & VIA_HAS_RNG) {
- random_adaptor_register("nehemiah", &random_nehemiah);
- EVENTHANDLER_INVOKE(random_adaptor_attach,
- &random_nehemiah);
- return (0);
- } else {
+ live_entropy_source_register(&random_nehemiah);
+ random_nehemiah_init();
+ } else
#ifndef KLD_MODULE
if (bootverbose)
#endif
- printf(
- "%s: VIA RNG feature is not present on this CPU\n",
+ printf("%s: VIA Padlock RNG not present\n",
random_nehemiah.ident);
- return (0);
- }
+ break;
+
+ case MOD_UNLOAD:
+ if (via_feature_rng & VIA_HAS_RNG)
+ random_nehemiah_deinit();
+ live_entropy_source_deregister(&random_nehemiah);
+ break;
+
+ case MOD_SHUTDOWN:
+ break;
+
+ default:
+ error = EOPNOTSUPP;
+ break;
+
}
- return (EINVAL);
+ return (error);
}
-RANDOM_ADAPTOR_MODULE(nehemiah, nehemiah_modevent, 1);
+LIVE_ENTROPY_SRC_MODULE(nehemiah, nehemiah_modevent, 1);
View
106 sys/dev/random/random_adaptors.c
@@ -1,7 +1,7 @@
/*-
* Copyright (c) 2013 Arthur Mesh <arthurmesh@gmail.com>
* Copyright (c) 2013 David E. O'Brien <obrien@NUXI.org>
- * Copyright (c) 2004 Mark R V Murray
+ * Copyright (c) 2013 Mark R V Murray
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -29,17 +29,17 @@
#include <sys/param.h>
__FBSDID("$FreeBSD$");
-#include <sys/kernel.h>
#include <sys/systm.h>
+#include <sys/kernel.h>
#include <sys/kthread.h>
+#include <sys/libkern.h>
#include <sys/lock.h>
+#include <sys/malloc.h>
+#include <sys/queue.h>
#include <sys/random.h>
#include <sys/selinfo.h>
-#include <sys/sysctl.h>
#include <sys/sx.h>
-#include <sys/malloc.h>
-#include <sys/queue.h>
-#include <sys/libkern.h>
+#include <sys/sysctl.h>
#include <sys/unistd.h>
#include <dev/random/randomdev.h>
@@ -55,7 +55,7 @@ static struct sysctl_ctx_list random_clist;
struct random_adaptor *random_adaptor;
-MALLOC_DEFINE(M_RANDOM_ADAPTORS, "random_adaptors", "Random adaptors buffers");
+MALLOC_DEFINE(M_ENTROPY, "entropy", "Entropy harvesting buffers and data structures");
int
random_adaptor_register(const char *name, struct random_adaptor *rsp)
@@ -64,8 +64,7 @@ random_adaptor_register(const char *name, struct random_adaptor *rsp)
KASSERT(name != NULL && rsp != NULL, ("invalid input to %s", __func__));
- rpp = malloc(sizeof(struct random_adaptors), M_RANDOM_ADAPTORS,
- M_WAITOK);
+ rpp = malloc(sizeof(struct random_adaptors), M_ENTROPY, M_WAITOK);
rpp->name = name;
rpp->rsp = rsp;
@@ -96,30 +95,6 @@ random_adaptor_get(const char *name)
}
/*
- * In the past, the logic of the random_adaptor selection was inverted, such
- * that hardware RNGs would be chosen unless disabled. This routine is here to
- * preserve that functionality to avoid folks losing their hardware RNGs by
- * upgrading to newer kernel.
- */
-static void
-random_adaptor_choose_legacy(struct random_adaptor **adaptor)
-{
- struct random_adaptor *tmp;
- int enable;
-
- /* Then go looking for hardware */
- enable = 1;
- TUNABLE_INT_FETCH("hw.nehemiah_rng_enable", &enable);
- if (enable && (tmp = random_adaptor_get("nehemiah")))
- *adaptor = tmp;
-
- enable = 1;
- TUNABLE_INT_FETCH("hw.ivy_rng_enable", &enable);
- if (enable && (tmp = random_adaptor_get("rdrand")))
- *adaptor = tmp;
-}
-
-/*
* Walk a list of registered random(4) adaptors and pick the last non-selected
* one.
*
@@ -134,47 +109,29 @@ random_adaptor_choose(struct random_adaptor **adaptor)
KASSERT(adaptor != NULL, ("pre-conditions failed"));
*adaptor = NULL;
-
- random_adaptor_choose_legacy(adaptor);
-
- if (*adaptor != NULL)
- return;
-
if (TUNABLE_STR_FETCH("rngs_want", rngs, sizeof(rngs))) {
cp = rngs;
- while ((token = strsep(&cp, ",")) != NULL) {
+ while ((token = strsep(&cp, ",")) != NULL)
if ((*adaptor = random_adaptor_get(token)) != NULL)
break;
else if (bootverbose)
- printf(
- "%s random adaptor is not available, skipping\n",
- token);
- }
+ printf("%s random adaptor is not available,"
+ " skipping\n", token);
}
if (*adaptor == NULL) {
/*
- * Either no RNGs are prefered via rngs_want tunable, or
- * no prefered RNGs are registered.
- * Fallback to Yarrow.
+ * Fallback to the first thing that's on the list of
+ * available RNGs.
*/
- *adaptor = random_adaptor_get("yarrow");
-
- if (*adaptor == NULL) {
- /*
- * Yarrow doesn't seem to be available.
- * Fallback to the first thing that's on the list of
- * available RNGs.
- */
- sx_slock(&adaptors_lock);
+ sx_slock(&adaptors_lock);
- rpp = LIST_FIRST(&adaptors);
- if (rpp != NULL)
- *adaptor = rpp->rsp;
+ rpp = LIST_FIRST(&adaptors);
+ if (rpp != NULL)
+ *adaptor = rpp->rsp;
- sx_sunlock(&adaptors_lock);
- }
+ sx_sunlock(&adaptors_lock);
if (bootverbose && *adaptor)
printf("Falling back to <%s> random adaptor\n",
@@ -200,19 +157,16 @@ random_sysctl_adaptors_handler(SYSCTL_HANDLER_ARGS)
sx_slock(&adaptors_lock);
- if (LIST_EMPTY(&adaptors)) {
+ if (LIST_EMPTY(&adaptors))
error = SYSCTL_OUT(req, "", 0);
- } else {
-
+ else {
LIST_FOREACH(rpp, &adaptors, entries) {
error = SYSCTL_OUT(req, ",", count++ ? 1 : 0);
-
if (error)
break;
error = SYSCTL_OUT(req, rpp->name, strlen(rpp->name));
-
if (error)
break;
}
@@ -237,19 +191,17 @@ random_sysctl_active_adaptor_handler(SYSCTL_HANDLER_ARGS)
if (rsp != NULL) {
sx_slock(&adaptors_lock);
- LIST_FOREACH(rpp, &adaptors, entries) {
+ LIST_FOREACH(rpp, &adaptors, entries)
if (rpp->rsp == rsp)
name = rpp->name;
- }
sx_sunlock(&adaptors_lock);
}
- if (rsp == NULL || name == NULL) {
+ if (rsp == NULL || name == NULL)
error = SYSCTL_OUT(req, "", 0);
- } else {
+ else
error = SYSCTL_OUT(req, name, strlen(name));
- }
return (error);
}
@@ -277,3 +229,15 @@ SYSINIT(random_adaptors, SI_SUB_DRIVERS, SI_ORDER_FIRST, random_adaptors_init,
NULL);
SYSUNINIT(random_adaptors, SI_SUB_DRIVERS, SI_ORDER_FIRST,
random_adaptors_deinit, NULL);
+
+static void
+random_adaptors_reseed(void *unused)
+{
+
+ (void)unused;
+ if (random_adaptor != NULL)
+ (*random_adaptor->reseed)();
+ arc4rand(NULL, 0, 1);
+}
+SYSINIT(random_reseed, SI_SUB_INTRINSIC_POST, SI_ORDER_SECOND,
+ random_adaptors_reseed, NULL);
View
8 sys/dev/random/random_adaptors.h
@@ -26,11 +26,13 @@
* $FreeBSD$
*/
-#ifndef __RANDOM_ADAPTORS_H__
-#define __RANDOM_ADAPTORS_H__
+#ifndef SYS_DEV_RANDOM_RANDOM_ADAPTORS_H_INCLUDED
+#define SYS_DEV_RANDOM_RANDOM_ADAPTORS_H_INCLUDED
#include <sys/eventhandler.h>
+MALLOC_DECLARE(M_ENTROPY);
+
struct random_adaptors {
LIST_ENTRY(random_adaptors) entries; /* list of providers */
const char *name; /* name of random adaptor */
@@ -66,4 +68,4 @@ EVENTHANDLER_DECLARE(random_adaptor_attach, random_adaptor_attach_hook);
SYSCTL_DECL(_kern_random);
#endif /* SYSCTL_DECL */
-#endif /* __RANDOM_ADAPTORS_H__ */
+#endif /* SYS_DEV_RANDOM_RANDOM_ADAPTORS_H_INCLUDED */
View
205 sys/dev/random/random_harvestq.c
@@ -1,6 +1,6 @@
/*-
+ * Copyright (c) 2000-2013 Mark R V Murray
* Copyright (c) 2013 Arthur Mesh
- * Copyright (c) 2000-2009 Mark R V Murray
* Copyright (c) 2004 Robert N. M. Watson
* All rights reserved.
*
@@ -25,34 +25,42 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
- * $FreeBSD$
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
+#include "opt_random.h"
+
#include <sys/param.h>
#include <sys/systm.h>
+#include <sys/eventhandler.h>
#include <sys/kernel.h>
#include <sys/kthread.h>
+#include <sys/linker.h>
#include <sys/lock.h>
#include <sys/malloc.h>
#include <sys/mutex.h>
#include <sys/random.h>
+#include <sys/selinfo.h>
#include <sys/sysctl.h>
#include <sys/unistd.h>
-#include <dev/random/randomdev_soft.h>
-
-#include "random_harvestq.h"
+#include <machine/cpu.h>
+#include <machine/vmparam.h>
-#define RANDOM_FIFO_MAX 256 /* How many events to queue up */
+#include <dev/random/randomdev.h>
+#include <dev/random/randomdev_soft.h>
+#include <dev/random/random_adaptors.h>
+#include <dev/random/random_harvestq.h>
+#include <dev/random/live_entropy_sources.h>
+#include <dev/random/rwfile.h>
-MALLOC_DEFINE(M_ENTROPY, "entropy", "Entropy harvesting buffers");
+#define RANDOM_FIFO_MAX 1024 /* How many events to queue up */
/*
* The harvest mutex protects the consistency of the entropy fifos and
- * empty fifo.
+ * empty fifo and other associated structures.
*/
struct mtx harvest_mtx;
@@ -65,24 +73,88 @@ struct entropyfifo {
/* Empty entropy buffers */
static struct entropyfifo emptyfifo;
-#define EMPTYBUFFERS 1024
-
/* Harvested entropy */
-static struct entropyfifo harvestfifo[ENTROPYSOURCE];
+static struct entropyfifo harvestfifo;
/* <0 to end the kthread, 0 to let it run, 1 to flush the harvest queues */
int random_kthread_control = 0;
static struct proc *random_kthread_proc;
+#ifdef RANDOM_RWFILE
+static const char *entropy_files[] = {
+ "/entropy",
+ NULL
+};
+#endif
+
+/* Deal with entropy cached externally if this is present.
+ * Lots of policy may eventually arrive in this function.
+ * Called after / is mounted.
+ */
+static void
+random_harvestq_cache(void *arg __unused)
+{
+ uint8_t *keyfile, *data;
+ size_t size, i;
+#ifdef RANDOM_RWFILE
+ const char **entropy_file;
+ uint8_t *zbuf;
+ int error;
+#endif
+
+ /* Get stuff that may have been preloaded by loader(8) */
+ keyfile = preload_search_by_type("/boot/entropy");
+ if (keyfile != NULL) {
+ data = preload_fetch_addr(keyfile);
+ size = preload_fetch_size(keyfile);
+ if (data != NULL && size != 0) {
+ for (i = 0; i < size; i += 16)
+ random_harvestq_internal(get_cyclecount(), data + i, 16, 16, RANDOM_CACHED);
+ printf("random: read %zu bytes from preloaded cache\n", size);
+ bzero(data, size);
+ }
+ else
+ printf("random: no preloaded entropy cache available\n");
+ }
+
+#ifdef RANDOM_RWFILE
+ /* Read and attempt to overwrite the entropy cache files.
+ * If the file exists, can be read and then overwritten,
+ * then use it. Ignore it otherwise, but print out what is
+ * going on.
+ */
+ data = malloc(PAGE_SIZE, M_ENTROPY, M_WAITOK);
+ zbuf = __DECONST(void *, zero_region);
+ for (entropy_file = entropy_files; *entropy_file; entropy_file++) {
+ error = randomdev_read_file(*entropy_file, data, PAGE_SIZE);
+ if (error == 0) {
+ printf("random: entropy cache '%s' provides %ld bytes\n", *entropy_file, (long)PAGE_SIZE);
+ error = randomdev_write_file(*entropy_file, zbuf, PAGE_SIZE);
+ if (error == 0) {
+ printf("random: entropy cache '%s' contents used and successfully overwritten\n", *entropy_file);
+ for (i = 0; i < PAGE_SIZE; i += 16)
+ random_harvestq_internal(get_cyclecount(), data + i, 16, 16, RANDOM_CACHED);
+ }
+ else
+ printf("random: entropy cache '%s' not overwritten and therefore not used; error = %d\n", *entropy_file, error);
+ }
+ else
+ printf("random: entropy cache '%s' not present or unreadable; error = %d\n", *entropy_file, error);
+ }
+ bzero(data, PAGE_SIZE);
+ free(data, M_ENTROPY);
+#endif
+}
+EVENTHANDLER_DEFINE(mountroot, random_harvestq_cache, NULL, 0);
+
static void
random_kthread(void *arg)
{
STAILQ_HEAD(, harvest) local_queue;
struct harvest *event = NULL;
int local_count;
- enum esource source;
- event_proc_f func = arg;
+ event_proc_f entropy_processor = arg;
STAILQ_INIT(&local_queue);
local_count = 0;
@@ -91,26 +163,23 @@ random_kthread(void *arg)
mtx_lock_spin(&harvest_mtx);
for (; random_kthread_control >= 0;) {
- /* Cycle through all the entropy sources */
- for (source = RANDOM_START; source < ENTROPYSOURCE; source++) {
- /*
- * Drain entropy source records into a thread-local
- * queue for processing while not holding the mutex.
- */
- STAILQ_CONCAT(&local_queue, &harvestfifo[source].head);
- local_count += harvestfifo[source].count;
- harvestfifo[source].count = 0;
- }
+ /*
+ * Grab all the entropy events.
+ * Drain entropy source records into a thread-local
+ * queue for processing while not holding the mutex.
+ */
+ STAILQ_CONCAT(&local_queue, &harvestfifo.head);
+ local_count += harvestfifo.count;
+ harvestfifo.count = 0;
/*
- * Deal with events, if any, dropping the mutex as we process
- * each event. Then push the events back into the empty
- * fifo.
+ * Deal with events, if any.
+ * Then transfer the used events back into the empty fifo.
*/
if (!STAILQ_EMPTY(&local_queue)) {
mtx_unlock_spin(&harvest_mtx);
STAILQ_FOREACH(event, &local_queue, next)
- func(event);
+ entropy_processor(event);
mtx_lock_spin(&harvest_mtx);
STAILQ_CONCAT(&emptyfifo.head, &local_queue);
emptyfifo.count += local_count;
@@ -121,15 +190,24 @@ random_kthread(void *arg)
local_count));
/*
+ * Do only one round of the hardware sources for now.
+ * Later we'll need to make it rate-adaptive.
+ */
+ mtx_unlock_spin(&harvest_mtx);
+ live_entropy_sources_feed(1, entropy_processor);
+ mtx_lock_spin(&harvest_mtx);
+
+ /*
* If a queue flush was commanded, it has now happened,
* and we can mark this by resetting the command.
*/
+
if (random_kthread_control == 1)
random_kthread_control = 0;
/* Work done, so don't belabour the issue */
msleep_spin_sbt(&random_kthread_control, &harvest_mtx,
- "-", SBT_1S / 10, 0, C_PREL(1));
+ "-", SBT_1S/10, 0, C_PREL(1));
}
mtx_unlock_spin(&harvest_mtx);
@@ -143,22 +221,22 @@ random_harvestq_init(event_proc_f cb)
{
int error, i;
struct harvest *np;
- enum esource e;
/* Initialise the harvest fifos */
+
+ /* Contains the currently unused event structs. */
STAILQ_INIT(&emptyfifo.head);
- emptyfifo.count = 0;
- for (i = 0; i < EMPTYBUFFERS; i++) {
+ for (i = 0; i < RANDOM_FIFO_MAX; i++) {
np = malloc(sizeof(struct harvest), M_ENTROPY, M_WAITOK);
STAILQ_INSERT_TAIL(&emptyfifo.head, np, next);
}
- for (e = RANDOM_START; e < ENTROPYSOURCE; e++) {
- STAILQ_INIT(&harvestfifo[e].head);
- harvestfifo[e].count = 0;
- }
+ emptyfifo.count = RANDOM_FIFO_MAX;
- mtx_init(&harvest_mtx, "entropy harvest mutex", NULL, MTX_SPIN);
+ /* Will contain the queued-up events. */
+ STAILQ_INIT(&harvestfifo.head);
+ harvestfifo.count = 0;
+ mtx_init(&harvest_mtx, "entropy harvest mutex", NULL, MTX_SPIN);
/* Start the hash/reseed thread */
error = kproc_create(random_kthread, cb,
@@ -172,7 +250,6 @@ void
random_harvestq_deinit(void)
{
struct harvest *np;
- enum esource e;
/* Destroy the harvest fifos */
while (!STAILQ_EMPTY(&emptyfifo.head)) {
@@ -180,72 +257,66 @@ random_harvestq_deinit(void)
STAILQ_REMOVE_HEAD(&emptyfifo.head, next);
free(np, M_ENTROPY);
}
- for (e = RANDOM_START; e < ENTROPYSOURCE; e++) {
- while (!STAILQ_EMPTY(&harvestfifo[e].head)) {
- np = STAILQ_FIRST(&harvestfifo[e].head);
- STAILQ_REMOVE_HEAD(&harvestfifo[e].head, next);
- free(np, M_ENTROPY);
- }
+ emptyfifo.count = 0;
+ while (!STAILQ_EMPTY(&harvestfifo.head)) {
+ np = STAILQ_FIRST(&harvestfifo.head);
+ STAILQ_REMOVE_HEAD(&harvestfifo.head, next);
+ free(np, M_ENTROPY);
}
+ harvestfifo.count = 0;
mtx_destroy(&harvest_mtx);
}
/*
- * Entropy harvesting routine. This is supposed to be fast; do
- * not do anything slow in here!
+ * Entropy harvesting routine.
+ * This is supposed to be fast; do not do anything slow in here!
+ *
+ * It is also illegal (and morally reprehensible) to insert any
+ * high-rate data here. "High-rate" is define as a data source
+ * that will usually cause lots of failures of the "Lockless read"
+ * check a few lines below. This includes the "always-on" sources
+ * like the Intel "rdrand" or the VIA Nehamiah "xstore" sources.
*/
void
random_harvestq_internal(u_int64_t somecounter, const void *entropy,
- u_int count, u_int bits, u_int frac, enum esource origin)
+ u_int count, u_int bits, enum esource origin)
{
struct harvest *event;
- KASSERT(origin >= RANDOM_START && origin <= RANDOM_PURE,
+ KASSERT(origin >= RANDOM_START && origin < ENTROPYSOURCE,
("random_harvest_internal: origin %d invalid\n", origin));
/* Lockless read to avoid lock operations if fifo is full. */
- if (harvestfifo[origin].count >= RANDOM_FIFO_MAX)
+ if (harvestfifo.count >= RANDOM_FIFO_MAX)
return;
mtx_lock_spin(&harvest_mtx);
/*
- * Don't make the harvest queues too big - help to prevent low-grade
- * entropy swamping
+ * On't overfill the harvest queue; this could steal all
+ * our memory.
*/
- if (harvestfifo[origin].count < RANDOM_FIFO_MAX) {
+ if (harvestfifo.count < RANDOM_FIFO_MAX) {
event = STAILQ_FIRST(&emptyfifo.head);
if (event != NULL) {
/* Add the harvested data to the fifo */
STAILQ_REMOVE_HEAD(&emptyfifo.head, next);
- harvestfifo[origin].count++;
+ emptyfifo.count--;
event->somecounter = somecounter;
event->size = count;
event->bits = bits;
- event->frac = frac;
event->source = origin;
/* XXXX Come back and make this dynamic! */
count = MIN(count, HARVESTSIZE);
memcpy(event->entropy, entropy, count);
-#if 0
- {
- int i;
- printf("Harvest:%16jX ", event->somecounter);
- for (i = 0; i < event->size; i++)
- printf("%02X", event->entropy[i]);
- for (; i < 16; i++)
- printf(" ");
- printf(" %2d 0x%2X.%03X %02X\n", event->size, event->bits, event->frac, event->source);
- }
-#endif
-
- STAILQ_INSERT_TAIL(&harvestfifo[origin].head,
+ STAILQ_INSERT_TAIL(&harvestfifo.head,
event, next);
+ harvestfifo.count++;
}
}
+
mtx_unlock_spin(&harvest_mtx);
}
-
View
9 sys/dev/random/random_harvestq.h
@@ -26,16 +26,17 @@
* $FreeBSD$
*/
-#ifndef __RANDOM_HARVEST_H__
-#define __RANDOM_HARVEST_H__
+#ifndef SYS_DEV_RANDOM_RANDOM_HARVESTQ_H_INCLUDED
+#define SYS_DEV_RANDOM_RANDOM_HARVESTQ_H_INCLUDED
typedef void (*event_proc_f)(struct harvest *event);
void random_harvestq_init(event_proc_f);
void random_harvestq_deinit(void);
void random_harvestq_internal(u_int64_t, const void *,
- u_int, u_int, u_int, enum esource);
+ u_int, u_int, enum esource);
extern int random_kthread_control;
+extern struct mtx harvest_mtx;
-#endif /* __RANDOM_HARVEST_H__ */
+#endif /* SYS_DEV_RANDOM_RANDOM_HARVESTQ_H_INCLUDED */
View
76 sys/dev/random/randomdev.c
@@ -1,6 +1,6 @@
/*-
+ * Copyright (c) 2000-2013 Mark R V Murray
* Copyright (c) 2013 Arthur Mesh <arthurmesh@gmail.com>
- * Copyright (c) 2000-2004 Mark R V Murray
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -44,6 +44,7 @@ __FBSDID("$FreeBSD$");
#include <sys/poll.h>
#include <sys/priv.h>
#include <sys/proc.h>
+#include <sys/random.h>
#include <sys/selinfo.h>
#include <sys/uio.h>
#include <sys/unistd.h>
@@ -51,12 +52,14 @@ __FBSDID("$FreeBSD$");
#include <machine/bus.h>
#include <machine/cpu.h>
-#include <dev/random/random_adaptors.h>
#include <dev/random/randomdev.h>
+#include <dev/random/randomdev_soft.h>
+#include <dev/random/random_adaptors.h>
+#include <dev/random/random_harvestq.h>
+#include <dev/random/live_entropy_sources.h>
#define RANDOM_MINOR 0
-static d_close_t random_close;
static d_read_t random_read;
static d_write_t random_write;
static d_ioctl_t random_ioctl;
@@ -64,7 +67,6 @@ static d_poll_t random_poll;
static struct cdevsw random_cdevsw = {
.d_version = D_VERSION,
- .d_close = random_close,
.d_read = random_read,
.d_write = random_write,
.d_ioctl = random_ioctl,
@@ -72,29 +74,11 @@ static struct cdevsw random_cdevsw = {
.d_name = "random",
};
-static eventhandler_tag attach_tag;
-static int random_inited;
-
/* For use with make_dev(9)/destroy_dev(9). */
static struct cdev *random_dev;
/* ARGSUSED */
static int
-random_close(struct cdev *dev __unused, int flags, int fmt __unused,
- struct thread *td)
-{
- if ((flags & FWRITE) && (priv_check(td, PRIV_RANDOM_RESEED) == 0)
- && (securelevel_gt(td->td_ucred, 0) == 0)) {
- (*random_adaptor->reseed)();
- random_adaptor->seeded = 1;
- arc4rand(NULL, 0, 1); /* Reseed arc4random as well. */
- }
-
- return (0);
-}
-
-/* ARGSUSED */
-static int
random_read(struct cdev *dev __unused, struct uio *uio, int flag)
{
int c, error = 0;
@@ -107,15 +91,18 @@ random_read(struct cdev *dev __unused, struct uio *uio, int flag)
/* The actual read */
if (!error) {
- random_buf = (void *)malloc(PAGE_SIZE, M_TEMP, M_WAITOK);
+ random_buf = (void *)malloc(PAGE_SIZE, M_ENTROPY, M_WAITOK);
while (uio->uio_resid > 0 && !error) {
c = MIN(uio->uio_resid, PAGE_SIZE);
c = (*random_adaptor->read)(random_buf, c);
error = uiomove(random_buf, c, uio);
}
+ /* Finished reading; let the source know so it can do some
+ * optional housekeeping */
+ (*random_adaptor->read)(NULL, 0);
- free(random_buf, M_TEMP);
+ free(random_buf, M_ENTROPY);
}
@@ -126,22 +113,16 @@ random_read(struct cdev *dev __unused, struct uio *uio, int flag)
static int
random_write(struct cdev *dev __unused, struct uio *uio, int flag __unused)
{
- int c, error = 0;
- void *random_buf;
-
- random_buf = (void *)malloc(PAGE_SIZE, M_TEMP, M_WAITOK);
-
- while (uio->uio_resid > 0) {
- c = MIN((int)uio->uio_resid, PAGE_SIZE);
- error = uiomove(random_buf, c, uio);
- if (error)
- break;
- (*random_adaptor->write)(random_buf, c);
- }
- free(random_buf, M_TEMP);
+ /* We used to allow this to insert userland entropy.
+ * We don't any more because (1) this so-called entropy
+ * is usually lousy and (b) its vaguely possible to
+ * mess with entropy harvesting by overdoing a write.
+ * Now we just ignore input like /dev/null does.
+ */
+ uio->uio_resid = 0;
- return (error);
+ return (0);
}
/* ARGSUSED */
@@ -172,7 +153,7 @@ random_poll(struct cdev *dev __unused, int events, struct thread *td)
if (random_adaptor->seeded)
revents = events & (POLLIN | POLLRDNORM);
else
- revents = (*random_adaptor->poll) (events,td);
+ revents = (*random_adaptor->poll)(events, td);
}
return (revents);
}
@@ -180,6 +161,8 @@ random_poll(struct cdev *dev __unused, int events, struct thread *td)
static void
random_initialize(void *p, struct random_adaptor *s)
{
+ static int random_inited = 0;
+
if (random_inited) {
printf("random: <%s> already initialized\n",
random_adaptor->ident);
@@ -192,9 +175,11 @@ random_initialize(void *p, struct random_adaptor *s)
printf("random: <%s> initialized\n", s->ident);
+ /* Use an appropriately evil mode for those who are concerned
+ * with daemons */
random_dev = make_dev_credf(MAKEDEV_ETERNAL_KLD, &random_cdevsw,
RANDOM_MINOR, NULL, UID_ROOT, GID_WHEEL, 0666, "random");
- make_dev_alias(random_dev, "urandom"); /* XXX Deprecated */
+ make_dev_alias(random_dev, "urandom"); /* compatibility */
/* mark random(4) as initialized, to avoid being called again */
random_inited = 1;
@@ -204,6 +189,7 @@ random_initialize(void *p, struct random_adaptor *s)
static int
random_modevent(module_t mod __unused, int type, void *data __unused)
{
+ static eventhandler_tag attach_tag = NULL;
int error = 0;
switch (type) {
@@ -211,13 +197,12 @@ random_modevent(module_t mod __unused, int type, void *data __unused)
random_adaptor_choose(&random_adaptor);
if (random_adaptor == NULL) {
- printf(
- "random: No random adaptor attached, postponing initialization\n");
+ printf("random: No random adaptor attached, "
+ "postponing initialization\n");
attach_tag = EVENTHANDLER_REGISTER(random_adaptor_attach,
random_initialize, NULL, EVENTHANDLER_PRI_ANY);
- } else {
+ } else
random_initialize(NULL, random_adaptor);
- }
break;
@@ -227,10 +212,9 @@ random_modevent(module_t mod __unused, int type, void *data __unused)
destroy_dev(random_dev);
}
/* Unregister the event handler */
- if (attach_tag != NULL) {