Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/BLD: switch to entry points for scripts #6

Merged
merged 5 commits into from
Mar 17, 2020
Merged

CI/BLD: switch to entry points for scripts #6

merged 5 commits into from
Mar 17, 2020

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Mar 17, 2020 •
edited
Loading

hhslepicka
hhslepicka reviewed Mar 17, 2020
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
hhslepicka
hhslepicka reviewed Mar 17, 2020
View reviewed changes
setup.py
Comment on lines +18 to +21
"console_scripts": [
"QSGenerateExcelSpreadSheet.py=psdm_qs_cli.QSGenerateExcelSpreadSheet:main",
"QSGenerateJSON.py=psdm_qs_cli.QSGenerateJSON:main",
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could track down who is using the scripts we could probably switch them to remove the .py at the name?
This is just aesthetics... feel free to ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd consider this back-compat. No clue who is using these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we better keep the same name! 😉

hhslepicka
hhslepicka suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@hhslepicka hhslepicka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor findings...
While you are here, do you mind to already address the following:

  • Add LICENSE to the MANIFEST.in
  • Add requirements.txt to the MANIFEST.in (otherwise pip install will fail if using the package)

@klauer
Copy link
Contributor Author

klauer commented Mar 17, 2020

Done, thanks!

@hhslepicka hhslepicka merged commit fab60cb into pcdshub:master Mar 17, 2020
@klauer klauer deleted the entry_points branch March 17, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhslepicka hhslepicka hhslepicka approved these changes

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klauer @hhslepicka @ZLLentz