Commits on May 28, 2019

  1. src/arch/x86: Add automatic type41 entry creation

    SMBIOS Type41 Entries will be automatically created. Type 41 entries
    define attributes of the onboard devices.
    
    Change-Id: Idcb3532a5c05666d6613af4f303df85f4f1f6e97
    Signed-off-by: Christian Walter <christian.walter@9elements.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32910
    Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
    Reviewed-by: Patrick Rudolph <siro@das-labor.org>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    walterchris authored and zaolin committed May 28, 2019
    Copy the full SHA
    9e5b062 View commit details
    Browse the repository at this point in the history
  2. mb/google/sarien: Fix SSD power leakage in S5

    Turn off SSD power in S5.
    
    BUG=b:133389422
    TEST=measure H13 is low in S5
    
    Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
    Change-Id: I40b5381cac33b0eac962a7730ee5c57e60e6d375
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32952
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
    EricRLai authored and Duncan Laurie committed May 28, 2019
    Copy the full SHA
    63cba97 View commit details
    Browse the repository at this point in the history
  3. mb/google/sarien: Modify SSD power sequence

    Due to we turn off SSD power in S5. CB:32952
    Based on M2 spec we have to turn on SSD power
    before RST assert.
    
    BUG=b:133389422
    TEST=verify warm boot and cold boot are boot
    successfully.
    
    Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
    Change-Id: I5b78bab4be675bbb8795361bcfa5af52cb54bb1e
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33029
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
    EricRLai authored and Duncan Laurie committed May 28, 2019
    Copy the full SHA
    48b2ada View commit details
    Browse the repository at this point in the history
  4. soc/intel/cannonlake: Dump ME status info before notify EndOfFirmware

    Dumping ME status displays wrong information if we disable Heci1 because
    it is called after fsp notifies EndOfFirmware and disables Heci1. This patch
    moves the ME status dump before fsp notify EndOfFirmware.
    
    TEST=Boot to OS, check ME dump information
    
    Change-Id: Ifd8b18a41c502c4ecfb84698a7669028394589fd
    Signed-off-by: Bora Guvendik <bora.guvendik@intel.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32991
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Subrata Banik <subrata.banik@intel.com>
    Reviewed-by: Furquan Shaikh <furquan@google.com>
    Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
    bguvendi authored and Duncan Laurie committed May 28, 2019
    Copy the full SHA
    9637856 View commit details
    Browse the repository at this point in the history
  5. util/xcompile/xcompile: apply -march to clang as well as gcc

    For x64 and x86_32 configurations, apply the -march flag to both GCC and
    Clang flags.
    
    This solves the problem of Clang-compiled coreboot failing due to Clang
    emitting SSE instructions for code that is executed while SSE is not
    enabled.
    
    This patch takes functionality targeted for GCC configurations and moves
    it down a few lines, modifying CFLAGS instead of GCC_CFLAGS in order
    that it applies to both GCC and Clang.
    
    This is an alternate patch to CB:32887.
    
    Signed-off-by: Alan Green <avg@google.com>
    Change-Id: I6a6a6136b01a64d46f730ed19ebbeaadaf2183df
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32923
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    alanvgreen authored and pgeorgi committed May 28, 2019
    Copy the full SHA
    1470c73 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. drivers/intel/fsp2_0: Fix typo mistake

    Change-Id: I90f595d7d789429c8717261c6edb6c756f6c0e1f
    Signed-off-by: Subrata Banik <subrata.banik@intel.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33056
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
    Reviewed-by: Aamir Bohra <aamir.bohra@intel.com>
    subrata-b committed May 29, 2019
    Copy the full SHA
    ab032b8 View commit details
    Browse the repository at this point in the history
  2. nb/intel/nehalem: Call smm_region_start() function

    This also removes the unnecessary mask.
    
    TEST: X201 Boots again.
    
    Change-Id: Ia637bd01cd7dc1aecd1a87a739d5243c70419553
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33046
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    Reviewed-by: Nico Huber <nico.h@gmx.de>
    ArthurHeymans committed May 29, 2019
    Copy the full SHA
    23fbd05 View commit details
    Browse the repository at this point in the history
  3. mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint vari…

    …ants
    
    Even fingerprint device probe failed on non-fingerpint boards,the CRFP driver
    still register the device that cause the GPE#1 as wake source every time.
    Override devicetree for non-fingerpirnt variants to avoid unexpected wake
    event(GPE#1).
    
    BUG=b:129650040
    BRANCH=firmware-nami-10775.108.B
    TEST=Boots to OS and check no GPE#1 wake event from eventlog when S0ix exit.
    
    Signed-off-by: Ivy Jian <ivy_jian@compal.corp-partner.google.com>
    Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33017
    Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
    Reviewed-by: John Su <john_su@compal.corp-partner.google.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Ivy-Jian authored and furquan-goog committed May 29, 2019
    Copy the full SHA
    b80d132 View commit details
    Browse the repository at this point in the history
  4. arch/x86: Do not add properties to null DP packages

    It doesn't make sense to add a property to a non-existent Device
    Property package. However, some of these functions will proceed anyway
    and allocate a new Device Property package, add the property to
    that, and then immediately leak the new package. This changes all the
    acpi_dp_add_* functions to ignore a null package.
    
    Change-Id: I664dcdbaa6b1b8a3aeb9a0126d622e2ffb736efd
    Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
    Found-by: Coverity CID 135745{6,7}, 138029{2-6}
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32971
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Furquan Shaikh <furquan@google.com>
    Jacob Garber authored and Martin Roth committed May 29, 2019
    Copy the full SHA
    c30e590 View commit details
    Browse the repository at this point in the history
  5. mb/google/sarien: Send post code to the EC

    Use the mainboard post code hook to inform the wilco EC driver of the
    every stage.
    
    BUG=b:124401932,b:133466714,b:133600566
    BRANCH=sarien
    TEST=Remove DIMM module, confirm diagnostic LED pattern for memory
    failure (2 amber, 4 white).
    
    Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
    Signed-off-by: Duncan Laurie <dlaurie@google.com>
    Change-Id: Ic71e4a6e62b63ca2fd189957c4d6f49b61b934de
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33047
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
    Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
    Reviewed-by: Furquan Shaikh <furquan@google.com>
    EricRLai authored and furquan-goog committed May 29, 2019
    Copy the full SHA
    702f838 View commit details
    Browse the repository at this point in the history
  6. Documentation: Warn about ME cleaner on Sandy Bridge

    Document known issues with 'disabled' ME.
    
    Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e
    Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32889
    Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    PatrickRudolph authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    edbcd05 View commit details
    Browse the repository at this point in the history
  7. mb/gigabyte/ga-b75m-d3{h,v}: Switch to variant setup

    The Gigabyte GA-B75M-D3H/D3V mainboard trees share a lot of duplicate
    code, and can serve as a base for porting other Gigabyte 7 series
    motherboards. Switch the Gigabyte GA-B75M-D3H/D3V mainboard trees to a
    variant setup, defining ga-b75m-d3v as a variant of ga-b75m-d3h.
    
    Signed-off-by: Alex James <theracermaster@gmail.com>
    Change-Id: Ia175207a2568aefe1aa9bd8d4d990de6a26f1657
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32708
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    al3xtjames authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    1bffc4b View commit details
    Browse the repository at this point in the history
  8. intel/sandybridge: Make timC training more robust.

    When using native raminit with https://review.coreboot.org/#/c/22683/
    I've found that timC training usually fails unless the ram is
    overspecced (i.e. DDR3L-1600 rated for 1.35V works most of the time with
    native raminit as DDR3-1333 @1.5V).
    
    Looking at the training data I've found that during timC training it is
    reading register values in the 0-4000 range and checking for runs of 0,
    but with the failing training the values don't go all the way down to 0.
    The solution for me has been to do a thresholing pre-pass, after which
    both the DDR3-1333 @1.5V and the DDR3L-1600 @1.35V work fine for me.
    
    Tested:
    - Intel NUC DCP847SKE
    - RAM slots with 2x4GB Kingston KVR1333D3S9/4G (DDR3-1333 1.5V),
      boots fine with native raminit @1.5V
    - RAM slots with 2x4GB Kingston KVR16LS11/4G (DDR3L-1600 1.35V),
      boots fine with native raminit @1.35V
    - Casual use with these settings
    - Tested on Lenovo T520 with Crucial HyperX DDR3-1833.
    - Memtest86+ stable.
    
    Change-Id: I9986616e86560c4980ccd8e3e549af53caa15c71
    Signed-off-by: Tobias Diedrich <ranma+coreboot@tdiedrich.de>
    Signed-off-by: Patrick Rudolph <siro@das-labor.org>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/22776
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
    ranma authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    87c4f11 View commit details
    Browse the repository at this point in the history
  9. soc/intel/apollolake: Don't use CAR_GLOBAL

    All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: I0f393385aa94f18c2e05af3b5a54999575323d18
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/30510
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    6d6945b View commit details
    Browse the repository at this point in the history
  10. Clean up unused arch/early_variables.h header

    Change-Id: Ib863e23863ba6d7504b6c4d32de2f1fea4e57fec
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32996
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    8a1b94c View commit details
    Browse the repository at this point in the history
  11. soc/intel/braswell: Don't use CAR_GLOBAL

    Now that this soc supports NO_CAR_GLOBAL_MIGRATION CAR_GLOBAL and
    car_get/set_x are not needed anymore.
    
    Change-Id: Ia7fa97135a4b376ac0bd8b30093a77614cc2cf55
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32997
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    00295aa View commit details
    Browse the repository at this point in the history
  12. intel/quark/storage_test.h: Drop external variable declaration

    These are only used where they are initially declared.
    
    Change-Id: I0a81a945b771b6c29a170c479b9e72c98e8f3c5a
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33022
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    6e11908 View commit details
    Browse the repository at this point in the history
  13. soc/intel/quark: Don't use CAR_GLOBAL

    This soc has NO_CAR_GLOBAL_MIGRATION and does not require CAR_GLOBAL
    and car_get/set_x.
    
    Change-Id: I4e2c1c5766e3bcdd4763b42fb925074f7ccd7002
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32998
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    84e22e3 View commit details
    Browse the repository at this point in the history
  14. soc/intel/common/gspi: Don't use CAR_GLOBAL

    All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: I5dfbc718fd82f0511b0049383e4e93c6f15ee932
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32999
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    9456d60 View commit details
    Browse the repository at this point in the history
  15. drivers/emulation/qemu_debugcon: Don't use CAR_GLOBAL

    This platform uses NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: Idc9434e5a1a8bc5ed76a9f80c9a7cfba2fd474c0
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33000
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    4a402fe View commit details
    Browse the repository at this point in the history
  16. soc/intel/common/cse: Declare g_cse statically

    Change-Id: I91b6ce3b52d987e2fc0f79e550fda2891502bfe8
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33023
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Furquan Shaikh <furquan@google.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    3d6ccd0 View commit details
    Browse the repository at this point in the history
  17. soc/intel/common/cse: Don't use CAR_GLOBAL

    All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: If952ad8129e1fa6e45858cb77ec99c9fec55c4a6
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33001
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    a5eed80 View commit details
    Browse the repository at this point in the history
  18. soc/intel/common/pmc: Don't use CAR_GLOBAL

    All platforms using this code use NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: I426dee60521045db4711cd253432c65223a64b93
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33002
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    ea6dd74 View commit details
    Browse the repository at this point in the history
  19. drivers/intel/fsp2_0: Dont' use CAR_GLOBAL

    All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
    
    Change-Id: Ic50b16916261abb8c63b8fe571819af5c830ff8d
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33003
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    75c2015 View commit details
    Browse the repository at this point in the history
  20. util/autoport: Add info about rank 1 mirroring

    inteltool can't detect whether address mapping is normal or
    mirrored, which in turn may be cause RAM initialization to
    fail when using spd.bin generated by inteltool.
    
    Mention this in readme as it may help someone.
    
    Change-Id: I8d24e4d9332bdcf484987581dd6941e2bf9c4f87
    Signed-off-by: Evgeny Zinoviev <me@ch1p.io>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32683
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    gch1p authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    3d90d3b View commit details
    Browse the repository at this point in the history
  21. soc/intel/common: Set GSPI clock value to prevent division by zero

    Clang Static Analyzer version 8.0.0 detects the division by zero if
    gspi_clk_mhz is initialized to 0. gspi_clk_mhz is referred to speed_mhz
    in devicetree. Set gspi_clk_mhz to 1 if it is detected as 0 in order to
    prevent the division by zero in DIV_ROUND_UP operation. Then the value
    of (ref_clk_mhz - 1) will be fed into GSPI's Serial Clock Rate value.
    
    TEST=Built and boot up to kernel.
    
    Change-Id: I6a09474bff114c57d7a9c4c232bb636ff287e4d5
    Signed-off-by: John Zhao <john.zhao@intel.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32974
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
    jzhao80 authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    64fb5aa View commit details
    Browse the repository at this point in the history
  22. soc/intel/common: Check bios_size and window_size after MIN operation

    Clang Static Analyzer version 8.0.0 detects that log2_ceil(bios_size)
    and log2_ceil(window_size) are garbage or undefined if the value of
    bios_size and window_size is zero. Check bios_size and window_size after
    MIN operation to prevent error.
    
    TEST=Built and boot up to kernel.
    
    Change-Id: Ifc3f3da52d129ef5d6063a46b045603a236be759
    Signed-off-by: John Zhao <john.zhao@intel.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32924
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
    jzhao80 authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    2bb432e View commit details
    Browse the repository at this point in the history
  23. sb/intel/*: Delete early_spi

    The file and all of it's functions are unused. Drop the dead code.
    
    Change-Id: Iaddd7a688d431d40f38293939e084d19b286aed4
    Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32688
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
    Reviewed-by: David Guckian
    Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
    PatrickRudolph authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    6336ee6 View commit details
    Browse the repository at this point in the history
  24. soc/intel/apollolake: Fix value stored to gnvs is never read

    Clang Static Analyzer found version 8.0.0 gnvs is allocated, but
    it is never used. Change sizeof(*gnvs) to sizeof(global_nvs_t)
    while adding ACPI GNVS to CBMEM.
    
    TEST=Built and boot up to kernel.
    
    Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
    Signed-off-by: John Zhao <john.zhao@intel.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32903
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
    jzhao80 authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    5744884 View commit details
    Browse the repository at this point in the history
  25. Makefile.inc: Extend version string for timeless builds

    With the version string "TIMELESS", binaries are slightly smaller than
    for a regular build. This may lead to false positive build tests if the
    space is limited (e.g. bootblock). So let's make the string a little
    longer.
    
    Change-Id: I3bbf6f71d5bcd74728a3fe39734312690901d0ec
    Signed-off-by: Nico Huber <nico.huber@secunet.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32986
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    n-huber authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    342d318 View commit details
    Browse the repository at this point in the history
  26. mb/google/{misc}: set default SMBIOS manufacturer

    Legacy Google mainboards (pre-Skylake) shipped with the
    SMBIOS manufacturer set to GOOGLE, which many Linux drivers
    rely on for application of DMI quirks. Set it as the default
    to avoid having to do so for each board's config
    
    Change-Id: I61b0217f3535852d7d6e24a1ac78075c20c0825a
    Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33027
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Nico Huber <nico.h@gmx.de>
    MrChromebox authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    348a44e View commit details
    Browse the repository at this point in the history
  27. google/clapper: fix up devicetree

    When clapper was upstreamed, the devicetree was pulled from
    the wrong firmware branch, leading to some incorrect settings
    and touchpad, touchscreen, and audio not working.
    
    Correct devicetree settings using Chromium branch firmware-clapper-5216.199.B
    
    Test: build/boot google/clapper, verify touchpad/touchscreen/audio
    functional under Linux (GalliumOS 3.0/kernel 4.16.18).
    
    Change-Id: Iacfce575a054b1f484149f36d0aa83d20d034d8a
    Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33025
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
    MrChromebox authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    924463d View commit details
    Browse the repository at this point in the history
  28. drivers/generic/max98357a: Add extra error handling

    It is possible that acpi_device_scope() and acpi_device_name() can
    return NULL to indicate an error, so add error handling to check their
    return values.
    
    Change-Id: I4c7ab0c592845d9d5f142e078fc2b505a99ecd12
    Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
    Found-by: Coverity CID 1362592
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33028
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Furquan Shaikh <furquan@google.com>
    Jacob Garber authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    bdcb4d3 View commit details
    Browse the repository at this point in the history
  29. cpu/x86/mtrr: Assert that MSR arrays are fully initialized

    The initialization logic for the fixed_msrs and msr_index arrays depends
    on the contents of the fixed MTRR descriptor. However, Coverity is unable
    to check these values and believes (incorrectly) that the arrays may not
    be entirely initialized. An assert was added in commit b28025a to
    ensure that one of the loops is entered, but it is simplest to just
    check that msr_num has iterated over the entire array after the loops
    are over. This also acts as a sanity check that the values in the MTRR
    descriptor were hardcoded correctly.
    
    Change-Id: Ia573792f74aa6ea5e659c1e2253f112184fbb0a5
    Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
    Found-by: Coverity CID 1370582
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33048
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lance Zhao <lance.zhao@gmail.com>
    Jacob Garber authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    5b92272 View commit details
    Browse the repository at this point in the history
  30. commonlib: renumber CB_TAG_TCPA_LOG

    It conflicts with VBOOT_WORKBUF but unlike VBOOT_WORKBUF no user can be
    identified in the coreboot tree for TCPA_LOG, so renumber this.
    
    Change-Id: Ib8a850c0ccbcacdf7d288316b54eb82fce874a82
    Signed-off-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32955
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Patrick Rudolph <siro@das-labor.org>
    pgeorgi committed May 29, 2019
    Copy the full SHA
    3f4a987 View commit details
    Browse the repository at this point in the history
  31. commonlib: fix typo LB_TAB_* (instead of LB_TAG_*)

    Also adapt all users of these symbols
    
    Change-Id: Ibf924a283d438de49a93ce661b0d9ca1a81cd6d1
    Signed-off-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32956
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Patrick Rudolph <siro@das-labor.org>
    pgeorgi committed May 29, 2019
    Copy the full SHA
    68999a8 View commit details
    Browse the repository at this point in the history
  32. src/drivers/xgi: Move coreboot related includes to xgi_coreboot.h

    Change-Id: Ia18c77876121594a272a07d56acfaa863d0ccb25
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/29307
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    e955fa3 View commit details
    Browse the repository at this point in the history
  33. soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset

    ASL compiler reports twice warning 'unnecessary/redundant use of Offfset operator'.
    
    Remove redundant offsets.
    
    BUG=N/A
    TEST=Facebook FBG-1701 booting Embedded Linux
    
    Change-Id: I16705b9392b17c50d3988012406e03de393cbcd2
    Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32953
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
    FransHendriks authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    1ac5ecb View commit details
    Browse the repository at this point in the history
  34. drivers/intel/fsp1.1: Simplify bootflow and clean up

    This gets rid of the boilerplate back and forward calls between the
    SOC/FSP-driver code and mainboard code.
    
    Change-Id: I5d4a10d1da6b3ac5e65efd7f82607b56b80e08d4
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32961
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    73ac121 View commit details
    Browse the repository at this point in the history
  35. soc/intel/skylake: Use common cpu/intel/car romstage code

    Setting up the console and entering postcar can be done in a common
    place.
    
    Change-Id: I8a8db0fcb4f0fbbb121a8195a8a8b6644c28db07
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32962
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    56e2d7d View commit details
    Browse the repository at this point in the history
  36. payloads/external/iPXE: Add more Kconfig options

    Add two new options:
    * Disable the prompt "Press Ctrl+B for the iPXE command line..."
    Add a boolean that disables the initial 2 second timeout.
    
    * Include a script that is executed instead of showing a shell.
    Allows to add a script that will be included into the iPXE ROM.
    
    Tested on Lenovo T500 and PC Engines apu2.
    
    Change-Id: Ie1083d8571d9d1f1c7c71659fb6ff0de2eecad0e
    Signed-off-by: Patrick Rudolph <siro@das-labor.org>
    Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/20782
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    siro20 authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    23cb12b View commit details
    Browse the repository at this point in the history
  37. src/soc/intel/skylake/chip.h: Add smbios.h for Type9 Entries

    In order to add the smbios_slot_desc for the SMBIOS Type9 entries into
    the devicetree, and not use numbers but strings like
    "SlotTypePciExpressGen3X4", smbios.h needs to be included in the
    static.c.
    
    Change-Id: Iace547868b4ce8eb7d3624baf1abd1187c1e5f51
    Signed-off-by: Christian Walter <christian.walter@9elements.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32965
    Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    walterchris authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    a998e28 View commit details
    Browse the repository at this point in the history
  38. payloads/external/Linuxboot: Fix Makefile when not using bash

    Adding "SHELL := /bin/bash" to the Makefile makes sure, that we use the
    bash shell which is needed here.
    
    Tested with oh-my-zsh.
    
    Change-Id: I71495e15b8f1a495af7d8ab21cc5235feb595e01
    Signed-off-by: Christian Walter <christian.walter@9elements.com>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/33014
    Reviewed-by: Patrick Georgi <pgeorgi@google.com>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    walterchris authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    543be8d View commit details
    Browse the repository at this point in the history
  39. soc/intel/denverton_ns: Don't use CONFIG_CBFS_SIZE

    CONFIG_CBFS_SIZE is only meaningful to generate the default fmap
    layout and ought not to be used in the code directly.
    
    Change-Id: Iae72a9fb02d62d7548d34689f5eb371f34cd3d81
    Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/31249
    Reviewed-by: Angel Pons <th3fanbus@gmail.com>
    Reviewed-by: David Guckian
    Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
    Reviewed-by: Nico Huber <nico.h@gmx.de>
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    ArthurHeymans authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    62c0b61 View commit details
    Browse the repository at this point in the history
  40. src/{include,arch,cpu,lib}: Add missing 'include <types.h>'

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: I57aead27806e307b9827fc7ee2cd663f12ee6e5e
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/31892
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    b12ece9 View commit details
    Browse the repository at this point in the history
  41. src/{device,drivers}: Add missing 'include <types.h>'

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: I3395715f9e2b03175089186ab2e57d9e508fc87c
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32806
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    bd1683d View commit details
    Browse the repository at this point in the history
  42. src/{ec,vendorcode}: Add missing 'include <types.h>

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: I1eb4163fb36a47b584f1fc9dd3c012e2930e9866
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32807
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    5fd93e0 View commit details
    Browse the repository at this point in the history
  43. src/northbridge: Add missing 'include <types.h>'

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    When <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: Iad5367bed844b866b2ad87639eee29a16d9a99ed
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32808
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    51401c3 View commit details
    Browse the repository at this point in the history
  44. src/southbridge: Add missing 'include <types.h>'

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    When <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: I4d8628e4ce3c7f80da2590b4cad618b290e0d513
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32809
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    ab89edb View commit details
    Browse the repository at this point in the history
  45. src/soc: Add missing 'include <types.h>'

    <types.h> is supposed to provide <stdint.h> and <stddef.h>.
    When <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
    
    Change-Id: I2db0a647bc657a3626cb5e78f23e9198e290261a
    Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/32810
    Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
    ElyesH authored and pgeorgi committed May 29, 2019
    Copy the full SHA
    27d02d8 View commit details
    Browse the repository at this point in the history