Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent_dirs and OpenBSD support #1

Merged
merged 4 commits into from
Aug 13, 2018
Merged

add parent_dirs and OpenBSD support #1

merged 4 commits into from
Aug 13, 2018

Conversation

trefzer
Copy link
Contributor

@trefzer trefzer commented Aug 13, 2018

OpenBSD does not create the parent directory, so a made two patches ...

@pcfens
Copy link
Owner

pcfens commented Aug 13, 2018

Thanks for adding this - other than lint issues (which it looks like you just fixed), most of the failing tests are because I haven't kept them up to date.

I'm guessing that there are just a few syntax errors in tests to clean up too, but if that's on my end just let me know and I'll try to clean them up.

Thanks again!

@trefzer
Copy link
Contributor Author

trefzer commented Aug 13, 2018

I let you know when I'm finished my part ;)

@trefzer
Copy link
Contributor Author

trefzer commented Aug 13, 2018

seems to be ok know for my part.
you like me to create a proper merge request without the to 'fix' commits ?

@pcfens pcfens merged commit 6ebe983 into pcfens:master Aug 13, 2018
@pcfens
Copy link
Owner

pcfens commented Aug 13, 2018

Not a problem at all - I squashed everything down as part of the merge.

I'll try to get a new release on the forge shortly.

@trefzer
Copy link
Contributor Author

trefzer commented Aug 13, 2018

great thanks !

@trefzer trefzer deleted the dev_cirrax branch August 13, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants