fact factory, OS and Puppet support and testing improved #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplifies the necessary hiera structure enable to manage the removal of facts
logical ordering
Puppet-6 support Debian-8 acceptance tests Debian-9 acceptance tests
pcfens
reviewed
Nov 20, 2018
|
Thanks for making some great improvements. I only have one question about dropping the create_resources function, but that's over in the code itself. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new factory does not involve create_resources any more and simplifies the necessary hiera structure.
Coverage of spec tests has been improved. Support for Puppet-6 and Debian added. Acceptance tests have been improved and enabled for centos-7, debian-8 and debian-9.