Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUnisubs GH-495 - Add support for Silesian : szl #3
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jdragojevic
Sep 24, 2013
Contributor
Tested this and just adding the language code seems fine, displays and doesn't cause any issues. However in unisubs-integration, https://github.com/pculture/unisubs-integration/commits/master/ted/__init__.py we have some TED-specific language code mappings.
Do we need to add an entry in there for Silesian.
cc. @bendk
here's the ticket for reference: pculture/unisubs#495
|
Tested this and just adding the language code seems fine, displays and doesn't cause any issues. However in unisubs-integration, https://github.com/pculture/unisubs-integration/commits/master/ted/__init__.py we have some TED-specific language code mappings. Do we need to add an entry in there for Silesian. cc. @bendk here's the ticket for reference: pculture/unisubs#495 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Sep 25, 2013
Contributor
The previous language added at Unilangs isn't added to this list (Scots, "sco"). The one before that isn't too (Flemish, "vls").
|
The previous language added at Unilangs isn't added to this list (Scots, "sco"). The one before that isn't too (Flemish, "vls"). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jdragojevic
Sep 26, 2013
Contributor
Thanks for checking on that @marcussaad. Also did some tests with the TED api and verified that we can retrieve szl data via requests api2/ted ...
This is ready to merge.
|
Thanks for checking on that @marcussaad. Also did some tests with the TED api and verified that we can retrieve szl data via requests api2/ted ... This is ready to merge. |
added a commit
that referenced
this pull request
Sep 27, 2013
marcussaad commentedSep 20, 2013
Introduced ISO 639-3 "szl" code for Silesian language.