Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew website design #1146
Comments
ghost
assigned
marcussaad
Jan 5, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 5, 2014
Contributor
Will we be adding translations for this already? Taking a general look on our current layout, it has markups for translations. should I do the same for the new phrases?
Also, when changing header and footer, should I leave the announcements that appear on top?
There are several things that will be touched/damaged with this new layout
|
Will we be adding translations for this already? Taking a general look on our current layout, it has markups for translations. should I do the same for the new phrases? Also, when changing header and footer, should I leave the announcements that appear on top? There are several things that will be touched/damaged with this new layout |
added a commit
that referenced
this issue
Jan 5, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jdragojevic
Jan 7, 2014
Contributor
- I see this error when I try to run compile_media on the branch
Traceback (most recent call last):
File "/opt/apps/unisubs/manage.py", line 50, in <module>
execute_manager(settings)
File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 459, in execute_manager
utility.execute()
File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 382, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 196, in run_from_argv
self.execute(*args, **options.__dict__)
File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
output = self.handle(*args, **options)
File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 564, in handle
self._compile_media_bundles(restrict_bundles, args)
File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 482, in _compile_media_bundles
bundle_name, data['type'], data["files"])
File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 366, in compile_media_bundle
getattr(self, "compile_%s_bundle" % bundle_type)(bundle_name, files)
File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 173, in compile_css_bundle
open(f).read()
IOError: [Errno 2] No such file or directory: '/opt/apps/unisubs/media/css/html.css'
- large banner (We <3 subtitles) displays on all pages.
msaad: Should be fixed - watch page styling is messed up, language pulldowns don't work.
|
added a commit
that referenced
this issue
Jan 7, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 7, 2014
Contributor
This is not going to be an easy or fast process and I'll let you guys know why so that we can think what to do.
Touching the file base.html which includes Header, footer and where other templating blocks are included is problematic. These new changes broke all the css from other pages, because div ids changed, div classes changed and also parent nodes.
A css that was applied using body #main #wrapper won't work any more because the structure changed to something else, Ex: body #wrapper. It isn't that simple in our case, but to illustrate what is happening it serves the purpose.
The result of this problem?
This will demand long and extensive css fixing, and currently we have more than 46 css files.
Ideas?
|
This is not going to be an easy or fast process and I'll let you guys know why so that we can think what to do. Touching the file base.html which includes Header, footer and where other templating blocks are included is problematic. These new changes broke all the css from other pages, because div ids changed, div classes changed and also parent nodes. A css that was applied using body #main #wrapper won't work any more because the structure changed to something else, Ex: body #wrapper. It isn't that simple in our case, but to illustrate what is happening it serves the purpose. The result of this problem? This will demand long and extensive css fixing, and currently we have more than 46 css files. Ideas? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
commented
Jan 7, 2014
|
We might need sylvain's help on this... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jdragojevic
Jan 7, 2014
Contributor
Is it possible to make the home page use a separate css file and leave the rest of the site as-is?
|
Is it possible to make the home page use a separate css file and leave the rest of the site as-is? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
syl22-00
Jan 7, 2014
Member
@jdragojevic , can we discuss it in our weekly sync-up? I can certainly work on it.
|
@jdragojevic , can we discuss it in our weekly sync-up? I can certainly work on it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 8, 2014
Contributor
@jdragojevic That's what we are doing right now. Unfortunately, 63 pages inherit from base.html, and since its structure has changed, it's possible that we'll have more broken pages
|
@jdragojevic That's what we are doing right now. Unfortunately, 63 pages inherit from base.html, and since its structure has changed, it's possible that we'll have more broken pages |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bendk
Jan 8, 2014
Member
Is the point simply to change the homepage? In that case, maybe we could either:
- Not make the homepage inherit from base.html
- Split base.html into 2 parts, base-site.html which is used by all pages, including the home page. And base.html which inherits from base-site.html and is used by all pages except the home page.
|
Is the point simply to change the homepage? In that case, maybe we could either:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Second option sounds more appropriated and logical to me. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
Jan 8, 2014
when you click on 'contact us' , we pop up this form.
note that the form is the same as on this page --
http://about.amara.org/enterprise/
maybe we can use that same form code?
i will attach the separate assets in a sec
reville
commented
Jan 8, 2014
|
when you click on 'contact us' , we pop up this form. note that the form is the same as on this page -- http://about.amara.org/enterprise/ maybe we can use that same form code? i will attach the separate assets in a sec |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
Jan 8, 2014
text is:
"Interested in ordering captions or subtitles?
Want to learn more about Amara’s collaboration platform?"
"Or get in touch anytime: enterprise@amara.org | +1-617-299-1187"
reville
commented
Jan 8, 2014
|
text is: "Interested in ordering captions or subtitles? "Or get in touch anytime: enterprise@amara.org | +1-617-299-1187" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
commented
Jan 8, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
commented
Jan 8, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 9, 2014
Contributor
So, the approach I took was somewhat similar to what you @bendk suggested. Index.html doesn't include anything, and all other templates that needs base.html, will continue to include it but with a few changes (header and footer).
I've already managed to get this working here, but there is some polish to be done. Feedbacks on this approach?
|
So, the approach I took was somewhat similar to what you @bendk suggested. Index.html doesn't include anything, and all other templates that needs base.html, will continue to include it but with a few changes (header and footer). I've already managed to get this working here, but there is some polish to be done. Feedbacks on this approach? |
added a commit
that referenced
this issue
Jan 9, 2014
added a commit
that referenced
this issue
Jan 9, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Message for the night : Css conflicts are boring. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jdragojevic
Jan 9, 2014
Contributor
@marcussaad testing commit fa8ba34
- Pages have a loading message in the top bar
- Height / Width issues - the head is pushed way down, the footer appear to be a fixed distance and doesn't account for longer page content. The page itself isn't responsive to narrowing the browser width.
|
@marcussaad testing commit fa8ba34
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 10, 2014
Contributor
@syl22-00, can you help me on this when possible? I'm a disaster with css.
I was trying to get the fonts to work, but they were being interpreted as application/stream-octet. Path was correct, but they weren't being showed.
|
@syl22-00, can you help me on this when possible? I'm a disaster with css. I was trying to get the fonts to work, but they were being interpreted as application/stream-octet. Path was correct, but they weren't being showed. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
syl22-00
Jan 11, 2014
Member
Sure @marcussaad I'll look at it over the week-end. I agree that working with CSS is very... painful.
|
Sure @marcussaad I'll look at it over the week-end. I agree that working with CSS is very... painful. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
reville
Jan 13, 2014
looking at: http://gh-1146.amara.org/en/
a few notes:
• All buttons should have white text
• ‘individuals volunteers’ etc should become blue text and bold. and it should swap above ‘publish with’
• amara logo and nav links should be vertically centered with the search box
reville
commented
Jan 13, 2014
|
looking at: http://gh-1146.amara.org/en/ a few notes: • All buttons should have white text • ‘individuals volunteers’ etc should become blue text and bold. and it should swap above ‘publish with’ • amara logo and nav links should be vertically centered with the search box |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marcussaad
Jan 14, 2014
Contributor
@syl22-00 I've got your email and it makes sense those jquery conflicts.
I was talking to @reville , we had a severe thunderstorm here on saturday that toasted my notebook and monitor. I'm waiting to see if it can be fixed, talking from a raspberry pi right now. I would like to kindly ask if you can take over this issue, since I can't do it right now.
|
@syl22-00 I've got your email and it makes sense those jquery conflicts. I was talking to @reville , we had a severe thunderstorm here on saturday that toasted my notebook and monitor. I'm waiting to see if it can be fixed, talking from a raspberry pi right now. I would like to kindly ask if you can take over this issue, since I can't do it right now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
syl22-00
Jan 16, 2014
Member
No worry @marcussaad , I sympatize, although I miss my raspberry pi which is somewhere on the ocean between China and France.
|
No worry @marcussaad , I sympatize, although I miss my raspberry pi which is somewhere on the ocean between China and France. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Closing this one as obsolete. |






marcussaad commentedJan 5, 2014
This bug is to keep track of the integration of the new layout and design for Amara's landing page