New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New website design #1146

Closed
marcussaad opened this Issue Jan 5, 2014 · 22 comments

Comments

Projects
None yet
5 participants
@marcussaad
Contributor

marcussaad commented Jan 5, 2014

This bug is to keep track of the integration of the new layout and design for Amara's landing page

@ghost ghost assigned marcussaad Jan 5, 2014

@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 5, 2014

Contributor

Will we be adding translations for this already? Taking a general look on our current layout, it has markups for translations. should I do the same for the new phrases?

Also, when changing header and footer, should I leave the announcements that appear on top?

There are several things that will be touched/damaged with this new layout

Contributor

marcussaad commented Jan 5, 2014

Will we be adding translations for this already? Taking a general look on our current layout, it has markups for translations. should I do the same for the new phrases?

Also, when changing header and footer, should I leave the announcements that appear on top?

There are several things that will be touched/damaged with this new layout

marcussaad added a commit that referenced this issue Jan 5, 2014

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Jan 7, 2014

Contributor
  • I see this error when I try to run compile_media on the branch
Traceback (most recent call last):
  File "/opt/apps/unisubs/manage.py", line 50, in <module>
    execute_manager(settings)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 564, in handle
    self._compile_media_bundles(restrict_bundles, args)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 482, in _compile_media_bundles
    bundle_name, data['type'], data["files"])
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 366, in compile_media_bundle
    getattr(self, "compile_%s_bundle" % bundle_type)(bundle_name, files)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 173, in compile_css_bundle
    open(f).read()
IOError: [Errno 2] No such file or directory: '/opt/apps/unisubs/media/css/html.css'
  • large banner (We <3 subtitles) displays on all pages.
    msaad: Should be fixed
  • watch page styling is messed up, language pulldowns don't work.
Contributor

jdragojevic commented Jan 7, 2014

  • I see this error when I try to run compile_media on the branch
Traceback (most recent call last):
  File "/opt/apps/unisubs/manage.py", line 50, in <module>
    execute_manager(settings)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/opt/ve/unisubs/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 564, in handle
    self._compile_media_bundles(restrict_bundles, args)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 482, in _compile_media_bundles
    bundle_name, data['type'], data["files"])
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 366, in compile_media_bundle
    getattr(self, "compile_%s_bundle" % bundle_type)(bundle_name, files)
  File "/opt/apps/unisubs/apps/unisubs_compressor/management/commands/compile_media.py", line 173, in compile_css_bundle
    open(f).read()
IOError: [Errno 2] No such file or directory: '/opt/apps/unisubs/media/css/html.css'
  • large banner (We <3 subtitles) displays on all pages.
    msaad: Should be fixed
  • watch page styling is messed up, language pulldowns don't work.
@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 7, 2014

Contributor

This is not going to be an easy or fast process and I'll let you guys know why so that we can think what to do.

Touching the file base.html which includes Header, footer and where other templating blocks are included is problematic. These new changes broke all the css from other pages, because div ids changed, div classes changed and also parent nodes.

A css that was applied using body #main #wrapper won't work any more because the structure changed to something else, Ex: body #wrapper. It isn't that simple in our case, but to illustrate what is happening it serves the purpose.

The result of this problem?

http://imgur.com/AEjOOkW

This will demand long and extensive css fixing, and currently we have more than 46 css files.

Ideas?

Contributor

marcussaad commented Jan 7, 2014

This is not going to be an easy or fast process and I'll let you guys know why so that we can think what to do.

Touching the file base.html which includes Header, footer and where other templating blocks are included is problematic. These new changes broke all the css from other pages, because div ids changed, div classes changed and also parent nodes.

A css that was applied using body #main #wrapper won't work any more because the structure changed to something else, Ex: body #wrapper. It isn't that simple in our case, but to illustrate what is happening it serves the purpose.

The result of this problem?

http://imgur.com/AEjOOkW

This will demand long and extensive css fixing, and currently we have more than 46 css files.

Ideas?

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville Jan 7, 2014

We might need sylvain's help on this...

reville commented Jan 7, 2014

We might need sylvain's help on this...

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Jan 7, 2014

Contributor

Is it possible to make the home page use a separate css file and leave the rest of the site as-is?

Contributor

jdragojevic commented Jan 7, 2014

Is it possible to make the home page use a separate css file and leave the rest of the site as-is?

@syl22-00

This comment has been minimized.

Show comment
Hide comment
@syl22-00

syl22-00 Jan 7, 2014

Member

@jdragojevic , can we discuss it in our weekly sync-up? I can certainly work on it.

Member

syl22-00 commented Jan 7, 2014

@jdragojevic , can we discuss it in our weekly sync-up? I can certainly work on it.

@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 8, 2014

Contributor

@jdragojevic That's what we are doing right now. Unfortunately, 63 pages inherit from base.html, and since its structure has changed, it's possible that we'll have more broken pages

Contributor

marcussaad commented Jan 8, 2014

@jdragojevic That's what we are doing right now. Unfortunately, 63 pages inherit from base.html, and since its structure has changed, it's possible that we'll have more broken pages

@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Jan 8, 2014

Member

Is the point simply to change the homepage? In that case, maybe we could either:

  • Not make the homepage inherit from base.html
  • Split base.html into 2 parts, base-site.html which is used by all pages, including the home page. And base.html which inherits from base-site.html and is used by all pages except the home page.
Member

bendk commented Jan 8, 2014

Is the point simply to change the homepage? In that case, maybe we could either:

  • Not make the homepage inherit from base.html
  • Split base.html into 2 parts, base-site.html which is used by all pages, including the home page. And base.html which inherits from base-site.html and is used by all pages except the home page.
@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 8, 2014

Contributor

Second option sounds more appropriated and logical to me.

Contributor

marcussaad commented Jan 8, 2014

Second option sounds more appropriated and logical to me.

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville Jan 8, 2014

when you click on 'contact us' , we pop up this form.

note that the form is the same as on this page --

http://about.amara.org/enterprise/

maybe we can use that same form code?

pastedgraphic-8

i will attach the separate assets in a sec

reville commented Jan 8, 2014

when you click on 'contact us' , we pop up this form.

note that the form is the same as on this page --

http://about.amara.org/enterprise/

maybe we can use that same form code?

pastedgraphic-8

i will attach the separate assets in a sec

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville Jan 8, 2014

text is:

"Interested in ordering captions or subtitles?
Want to learn more about Amara’s collaboration platform?"

"Or get in touch anytime: enterprise@amara.org | +1-617-299-1187"

reville commented Jan 8, 2014

text is:

"Interested in ordering captions or subtitles?
Want to learn more about Amara’s collaboration platform?"

"Or get in touch anytime: enterprise@amara.org | +1-617-299-1187"

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville commented Jan 8, 2014

amara-homepage-background-popup

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville Jan 8, 2014

this is a big image, but we could just use a piece of it and pattern it. i'm not sure what's better

55percent-opaque-background

reville commented Jan 8, 2014

this is a big image, but we could just use a piece of it and pattern it. i'm not sure what's better

55percent-opaque-background

@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 9, 2014

Contributor

So, the approach I took was somewhat similar to what you @bendk suggested. Index.html doesn't include anything, and all other templates that needs base.html, will continue to include it but with a few changes (header and footer).

I've already managed to get this working here, but there is some polish to be done. Feedbacks on this approach?

Contributor

marcussaad commented Jan 9, 2014

So, the approach I took was somewhat similar to what you @bendk suggested. Index.html doesn't include anything, and all other templates that needs base.html, will continue to include it but with a few changes (header and footer).

I've already managed to get this working here, but there is some polish to be done. Feedbacks on this approach?

marcussaad added a commit that referenced this issue Jan 9, 2014

GH-1146 - Revert html.css, Index page won't include any other templat…
…e, base.html is changed to have the new header and footer
@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 9, 2014

Contributor

Message for the night :

Css conflicts are boring.

Contributor

marcussaad commented Jan 9, 2014

Message for the night :

Css conflicts are boring.

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Jan 9, 2014

Contributor

@marcussaad testing commit fa8ba34

  • Pages have a loading message in the top bar
  • Height / Width issues - the head is pushed way down, the footer appear to be a fixed distance and doesn't account for longer page content. The page itself isn't responsive to narrowing the browser width.

height-width

login_page

  • Browse link on header goes to videos/create, should be videos/watch
  • When user is logged in the user menu is expanded, missing the menu styles.
    logged_in
  • Select your Languages non-functional
Contributor

jdragojevic commented Jan 9, 2014

@marcussaad testing commit fa8ba34

  • Pages have a loading message in the top bar
  • Height / Width issues - the head is pushed way down, the footer appear to be a fixed distance and doesn't account for longer page content. The page itself isn't responsive to narrowing the browser width.

height-width

login_page

  • Browse link on header goes to videos/create, should be videos/watch
  • When user is logged in the user menu is expanded, missing the menu styles.
    logged_in
  • Select your Languages non-functional
@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 10, 2014

Contributor

@syl22-00, can you help me on this when possible? I'm a disaster with css.

I was trying to get the fonts to work, but they were being interpreted as application/stream-octet. Path was correct, but they weren't being showed.

Contributor

marcussaad commented Jan 10, 2014

@syl22-00, can you help me on this when possible? I'm a disaster with css.

I was trying to get the fonts to work, but they were being interpreted as application/stream-octet. Path was correct, but they weren't being showed.

@syl22-00

This comment has been minimized.

Show comment
Hide comment
@syl22-00

syl22-00 Jan 11, 2014

Member

Sure @marcussaad I'll look at it over the week-end. I agree that working with CSS is very... painful.

Member

syl22-00 commented Jan 11, 2014

Sure @marcussaad I'll look at it over the week-end. I agree that working with CSS is very... painful.

@reville

This comment has been minimized.

Show comment
Hide comment
@reville

reville Jan 13, 2014

looking at: http://gh-1146.amara.org/en/

a few notes:

• All buttons should have white text

• ‘individuals volunteers’ etc should become blue text and bold. and it should swap above ‘publish with’

• amara logo and nav links should be vertically centered with the search box

reville commented Jan 13, 2014

looking at: http://gh-1146.amara.org/en/

a few notes:

• All buttons should have white text

• ‘individuals volunteers’ etc should become blue text and bold. and it should swap above ‘publish with’

• amara logo and nav links should be vertically centered with the search box

@marcussaad

This comment has been minimized.

Show comment
Hide comment
@marcussaad

marcussaad Jan 14, 2014

Contributor

@syl22-00 I've got your email and it makes sense those jquery conflicts.

I was talking to @reville , we had a severe thunderstorm here on saturday that toasted my notebook and monitor. I'm waiting to see if it can be fixed, talking from a raspberry pi right now. I would like to kindly ask if you can take over this issue, since I can't do it right now.

Contributor

marcussaad commented Jan 14, 2014

@syl22-00 I've got your email and it makes sense those jquery conflicts.

I was talking to @reville , we had a severe thunderstorm here on saturday that toasted my notebook and monitor. I'm waiting to see if it can be fixed, talking from a raspberry pi right now. I would like to kindly ask if you can take over this issue, since I can't do it right now.

@syl22-00

This comment has been minimized.

Show comment
Hide comment
@syl22-00

syl22-00 Jan 16, 2014

Member

No worry @marcussaad , I sympatize, although I miss my raspberry pi which is somewhere on the ocean between China and France.

Member

syl22-00 commented Jan 16, 2014

No worry @marcussaad , I sympatize, although I miss my raspberry pi which is somewhere on the ocean between China and France.

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Jan 9, 2015

Contributor

Closing this one as obsolete.

Contributor

jdragojevic commented Jan 9, 2015

Closing this one as obsolete.

@jdragojevic jdragojevic closed this Jan 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment