New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clickable URL's in Team Application #1231

Closed
darren-bridenbeck opened this Issue Feb 12, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@darren-bridenbeck

darren-bridenbeck commented Feb 12, 2014

Currently, if you add a URL to a team application under "Settings" --> "Messages" the URL displays in the application, but is not a live link.

Ideally, these URL's would be clickable. This type of feature is already supported if a URL is added to the "When Translating", "When Transcribing", or "When Reviewing" messages.

Example of what I'd like to add to a team application, below:

Thank you for applying to the XYZ project! We're excited to add you to our community and get going, but there's just a bit of information we need first:

All volunteers must agree to with the following documents. Agreeing to these helps protect children and ensure that our volunteers are respectful of sensitive content.

Confidentiality Agreement
http://bit.ly/1olOqLT

World Vision’s Child Protection Policy
http://s3.amazonaws.com/amara-video/w-i/WVI+Child+Protection.pdf

@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Feb 26, 2014

Member

I just tested this and I believe links are clickable. Make sure you add the http:// part though. I'm going to close this for now, but please re-open if there's an issue I'm not seeing.

Member

bendk commented Feb 26, 2014

I just tested this and I believe links are clickable. Make sure you add the http:// part though. I'm going to close this for now, but please re-open if there's an issue I'm not seeing.

@bendk bendk closed this Feb 26, 2014

@jdragojevic jdragojevic reopened this Feb 27, 2014

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Feb 27, 2014

Contributor

I'm not seeing the text as active links:
image

To reproduce: Set a team as application only. On the settings messages tab, add in some links.

image

Contributor

jdragojevic commented Feb 27, 2014

I'm not seeing the text as active links:
image

To reproduce: Set a team as application only. On the settings messages tab, add in some links.

image

bendk added a commit that referenced this issue Feb 27, 2014

Fix urlize in the team applications (#1231)
We should run the text through urlize before linebreaksbr.  When the
<br>s are in the text, then there's no whitespace between words and
that confuses urlize.
@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Feb 27, 2014

Member

I see the issue now. It doesn't happen if there are no linebreaks in the text. The above change should fix it.

Member

bendk commented Feb 27, 2014

I see the issue now. It doesn't happen if there are no linebreaks in the text. The above change should fix it.

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Feb 28, 2014

Contributor

looks good for me.

Contributor

jdragojevic commented Feb 28, 2014

looks good for me.

syl22-00 added a commit that referenced this issue Feb 28, 2014

Merge pull request #1269 from pculture/gh-1231
Fix urlize in the team applications (#1231)

@jdragojevic jdragojevic closed this Mar 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment