New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jspScrollbars go crazy when you hit a breakpoint #3097

Closed
kslottow opened this Issue Jan 19, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@kslottow
Contributor

kslottow commented Jan 19, 2018

@bendk commented on Fri Jan 19 2018

When you hit a breakpoint and the content width shrinks, the scrollbars get positioned in a crazy place:

screenshot from 2018-01-19 13-20-40

Maybe we should just move away from jspScrollbar.

@kslottow kslottow added this to the Sprint 31 milestone Jan 19, 2018

@kslottow

This comment has been minimized.

Contributor

kslottow commented Jan 19, 2018

we'll get rid of this library

@bendk bendk modified the milestones: Sprint 31, Sprint 32 Feb 7, 2018

@kslottow kslottow modified the milestones: Sprint 32, Sprint 33 Feb 22, 2018

@bendk bendk modified the milestones: Sprint 33, Sprint 34, Sprint 35 Mar 7, 2018

@bendk bendk modified the milestones: Sprint 35, Sprint 36 Apr 4, 2018

bendk added a commit that referenced this issue Apr 6, 2018

@bendk

This comment has been minimized.

Member

bendk commented Apr 6, 2018

Fixed in the gh-enterprise-1624 branch.

@bendk

This comment has been minimized.

Member

bendk commented Apr 6, 2018

The fix was to just use native scrollbars so we don't have the issue.

I also upped the min-height a bit so the video duration filter doesn't need a scrollbar. I don't think this needs testing, so I'm just going to put it in the needs PR pipeline.

bendk added a commit that referenced this issue Apr 6, 2018

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented Apr 25, 2018

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment