New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITT fails to upload with literal musical character #3204

Closed
franontanaya opened this Issue May 7, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@franontanaya
Contributor

franontanaya commented May 7, 2018

Sample attached.

The literal ♪ character prevents the file from successfully uploading to Amara.
sample.itt.zip

@kslottow kslottow added this to the Sprint 38 milestone May 7, 2018

@bendk bendk modified the milestones: Sprint 38, Sprint 39 May 16, 2018

@bendk

This comment has been minimized.

Member

bendk commented May 23, 2018

This was a really easy one to fix. I just pushed the fix directly to dev.

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented May 26, 2018

Fixed inside the subtitle editor, but not in Upload dialog on the video details page.

@bendk

This comment has been minimized.

Member

bendk commented May 29, 2018

That one should be fixed too now.

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented May 29, 2018

Verified for in-editor, upload dialog, and API uploads.

When downloading an ITT file, the music symbol is escaped as ♪

@danantonioreyes

This comment has been minimized.

Collaborator

danantonioreyes commented Jun 5, 2018

I thought there were still some things to review here, seems like I am too late to the party.

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented Jun 13, 2018

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment