New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reading speed in real time as start or end time for a subtitle changes #3228

Closed
PCF-Testing opened this Issue May 30, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@PCF-Testing
Member

PCF-Testing commented May 30, 2018

Steps to reproduce:

  1. Open a synced set of subtitles for editing.
  2. Click on a subtitle set to expose an info tray with the timing, character count, and reading speed info.
  3. Seek to the subtitle.
  4. On the timeline, drag the start or end time of the current subtitle.

Observed: the start or end time in the info tray changes as the subtitle edge is being dragged, but the reading speed does not change in the real time. It should.

https://pculture.freshdesk.com/a/tickets/102115
https://pculture.freshdesk.com/a/tickets/102118
https://support.amara.org/a/tickets/102120

@Rieann

This comment has been minimized.

Collaborator

Rieann commented May 30, 2018

@bendk

This comment has been minimized.

Member

bendk commented May 30, 2018

Fixed in the editor-fixes branch

@bendk bendk self-assigned this May 30, 2018

bendk added a commit that referenced this issue May 30, 2018

@bendk bendk added this to the Sprint 40 milestone May 30, 2018

bendk added a commit that referenced this issue May 30, 2018

@bendk

This comment has been minimized.

Member

bendk commented May 30, 2018

This on was pretty high priority, so I cherry-picked it directly to production.

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented May 31, 2018

Sorry, still happening both on the branch and on production. The timestamps and reading speed in the info flyout do not get updated in real time as the subtitle edge is being dragged.

@bendk

This comment has been minimized.

Member

bendk commented May 31, 2018

I thought this one was about the ! icon that displays next to the subtitle. I can also fix the info flyout.

@bendk

This comment has been minimized.

Member

bendk commented May 31, 2018

The other new issue is that for unsynced subtitles, when you start the drag you sometimes can get duplicate ones.

@PCF-Testing

This comment has been minimized.

Member

PCF-Testing commented May 31, 2018

What is the scenario for dragging an untimed subtitle?

I am seeing a different problem on production - if a time change is undone with CTRL+Z, the info tray does not get updated accordingly. It should, both on Undo and Redo.

@bendk

This comment has been minimized.

Member

bendk commented Jun 1, 2018

Actually the scenario above was dragging the subtitle being edited. It didn't matter if it was synced or not.

I made #3230 for the ctrl-z issue. Let's keep this one focused on the really bad issues that needed a hotfix.

@bendk

This comment has been minimized.

Member

bendk commented Jun 1, 2018

I'm pretty sure this particular issue is now fixed on production. There are a lot of side issues, I made #3233 for those.

@bendk bendk closed this Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment