New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing translations don't show speaker name field in editors. #787

Closed
jdragojevic opened this Issue Jul 26, 2013 · 8 comments

Comments

Projects
None yet
4 participants
@jdragojevic
Contributor

jdragojevic commented Jul 26, 2013

Here is the video on staging: http://staging.amara.org/en/videos/TpV94Bit7qWr/en/410580/

Korean language when edited doesn't display the blank field for speaker name.

Checking in django-admin - I do see the meta_fields present.

Expected:

when speaker name does not exist in the selected language, expected behavior is to see the 'speaker name' text field with no content.

@ghost ghost assigned bendk Jul 26, 2013

bendk added a commit that referenced this issue Jul 29, 2013

Include empty metadata in the editor fields (#787)
This fixes both the old and new editors

bendk added a commit that referenced this issue Jul 29, 2013

Merge pull request #795 from pculture/gh-787
Include empty metadata in the editor fields (#787)
@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Jul 30, 2013

Contributor

@alexdean - the fix is availble on staging for you to checkout.

Contributor

jdragojevic commented Jul 30, 2013

@alexdean - the fix is availble on staging for you to checkout.

@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Jul 30, 2013

Member

I'm pretty sure this one is working out. I'm going to mark it fixed because I'm not planning on doing any more work on it at this point. If there's an issue, please add a comment and I can take a look at it.

Member

bendk commented Jul 30, 2013

I'm pretty sure this one is working out. I'm going to mark it fixed because I'm not planning on doing any more work on it at this point. If there's an issue, please add a comment and I can take a look at it.

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Aug 2, 2013

Contributor

this was tested and is ok best I can tell. closing.

Contributor

jdragojevic commented Aug 2, 2013

this was tested and is ok best I can tell. closing.

@jdragojevic jdragojevic closed this Aug 2, 2013

@alexdean

This comment has been minimized.

Show comment
Hide comment
@alexdean

alexdean Aug 3, 2013

@jzurawell sent me and email stating this is still an issue for English transcripts.

alexdean commented Aug 3, 2013

@jzurawell sent me and email stating this is still an issue for English transcripts.

@jzurawell

This comment has been minimized.

Show comment
Hide comment
@jzurawell

jzurawell Aug 4, 2013

I believe split speaker name fields are missing only from talks which were ingested to the Transcribe team without having a separate speaker name entered in our CMS + weren't split in the CSV.

Freshdesk ticket #7429 is related.

jzurawell commented Aug 4, 2013

I believe split speaker name fields are missing only from talks which were ingested to the Transcribe team without having a separate speaker name entered in our CMS + weren't split in the CSV.

Freshdesk ticket #7429 is related.

@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Aug 5, 2013

Member

This will be an issue for all videos that didn't go through one of these processes:

  • Ingested via the CSV file that Alex sent me
  • Ingested via the atom feed (with ted:speaker-name present)

Are the talks that the fields are missing special cases that we missed with the CSV import, or are we did we not account for a way that talks regularly get imported? If it's the former, we should just clean them up via the admin, if it's the latter then I may need to add functionality.

Member

bendk commented Aug 5, 2013

This will be an issue for all videos that didn't go through one of these processes:

  • Ingested via the CSV file that Alex sent me
  • Ingested via the atom feed (with ted:speaker-name present)

Are the talks that the fields are missing special cases that we missed with the CSV import, or are we did we not account for a way that talks regularly get imported? If it's the former, we should just clean them up via the admin, if it's the latter then I may need to add functionality.

@bendk bendk reopened this Aug 5, 2013

@jzurawell

This comment has been minimized.

Show comment
Hide comment
@jzurawell

jzurawell Aug 5, 2013

It's the former. These talks were ingested via atom feed without a speaker name. These talks also didn't have finalized titles at the time of CSV import, so they weren't on the CSV.

jzurawell commented Aug 5, 2013

It's the former. These talks were ingested via atom feed without a speaker name. These talks also didn't have finalized titles at the time of CSV import, so they weren't on the CSV.

@jdragojevic

This comment has been minimized.

Show comment
Hide comment
@jdragojevic

jdragojevic Aug 8, 2013

Contributor

@jzurawell sent me a list of the videos missing the field via freshdesk ticket 7429. It was a small list and I manually updated the videos on the site. Closing this ticket.

If there are any new videos that come up, let's just resolve via the freshdesk ticket, or a new one since it's more of a support issue.

Contributor

jdragojevic commented Aug 8, 2013

@jzurawell sent me a list of the videos missing the field via freshdesk ticket 7429. It was a small list and I manually updated the videos on the site. Closing this ticket.

If there are any new videos that come up, let's just resolve via the freshdesk ticket, or a new one since it's more of a support issue.

@jdragojevic jdragojevic closed this Aug 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment