Gh 1208

[jdragojevic]

multiple-tab playback issues are resolved for me.

[bendk]

I'm a little worried about this fix since it's not guaranteed that we can add a query param and get the same video back. I'm pretty sure that this will work on at least 99.9% of all videos out there, but I wonder if some servers will return something different. There's also a small chance that the URL already includes a noise param.

If there's no other way to fix the problem, then I guess we have no choice but to go with the hack. But maybe we should limit it to only chrome, and also change the query param to amaranoise or something like that to lower the chance of a name collision.

[bendk]

I'm a little worried about this fix since it's not guaranteed that we can add a query param and get the same video back. I'm pretty sure that this will work on at least 99.9% of all videos out there, but I wonder if some servers will return something different. There's also a small chance that the URL already includes a noise param.

If there's no other way to fix the problem, then I guess we have no choice but to go with the hack. But maybe we should limit it to only chrome, and also change the query param to amaranoise or something like that to lower the chance of a name collision.

[syl22-00]

@bendk you're right for the parameter name, I'll change it.

I am not very happy with the fix either, it also might prevent caching the video. The problem is that the issue itself is not clear, and it's more a hack around that unclear browser issue.

I'll also try to limit its scope (only html5 videos on chrome).

[syl22-00]

@bendk you're right for the parameter name, I'll change it.

I am not very happy with the fix either, it also might prevent caching the video. The problem is that the issue itself is not clear, and it's more a hack around that unclear browser issue.

I'll also try to limit its scope (only html5 videos on chrome).

[syl22-00]

@bendk I made the few changes we discussed above, do you think that's OK/better? @jdragojevic would you mind giving it another try, trying to cover most of our possible URLs?

[syl22-00]

@bendk I made the few changes we discussed above, do you think that's OK/better? @jdragojevic would you mind giving it another try, trying to cover most of our possible URLs?

[bendk]

The changes look good to me.

[bendk]

The changes look good to me.