Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

2163: don't create a new subtitle version when tasks are approved #140

Merged
merged 1 commit into from Mar 29, 2013

Conversation

Projects
None yet
3 participants
Owner

bendk commented Mar 27, 2013

This change replaces the old code that always created a new version with new code that simple changes the visibility of the current version to public.

One difference is that before we would be able to set the author of the version to the reviewer/approver, rather than the original owner. However, if the reviewer/approver makes any changes then we create a new version anyways. So this only matters in the case where no changes are made. Still I'm not 100% sure that this is correct.

Contributor

sjl commented Mar 28, 2013

This seems okay aside from the issue you mentioned. Let's hope we don't get a ticket down the road that says "show who approved this version".

Contributor

arthur-debert commented Mar 28, 2013

Oh , just remember, this will be a problem. T uses the reviewer's name, we can't break that, see
https://github.com/pculture/unisubs-integration/blob/production/apiv2/api.py#L1220

In our dev branch, that was removed (but it's definitely wrong)

Owner

bendk commented Mar 28, 2013

We still call set_approved_by() and set_reviewed_by(), we simply call it on the existing SubtitleVersion object rather than a copy of it. Seems like we're not losing any data in this case.

Owner

bendk commented Mar 29, 2013

I checked via the django shell and get_approved_by() and get_moderated_by() return the user who approved/moderated the subtitles, so I think this is good.

Arthur suggested to look at /api2/partners/videos/[video-id]/languages/[language-code]/?format=json, but it doesn't seem to me that that outputs the approved by data. Maybe it was removed in the dev branch? In any case, I think we can merge.

@bendk bendk added a commit that referenced this pull request Mar 29, 2013

@bendk bendk Merge pull request #140 from bendk/x-2163
2163: don't create a new subtitle version when tasks are approved
ddaf3f6

@bendk bendk merged commit ddaf3f6 into pculture:dev Mar 29, 2013

@bendk bendk deleted the unknown repository branch Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment