New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbtuning4 #775

Merged
merged 2 commits into from Jul 30, 2013

Conversation

Projects
None yet
3 participants
@jdragojevic
Contributor

jdragojevic commented Jul 25, 2013

@bendk : I finished running the selenium tests for this branch on jenkins and it is safe to merge into staging.

bendk added some commits Jul 24, 2013

Speed up Team.videos_count
This way removes the join to the videos table and simply counts from
the team videos table.
Removed GROUP BY in the teams_project template tag.
We were doing a fairly expensive group by, but not even using the
results of it.

Also removed a couple templates that we don't use anymore.
@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Jul 25, 2013

Member

I'll let Evan merge this one, since it would be nice to have some peer review and he's going to be the one to push it to production in the end anyways.

Member

bendk commented Jul 25, 2013

I'll let Evan merge this one, since it would be nice to have some peer review and he's going to be the one to push it to production in the end anyways.

@ehazlett

This comment has been minimized.

Show comment
Hide comment
@ehazlett

ehazlett Jul 29, 2013

Contributor

So were those templates not needed?

Contributor

ehazlett commented Jul 29, 2013

So were those templates not needed?

@bendk

This comment has been minimized.

Show comment
Hide comment
@bendk

bendk Jul 29, 2013

Member

I did a grep for them, and as far as I could tell they weren't being used. Janet's testing didn't show anything, so I think they're safe to delete.

Member

bendk commented Jul 29, 2013

I did a grep for them, and as far as I could tell they weren't being used. Janet's testing didn't show anything, so I think they're safe to delete.

@ehazlett

This comment has been minimized.

Show comment
Hide comment
@ehazlett

ehazlett Jul 30, 2013

Contributor

👍

Contributor

ehazlett commented Jul 30, 2013

👍

ehazlett added a commit that referenced this pull request Jul 30, 2013

@ehazlett ehazlett merged commit d7c10b8 into staging Jul 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment