New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-937 - Increasing idle period before showing the countdown to timeout. #943

Merged
merged 13 commits into from Sep 27, 2013

Conversation

Projects
None yet
4 participants
@jdragojevic
Contributor

jdragojevic commented Sep 27, 2013

Increased from 5 minutes to 15 minutes. Countdown still takes 120 seconds (2 minutes) before user is expired.

Looks pretty straight-forward. We should merge this.

bendk and others added some commits Sep 27, 2013

Blind fix for #484
I'm pretty sure this should do the trick though.
GH-937 - Increasing idle period before showing the countdown to timeout.
Increased from 5 minutes to 15 minutes. Countdown still takes 120 seconds (2 minutes) before user is expired.
Fork languages edited in the new editor (#463)
I used Janet's suggestion of simply forking everything edited in the
new editor.
Don't save unnecessarily in the new editor (#463)
Before we would save on approving because we wanted to mark the
subtitles complete.  Changed it so we only save if the subtitles
weren't previously completed.
Add more space to the old editor widget right side (#463)
This should give enough space for the open in new editor link to
display correctly.

Tried to line up the left side better with the right side as well.
Bumping integration repo
This gives us the subtitle_complete data when we fetch languages from
the API.
GH-937 - Increasing idle period before showing the countdown to timeout
Increased from 5 minutes to 15 minutes. Countdown still takes 120 seconds (2 minutes) before user is expired.
The config is split between two files, dialog.js is for the old editor, directives.js for the new.

ehazlett added a commit that referenced this pull request Sep 27, 2013

Merge pull request #943 from pculture/gh-937
GH-937 - Increasing idle period before showing the countdown to timeout.

@ehazlett ehazlett merged commit 68cffe3 into staging Sep 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment