Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pdb.orig_set_trace available #4

Closed
wants to merge 1 commit into from
Closed

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 25, 2019

Seems to be necessary for PYTHONBREAKPOINT.

PYTHONBREAKPOINT=pdb.pdb.set_trace python -c 'breakpoint()'
-c:1: RuntimeWarning: Ignoring unimportable $PYTHONBREAKPOINT: "pdb.pdb.set_trace"

I have improved this for pytest's --pdbcls to also handle attributes, but am not sure if it is acceptable/worth it for Python itself..
Ref: pytest-dev/pytest#4855

Moved from pdbpp/pdbpp#142.

@codecov-io
Copy link

codecov-io commented May 25, 2019

Codecov Report

Merging #4 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage    66.7%   66.57%   -0.13%     
==========================================
  Files           3        3              
  Lines        2580     2585       +5     
  Branches      228      228              
==========================================
  Hits         1721     1721              
- Misses        784      790       +6     
+ Partials       75       74       -1
Impacted Files Coverage Δ
testing/test_pdb.py 81.01% <100%> (+0.11%) ⬆️
pdb.py 45.25% <100%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad73a0b...5f99825. Read the comment docs.

@blueyed blueyed force-pushed the master branch 2 times, most recently from 4237618 to feb3acb Compare May 25, 2019 15:25
@blueyed
Copy link
Contributor Author

blueyed commented May 28, 2019

Back to pdbpp/pdbpp#142.

@blueyed blueyed closed this May 28, 2019
@blueyed blueyed deleted the orig_set_trace branch May 28, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants