Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lacking support for const visibility (PHP 7.1) #297

Open
torkiljohnsen opened this issue Feb 2, 2017 · 5 comments

Comments

@torkiljohnsen
Copy link

commented Feb 2, 2017

Reposting from PHPMD:
phpmd/phpmd#436

@kofan

This comment has been minimized.

Copy link

commented Jul 16, 2017

Is it going to be fixed some day or other?
Is this repository abandoned? There are no commits for more than 6 months already...

@niconoe-

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2017

It would be a good thing to fix this...
This is not a feature, it is really a bug since PHP is now 7.1.8, which means the 9th version of PHP 7.1 and this is not fixed yet.

A hint may be the overloading of the parseMethodOrFieldDeclaration method in the 7.1 parser class, but I'm not sure about the guidelines on how to propose a modification here.

mmucklo added a commit to mmucklo/pdepend that referenced this issue Aug 23, 2017
mmucklo added a commit to mmucklo/pdepend that referenced this issue Aug 23, 2017
mmucklo added a commit to mmucklo/pdepend that referenced this issue Aug 23, 2017
@eichie

This comment has been minimized.

Copy link

commented Oct 28, 2017

Hi, your changes works fine. But there are still problems on const definitions in interfaces.

emirb added a commit that referenced this issue Nov 10, 2017
Merge pull request #314 from mmucklo/master
Fix issue #297 adding support for constant visibility into the parser for PHP 7.1

@emirb emirb added this to the Support all language features milestone Nov 30, 2017

@krewetka

This comment has been minimized.

Copy link

commented Dec 6, 2017

is there any chance it will be finished soon? It is here since February and last release is almost a year old.

@kylekatarnls

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2019

Hi, PHP 7.1 missing features is now the very next priority for PDepend, they are:

  • Full support of void
  • Symmetric array destructuring
  • Class constant visibility
  • Multi catch exception handling

And the first two are about to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.