Add --quiet option. Closes #211 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given that we have printVersion(), printWorkarounds() and so on, it makes sense to encapsulate this functionality into a separate method, too.
the TextUI ResultPrinter will output directly to STDOUT. In order to implement a --quiet flag, we need an additional ResultPrinter that doesn't output anything. refs #211
we want to suppress any output that is not an error when running pdepend. For this I am adding a new option --quiet to the TextUI Command. Setting this flag will put pdepend into silent mode, meaning it will use the NulLResultPrinter instead of the regular ResultPrinter and it will not output version, workarounds and runtime statistics. It will output any errors though. Closes #211
We do not actually need the NullResultPrinter because if no ProcessListener is registered in the Runner, no output will be generated. So if the --quiet flag is set, we just don't add the regular ResultPrinter. And if the flag is not set, we do. Less code to maintain. refs #211
manuelpichler
pushed a commit
that referenced
this pull request
Dec 4, 2015
Add --quiet option. Closes #211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--quietoption that will suppress version, workarounds and runtime statistics, as well as any output the result printer would usually give when running pdepend from the command line.#211