New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 7.1 optionals #294

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@juliendufresne

juliendufresne commented Jan 11, 2017

This pull request tries to fix #279

It only skip the T_QUESTION_MARK whenever it finds it.
I'm not sure this is the way to support optionals for this project.

@manuelpichler manuelpichler self-requested a review Jan 16, 2017

@manuelpichler

Nice work, thx for your contribution

@manuelpichler manuelpichler added this to the 7.1 milestone Jan 16, 2017

@manuelpichler manuelpichler merged commit 69ad38b into pdepend:master Jan 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@juliendufresne juliendufresne deleted the juliendufresne:php71-optionals branch Jan 17, 2017

manuelpichler added a commit that referenced this pull request Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment