improved wacky wheels patch and added duke nukem 3d patch #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That pagefault patch is indeed strange. What version of Duke3D are you testing with? The patch doesn't apply with my copy of 1.3D. I also don't get any crash when I enable Sound Blaster + Adlib. |
|
So i've been unable to reproduce the pagefault, which is interesting. This was on 1.5 atomic edition. I'll also test the 1.3D version to see what's going on there. Edit: So i also tried the 1.3D version, that also worked flawlessly without the pagefault fix, so i'm just going to remove that for now |
|
Sorry, I completely forgot about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I improved my wacky wheels patch based on your pull request message. It looks a whole lot better now and uses the standard32.s file instead. I have tested it, and it works. I have also added a patch for Duke Nukem 3d, as I thought that was sorely missing.
I am unhappy about the way I fix the pagefault that you get whenever you have something like a soundblaster pro installed as well. (Or in my case soundblaster emulation from a neomagic 256av)
Maybe you have suggestions on how to make that better? Being able to reuse the call method in the replacement code without having to tell it the specific location would help