From 7ed0d6f2e8d5a8192c5621898b3ff920c95b66dc Mon Sep 17 00:00:00 2001
From: Peter De Wachter <pdewacht@gmail.com>
Date: Wed, 11 Apr 2018 22:45:08 +0200
Subject: [PATCH] Do not use delta-encoding across block boundaries

Possible a fix for issue #4

Also: in block.h, rename line_bytes_ to block_size_
---
 src/block.h | 21 ++++++++++++---------
 src/job.cc  | 31 +++++++++++++++++++------------
 2 files changed, 31 insertions(+), 21 deletions(-)

diff --git a/src/block.h b/src/block.h
index 13daea1..4d4ad3b 100644
--- a/src/block.h
+++ b/src/block.h
@@ -24,35 +24,38 @@
 
 class block {
  public:
-  block(): line_bytes_(0) {
+  block(): block_size_(0) {
     lines_.reserve(max_lines_per_block_);
   }
 
   bool empty() const {
-    return line_bytes_ == 0;
+    return block_size_ == 0;
+  }
+
+  bool full() const {
+    return lines_.size() == max_lines_per_block_;
   }
 
   void add_line(std::vector<uint8_t> &&line) {
     assert(!line.empty());
     assert(line_fits(line.size()));
-    line_bytes_ += line.size();
+    block_size_ += line.size();
     lines_.emplace_back(line);
   }
 
-  bool line_fits(unsigned size) {
-    return lines_.size() != max_lines_per_block_
-      && line_bytes_ + size < max_block_size_;
+  bool line_fits(unsigned line_size) const {
+    return !full() && block_size_ + line_size < max_block_size_;
   }
 
   void flush(FILE *f) {
     if (!empty()) {
       fprintf(f, "%dw%c%c",
-              line_bytes_ + 2, 0,
+              block_size_ + 2, 0,
               static_cast<int>(lines_.size()));
       for (auto &line : lines_) {
         fwrite(line.data(), 1, line.size(), f);
       }
-      line_bytes_ = 0;
+      block_size_ = 0;
       lines_.clear();
     }
   }
@@ -62,7 +65,7 @@ class block {
   static const unsigned max_lines_per_block_ = 128;
 
   std::vector<std::vector<uint8_t>> lines_;
-  int line_bytes_;
+  int block_size_;
 };
 
 #endif  // BLOCK_H
diff --git a/src/job.cc b/src/job.cc
index 440fc6d..95e23cd 100644
--- a/src/job.cc
+++ b/src/job.cc
@@ -91,24 +91,31 @@ void job::encode_page(const page_params &page_params,
     write_page_header();
   }
 
+  fputs("\033*b1030m", out_);
+
   std::vector<uint8_t> line(linesize);
   std::vector<uint8_t> reference(linesize);
   block block;
 
-  if (!nextline(line)) {
-    return;
-  }
-  block.add_line(encode_line(line));
-  std::swap(line, reference);
-
-  fputs("\033*b1030m", out_);
-
-  for (int i = 1; i < lines && nextline(line); ++i) {
-    std::vector<uint8_t> encoded = encode_line(line, reference);
-    if (!block.line_fits(encoded.size())) {
+  for (int i = 0; i < lines && nextline(line); ++i) {
+    if (block.empty()) {
+      // Beginning of a new block, do not apply delta-encoding.
+      block.add_line(encode_line(line));
+    } else {
+      // In the middle of a block, try delta-encoding.
+      std::vector<uint8_t> encoded = encode_line(line, reference);
+      if (block.line_fits(encoded.size())) {
+        // Ok, there's enough room for another line.
+        block.add_line(std::move(encoded));
+      } else {
+        // Oops, the line didn't fit. Start a new block.
+        block.flush(out_);
+        block.add_line(encode_line(line));
+      }
+    }
+    if (block.full()) {
       block.flush(out_);
     }
-    block.add_line(std::move(encoded));
     std::swap(line, reference);
   }