New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with librabbitmq 0.5, fix #177 #178

Merged
merged 2 commits into from Sep 19, 2015

Conversation

Projects
None yet
4 participants
@remicollet
Contributor

remicollet commented Sep 18, 2015

Seems simple, so probably worth to allow.

Notice: this commit also add missing reflection for getHeartbeatInterval and getMaxFrameSize (when available)

@remicollet

This comment has been minimized.

Show comment
Hide comment
@remicollet

remicollet Sep 18, 2015

Contributor

FYI, build.log against librabbitmq, RHEL-7 + EPEL (with this patch and pr #179 applied)
https://copr-be.cloud.fedoraproject.org/results/remi/php56more/epel-7-x86_64/00116516-php-pecl-amqp/build.log.gz

Contributor

remicollet commented Sep 18, 2015

FYI, build.log against librabbitmq, RHEL-7 + EPEL (with this patch and pr #179 applied)
https://copr-be.cloud.fedoraproject.org/results/remi/php56more/epel-7-x86_64/00116516-php-pecl-amqp/build.log.gz

lstrojny added a commit that referenced this pull request Sep 19, 2015

Merge pull request #178 from remicollet/issue-177
fix build with librabbitmq 0.5, fix #177

@lstrojny lstrojny merged commit e163f2b into pdezwart:master Sep 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lstrojny

This comment has been minimized.

Show comment
Hide comment
@lstrojny

lstrojny Sep 19, 2015

Collaborator

Thanks!

Collaborator

lstrojny commented Sep 19, 2015

Thanks!

@hanikesn

This comment has been minimized.

Show comment
Hide comment
@hanikesn

hanikesn Sep 23, 2015

The TravisCI file should probably also be updated, to test it with rabbitmq-0.5.2

hanikesn commented Sep 23, 2015

The TravisCI file should probably also be updated, to test it with rabbitmq-0.5.2

@pinepain

This comment has been minimized.

Show comment
Hide comment
@pinepain

pinepain Sep 24, 2015

Contributor

0.5.2 is pretty old. I hope we are not going to tests php-amqp against all existent rabbitmq-c versions, aren't we?

Contributor

pinepain commented Sep 24, 2015

0.5.2 is pretty old. I hope we are not going to tests php-amqp against all existent rabbitmq-c versions, aren't we?

b-harper pushed a commit to iuscommunity-pkg/php56u-pecl-amqp that referenced this pull request Dec 10, 2015

- update to 1.6.0beta4
- open pdezwart/php-amqp#178 - librabbitmq 0.5
- open pdezwart/php-amqp#179 --with-libdir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment